From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF1FDA0032; Tue, 16 Nov 2021 15:17:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8408440141; Tue, 16 Nov 2021 15:17:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id D2E6240040 for ; Tue, 16 Nov 2021 15:17:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637072243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X/wADxP7KyfcivpAb7eCttzzBr57xOainmGxvtZ3ZYA=; b=ANZvTVM7loqwfZpX9RKVlqMSUJlG7xanqLofR2nq1Cp/fVLY2NobLtdia6yvK9LZVRJpBb mEwNHOpXKWZ+/hAiTvQMgiGMC3/k5hsggSdvXmqfoZHj02kHR+2SJvKXoBS1wA3zBFoJ2P 2ubQmzEbuwzuuwMXOxbq7tzdzYFzA1Q= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-XGsOzuc-MRagSR1Kr07Tng-1; Tue, 16 Nov 2021 09:17:22 -0500 X-MC-Unique: XGsOzuc-MRagSR1Kr07Tng-1 Received: by mail-lf1-f69.google.com with SMTP id f11-20020ac24e4b000000b004001e7ea61cso8267595lfr.6 for ; Tue, 16 Nov 2021 06:17:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X/wADxP7KyfcivpAb7eCttzzBr57xOainmGxvtZ3ZYA=; b=rS0yvwkzeIBkDO9QReq95QHGHs3Y/XH79YT11W17edZv23SWKHaal+dxW8HZLNvne5 iLa+HYdXjdjCttmd0IXjBrYGEI1Q3L+PvqGb3O3P7I2ebajamBduLf5Tyc47AaCzdxsQ HRiY7/0M3D2pjMMtZEyhMzF265g9UitVgNtW1D3d6qkQPR8LS/sNAFNfyIDQtgP2Masb mIlV/wqj6yWl/DpfgUbJbtWOGGj3qiwvbCMOwc8XHMut8bpT10vKGmtcB2a9JXY/slRf G63r4RRCd8GohawS5sDPs1Qj2jLnXrPrG9XsNjISfv/grM8NEAZNEgJJDhdTGu11Caj6 /Czw== X-Gm-Message-State: AOAM533pl1O45u4/89fsACMD5nP75eu5DS9OlWvWwcccSxDGNgvOC/WZ yxfRitIunEBTXLat54VUhA/Qi9HUW0LYe7/rov9Rt/+5LL9UcIcS7NSP/fZJqpcn9VHiK8ml2VN xnIUdlM7iw7w2NZDMT5g= X-Received: by 2002:a05:6512:32c9:: with SMTP id f9mr7097105lfg.575.1637072240723; Tue, 16 Nov 2021 06:17:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4bTnvI9FwAIPEVMpxNV9rcpXrX0UI9lmQZGpVKinlYFINeIdmCt4Kp7jgijc0lWDcHe2uhEz5WbNKIfHfU94= X-Received: by 2002:a05:6512:32c9:: with SMTP id f9mr7097081lfg.575.1637072240512; Tue, 16 Nov 2021 06:17:20 -0800 (PST) MIME-Version: 1.0 References: <20211109172456.147140-1-vladimir.medvedkin@intel.com> <20211112141719.232932-1-vladimir.medvedkin@intel.com> In-Reply-To: From: David Marchand Date: Tue, 16 Nov 2021 15:17:09 +0100 Message-ID: Subject: Re: [PATCH v2] hash: fix thash gfni implementation To: Bruce Richardson Cc: Vladimir Medvedkin , dev , Thomas Monjalon , "Ananyev, Konstantin" , Lance Richardson , Ji@dpdk.org, Kai , Yipeng Wang , Sameh Gobriel Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 3:10 PM Bruce Richardson wrote: > > On Tue, Nov 16, 2021 at 02:53:49PM +0100, David Marchand wrote: > > On Fri, Nov 12, 2021 at 3:17 PM Vladimir Medvedkin > > wrote: > > > > > > 1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 > > > due to the lack of support by some compilers. > > > > Ok, it was the initial report from Lance. > > > > > 2. This patch checks if AVX512F is supported along with GFNI. > > > This is done if the code is built on a platform that supports GFNI, > > > but does not support AVX512. > > > > Ok. > > > > > 3. Also this patch fixes compilation problems on 32bit arch due to > > > lack of support for _mm_extract_epi64() by implementing XOR folding > > > with _mm_extract_epi32() on 32-bit arch. > > > > This code is under a #if defined(__GFNI__) && defined(__AVX512F__). > > > > Does such a 32 bits processor exist, that supports AVX512 and GFNI? > > > The processor would be 64-bit but the code could well be 32-bit, and even > then can still use these AVX512 instruction sets. Oh, thanks for the explanation. -- David Marchand