From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0853F425EA; Wed, 20 Sep 2023 15:53:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8132402E1; Wed, 20 Sep 2023 15:53:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D836F402C5 for ; Wed, 20 Sep 2023 15:53:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695218023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f1J1RZf2GV1WRH2qWeOWKsItvGtjbUnfEkeOmoudzUw=; b=SRQW4WqkE1SKgZKi3FWq1Wc9WeEuY3fMocOdWRR93o5G1YJRZ7ZFoFgOfwM25AfhDX2StN oEstqZ7ww93Sr48RdjLzmFEtH4u1hzKMZnp4iZKVffw1gImPzsLVov2ZjqKkZn048d/JDC /cuwcWGaA9xJ7rbN80XGRKD7DlS/ewA= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-UO62bHBNMjWGxXPgBe6r-w-1; Wed, 20 Sep 2023 09:53:42 -0400 X-MC-Unique: UO62bHBNMjWGxXPgBe6r-w-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2bce272ebdfso88015151fa.1 for ; Wed, 20 Sep 2023 06:53:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695218020; x=1695822820; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f1J1RZf2GV1WRH2qWeOWKsItvGtjbUnfEkeOmoudzUw=; b=qzhiETZEOkmLtj5XBhRAUt7cQqnC+TBJUMWtIsYi7qe41CUExzbB1QqYtrar1pkz35 fE04CDdarkSs1diVFOWeb0W3zSNyfJA1VuYVbnwFLBObzP6hUJrqZW9mGi7iY4LT2NyY ZAzuakq4l4fbISjm33hEhfEW5S84BcJSki4yIYT29xr3mNwoLvB8QO97kSVr/OcWdDN3 9t3hIM6RCcRT6HjHOtpX1EGhpmyjHzRjdLy5SydpAgPqc6K5OTAzLrF1c6b8bAv6lAOR +42FIYMhaCva7lVTHWQPLWy9yZDaqqQg2DrGR9rEndeKmB8SvqLpa8KFOUZ+AZ/htkUo XcSg== X-Gm-Message-State: AOJu0Yxzkz7Iw3w6uiy3L0mkcffydfGMAaBR/MClnfBKe6iaD09fcyey 6bkv9rrp6qQ58afr/xZJEfQjOlHVyNL3OhmvyvauP/hJCg6yXSJqTJVa4dWgLditqb/PFX8bGZQ khqiLmcjtBnQ0zHPNAJY= X-Received: by 2002:a2e:8702:0:b0:2c0:318a:6ee5 with SMTP id m2-20020a2e8702000000b002c0318a6ee5mr1912955lji.5.1695218020586; Wed, 20 Sep 2023 06:53:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEB8h8IH7gyCtppONgUfbR4L04lw39ibqk1OU35XSBEHxKejNeh0XZXhXDAYOdO1Ul108HAexKiL7sPTAZYibI= X-Received: by 2002:a2e:8702:0:b0:2c0:318a:6ee5 with SMTP id m2-20020a2e8702000000b002c0318a6ee5mr1912941lji.5.1695218020191; Wed, 20 Sep 2023 06:53:40 -0700 (PDT) MIME-Version: 1.0 References: <20230920130147.1567735-1-maxime.coquelin@redhat.com> In-Reply-To: <20230920130147.1567735-1-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 20 Sep 2023 15:53:28 +0200 Message-ID: Subject: Re: [PATCH] net/virtio: fix descriptors buffer addresses on 32 bits builds To: Maxime Coquelin Cc: dev@dpdk.org, rmelton@cisco.com, davejo@cisco.com, speechu@cisco.com, chenbo.xia@outlook.com, mbumgard@cisco.com, cbrezove@cisco.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 20, 2023 at 3:02=E2=80=AFPM Maxime Coquelin wrote: > > With Virtio-user, the Virtio descriptor buffer address is the > virtual address of the mbuf's buffer. On 32 bits builds, it is > expected to be 32 bits. > > With Virtio-PCI, the Virtio descriptor buffer address is the > physical address of the mbuf's buffer. On 32 bits builds running > on 64 bits kernel, it is expected to be up to 64 bits. > > This patch introduces a new mask field in virtqueue's struct to > filter our the upper 4 bytes of the address only when necessary. > An optimization is introduced for 64 bits builds to remove the > masking, as the address is always 64 bits wide. > > Fixes: ba55c94a7ebc ("net/virtio: revert forcing IOVA as VA mode for virt= io-user") > Cc: stable@dpdk.org > > Reported-by: Sampath Peechu > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --=20 David Marchand