From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FFFFA04BB; Tue, 6 Oct 2020 10:45:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD52B11A4; Tue, 6 Oct 2020 10:45:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id A7F4AB62 for ; Tue, 6 Oct 2020 10:45:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601973926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=19cHOWMzmdx+uuPS631C/sLIlIA3KcwikLaONm5+UcM=; b=LvojQtWfI+8WCF/k4vWBax0RjkoBEHTysaMOSmmMHVN7w8f/dXNMjaejTU1fqZ4L6M+LwM BS4CkL45J60ZFuUIcRQHN26gdcYVrBTZCGiohrDoL7B325ULngNQyAaofPkiblVOmUBkUe 7M2EOXh95oavbrb9cxEuF1VzwUA4Dw4= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-xj1cMAuOMHqa9dFg2KUvyQ-1; Tue, 06 Oct 2020 04:45:24 -0400 X-MC-Unique: xj1cMAuOMHqa9dFg2KUvyQ-1 Received: by mail-ua1-f69.google.com with SMTP id j39so2022726uad.23 for ; Tue, 06 Oct 2020 01:45:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=19cHOWMzmdx+uuPS631C/sLIlIA3KcwikLaONm5+UcM=; b=msueiWXXFdTV60hn5cYnzSCd5kmNWjtqzBxCfslYCPOZIRpiMt2+vJvBTM3i3ZBPs0 a3vdGsnRLSB473Gwb4VkR2P85GWrCEUF4vaYhxD8933/QFDh7MU55J3hhoEdJhNwt+/2 TloLc0rFlDujug5ceclBtaCHTVvo0pI4yrb8xZhvN9ZFYa5f80buRqPrMrH7Hm1Gibnh 15wIWcBEZHuf/XDCsHkYRDVzpH5WT/5EwL4vmdmB6SEaxa0qvctzr+PLqhRi8DWn6mzG Lw9/1dcNUqjMVCghOKAb4ttktdmCl2gbca3RvOVl3ycBamO8KwA/nXBPm3FEoTOrc4dB H9hg== X-Gm-Message-State: AOAM531W5Qat5LccDyDDp5GNJZfaKALvV1D4iYjiPxFMSNueqqq/SbZN LfYaGfntER0P5bcODAE+AczRgfnFCzVFE6KA0G2LJMjx2Hi/0CAWP6waS07/0z7nv6Z0VSopQCE dySkNm3kIxhHYq44AlbM= X-Received: by 2002:a1f:a290:: with SMTP id l138mr2034623vke.9.1601973924186; Tue, 06 Oct 2020 01:45:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPf/ZjELi8IjJjY49WnRVmQwcnRRd4ixHHxAN98V2CJUbiT9Q9BPrsiGbujMNI+l1BNiX5iuKQX/7Rnb/q39s= X-Received: by 2002:a1f:a290:: with SMTP id l138mr2034616vke.9.1601973923973; Tue, 06 Oct 2020 01:45:23 -0700 (PDT) MIME-Version: 1.0 References: <1601928154-26051-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1601928154-26051-1-git-send-email-timothy.mcdaniel@intel.com> From: David Marchand Date: Tue, 6 Oct 2020 10:45:13 +0200 Message-ID: To: Timothy McDaniel Cc: Jerin Jacob , Sunil Kumar Kori , dev , Erik Gabriel Carrillo , Gage Eads , Van Haaren Harry Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/1] eal: increase TRACE CTF SIZE to recommended size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 5, 2020 at 10:16 PM Timothy McDaniel wrote: > > Increase TRACE_CTF_FIELD_SIZE to 448, the recommended size. Repeating the same sentence in the title and the commitlog does not give much info. Plus, what is this "recommendation"? > Fixes "CTF field is too long" error when running with trace enabled. Ok, you hit this limit, but it would help to get some context here. Looking at this patch in the future, we won't know why it was necessary. > > Signed-off-by: Timothy McDaniel > --- > lib/librte_eal/common/eal_trace.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_trace.h b/lib/librte_eal/common/eal_trace.h > index 92c5951..438c2b7 100644 > --- a/lib/librte_eal/common/eal_trace.h > +++ b/lib/librte_eal/common/eal_trace.h > @@ -24,7 +24,7 @@ > > #define TRACE_PREFIX_LEN 12 > #define TRACE_DIR_STR_LEN (sizeof("YYYY-mm-dd-AM-HH-MM-SS") + TRACE_PREFIX_LEN) > -#define TRACE_CTF_FIELD_SIZE 384 > +#define TRACE_CTF_FIELD_SIZE 448 > #define TRACE_POINT_NAME_SIZE 64 > #define TRACE_CTF_MAGIC 0xC1FC1FC1 > #define TRACE_MAX_ARGS 32 > -- > 2.6.4 > -- David Marchand