From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3199428CD; Tue, 4 Apr 2023 15:18:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2966040EF0; Tue, 4 Apr 2023 15:18:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9518040A7E for ; Tue, 4 Apr 2023 15:18:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680614332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wF/S3eErDsdLBBjVCMttPxbVP4Fg04vkDAIi/V49YS4=; b=NicXCgkN9MhQ8KhU4saJqSAp1zsGbGANYP20V02pfDTDbGc8/MTY1VYPnful9w3h6f0eYr j0LFJQzJz78vu0XjS36HYNQzevDwZN2Xko2udFE9ille66zE8ZmxrwNkfOOYyJ2FdHe2UK E8K59uThdkfsmShu3M2I8TH6xg22Oa8= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-savsGf8gMUyMzSis3sfJAQ-1; Tue, 04 Apr 2023 09:18:51 -0400 X-MC-Unique: savsGf8gMUyMzSis3sfJAQ-1 Received: by mail-pj1-f72.google.com with SMTP id b8-20020a17090a488800b0023d1bf65c7eso8661031pjh.3 for ; Tue, 04 Apr 2023 06:18:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680614328; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wF/S3eErDsdLBBjVCMttPxbVP4Fg04vkDAIi/V49YS4=; b=J+tqJKLRSS3L544EZQLeSsBYDgJc3mLsJePLDem9SS0a3GNZH5o20prvqIa94nSc+K gjDQWl0uavLrWZKh1D2LKG3xAHeBo8OR7u7LaNohAEqChwY4LZAf38z2BnlNrJTluHmQ yoNvKkKewYGXBdSGe0GVTKMBvdHitOjnM2ECmGvyjgx5M7m2m62xrv+OaCkytfo27fxO FS8MqvUaeatctYJEawFmo5AH4gQrT9/oVp5cksD2RdztrELiwgtSm6CzUewaYQrWwafk +bwxr9wEaGmcHl0RL4NZ5W85lCbjatcrIgEtCtsv3NAtYGjRdJzhEoUVIzX8iyZ7vwF8 K90g== X-Gm-Message-State: AAQBX9d6ATUXBHc58z8cMaAGWj/JEgqesKJZJK8E511VYDFKbGo9ynuI 6rOAorjCtTlOfxeUiXVQBEKT7Iodl8DlObZvyAX7gih2RBf9yygRyilrTlkLYc3bo2BUaNGFZeQ 6gfRtqP1Kr1+TiIoLoSg= X-Received: by 2002:a05:6a00:2313:b0:624:5886:4b4b with SMTP id h19-20020a056a00231300b0062458864b4bmr1231565pfh.5.1680614328137; Tue, 04 Apr 2023 06:18:48 -0700 (PDT) X-Google-Smtp-Source: AKy350b/Z5t1K7tSKC/f5Z+t78Wz8y1SG3JakAw5NrVA0R+yigEmuLjlplYE2czXQOzR79W1UsD/duZvYzxP7nuuN1Q= X-Received: by 2002:a05:6a00:2313:b0:624:5886:4b4b with SMTP id h19-20020a056a00231300b0062458864b4bmr1231552pfh.5.1680614327780; Tue, 04 Apr 2023 06:18:47 -0700 (PDT) MIME-Version: 1.0 References: <20230404123647.404-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 4 Apr 2023 15:18:36 +0200 Message-ID: Subject: Re: [PATCH] devtools: suppress checkpatch warning on some kernel macro To: Ferruh Yigit Cc: dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 4, 2023 at 3:01=E2=80=AFPM Ferruh Yigit = wrote: > > On 4/4/2023 1:36 PM, David Marchand wrote: > > Kernel checkpatch.pl is confused about RTE_BUILD_BUG_ON() and warns as = if > > our code was calling the kernel macro BUG_ON(). > > > > This does not make sense in the DPDK userspace code and the Linux kerne= l > > module hosted in our repository (kernel/linux/kni) won't make it upstre= am. > > > > Disable this warning. > > > > Signed-off-by: David Marchand > > Sounds reasonable, > Acked-by: Ferruh Yigit > > > Is there any occurrence in the public CI, as reference? I caught it when preparing submission of: https://patchwork.dpdk.org/project/dpdk/patch/20230404124840.1898-2-david.m= archand@redhat.com/ dpdk.org checkpath did not catch it, so it is probably lagging a bit. For reference, in my environment, this looks like: ### [PATCH] malloc: rework heap destroy WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #23: FILE: lib/eal/common/malloc_heap.c:1389: + RTE_BUILD_BUG_ON(offsetof(struct malloc_heap, lock) !=3D 0); total: 0 errors, 1 warnings, 23 lines checked 0/1 valid patch --=20 David Marchand