From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ali Alnubani <alialnu@nvidia.com>, dev <dev@dpdk.org>,
michaelba@mellanox.com, dpdk stable <stable@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] net/mlx5: fix build with clang 14
Date: Wed, 15 Jun 2022 10:41:23 +0200 [thread overview]
Message-ID: <CAJFAV8w4z77Ct=BaOsyS9cpbU1hy_AexqEKy9f1O_jcDZ_+opw@mail.gmail.com> (raw)
In-Reply-To: <6144105.lOV4Wx5bFT@thomas>
On Wed, Jun 15, 2022 at 10:17 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 11/05/2022 18:41, Ali Alnubani:
> > Use fgets instead of fscanf to resolve the following warning
> > reported by clang 14.0.0 in Fedora 37 (Rawhide):
> >
> > drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error:
> > 'fscanf' may overflow; destination buffer in argument 3 has size 16,
> > but the corresponding specifier may require size 17
> > [-Werror,-Wfortify-source]
> > ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name);
>
> Some other patches are proposing to declare the variable
> of size IF_NAMESIZE+1 but I think it's wrong because
> IF_NAMESIZE includes a terminating null byte.
Ack, I rejected my patch accordingly.
--
David Marchand
next prev parent reply other threads:[~2022-06-15 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:58 [PATCH] " Ali Alnubani
2022-05-11 14:04 ` David Marchand
2022-05-11 16:41 ` [PATCH v2] " Ali Alnubani
2022-06-15 8:16 ` Thomas Monjalon
2022-06-15 8:41 ` David Marchand [this message]
2022-06-15 8:21 ` Slava Ovsiienko
2022-06-15 10:08 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8w4z77Ct=BaOsyS9cpbU1hy_AexqEKy9f1O_jcDZ_+opw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=alialnu@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=michaelba@mellanox.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).