* [PATCH] common/mlx5: fix dependency detection on Windows
@ 2025-06-13 8:10 David Marchand
2025-06-13 9:42 ` David Marchand
2025-06-18 9:42 ` David Marchand
0 siblings, 2 replies; 5+ messages in thread
From: David Marchand @ 2025-06-13 8:10 UTC (permalink / raw)
To: dev
Cc: probb, andremue, Dariusz Sosnowski, Viacheslav Ovsiienko,
Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad, Thomas Monjalon,
Tal Shnaiderman, Tyler Retzlaff
Don't *require* mlx5dev library when testing its presence.
Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard variables")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/common/mlx5/windows/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/mlx5/windows/meson.build b/drivers/common/mlx5/windows/meson.build
index f60daed840..c3bd3aac26 100644
--- a/drivers/common/mlx5/windows/meson.build
+++ b/drivers/common/mlx5/windows/meson.build
@@ -7,7 +7,7 @@ if not cc.has_header('mlx5devx.h')
subdir_done()
endif
-devxlib = cc.find_library('mlx5devx', required: true)
+devxlib = cc.find_library('mlx5devx', required: false)
if not devxlib.found()
build = false
reason = 'missing dependency, "mlx5devx"'
--
2.49.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] common/mlx5: fix dependency detection on Windows
2025-06-13 8:10 [PATCH] common/mlx5: fix dependency detection on Windows David Marchand
@ 2025-06-13 9:42 ` David Marchand
2025-06-13 21:48 ` Patrick Robb
2025-06-18 9:42 ` David Marchand
1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2025-06-13 9:42 UTC (permalink / raw)
To: dev
Cc: probb, andremue, Dariusz Sosnowski, Viacheslav Ovsiienko,
Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad, Thomas Monjalon,
Tal Shnaiderman, Tyler Retzlaff
On Fri, Jun 13, 2025 at 10:10 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> Don't *require* mlx5dev library when testing its presence.
For the record, this was seen in a UNH env that seems to have
partially installed mlx5 dependencies.
Has header "mlx5devx.h" : YES
drivers\common\mlx5\windows\meson.build:10:0: ERROR: C shared or
static library 'mlx5devx' not found
>
> Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard variables")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] common/mlx5: fix dependency detection on Windows
2025-06-13 9:42 ` David Marchand
@ 2025-06-13 21:48 ` Patrick Robb
2025-06-16 7:35 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Patrick Robb @ 2025-06-13 21:48 UTC (permalink / raw)
To: David Marchand
Cc: dev, andremue, Dariusz Sosnowski, Viacheslav Ovsiienko,
Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad, Thomas Monjalon,
Tal Shnaiderman, Tyler Retzlaff, Manit Mahajan
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
Good catch David on this system having a partial install of mlx5dev
header/library.
NVIDIA guys, do any of you have a link to the current install procedure or
package? If not I can probably find whatever is correct. Thanks.
Either way we'll update devx on the Windows system Monday - thanks for your
patience.
On Fri, Jun 13, 2025 at 5:42 AM David Marchand <david.marchand@redhat.com>
wrote:
> On Fri, Jun 13, 2025 at 10:10 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Don't *require* mlx5dev library when testing its presence.
>
> For the record, this was seen in a UNH env that seems to have
> partially installed mlx5 dependencies.
>
> Has header "mlx5devx.h" : YES
> drivers\common\mlx5\windows\meson.build:10:0: ERROR: C shared or
> static library 'mlx5devx' not found
>
> >
> > Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard
> variables")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
>
> --
> David Marchand
>
>
[-- Attachment #2: Type: text/html, Size: 1601 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] common/mlx5: fix dependency detection on Windows
2025-06-13 21:48 ` Patrick Robb
@ 2025-06-16 7:35 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2025-06-16 7:35 UTC (permalink / raw)
To: Patrick Robb
Cc: David Marchand, dev, andremue, Dariusz Sosnowski,
Viacheslav Ovsiienko, Bing Zhao, Ori Kam, Suanming Mou,
Matan Azrad, Tal Shnaiderman, Tyler Retzlaff, Manit Mahajan
This is the documentation to prepare mlx5 on Windows:
https://docs.nvidia.com/networking/display/winof2v290/devx+interface
13/06/2025 23:48, Patrick Robb:
> Good catch David on this system having a partial install of mlx5dev
> header/library.
>
> NVIDIA guys, do any of you have a link to the current install procedure or
> package? If not I can probably find whatever is correct. Thanks.
>
> Either way we'll update devx on the Windows system Monday - thanks for your
> patience.
>
> On Fri, Jun 13, 2025 at 5:42 AM David Marchand <david.marchand@redhat.com>
> wrote:
>
> > On Fri, Jun 13, 2025 at 10:10 AM David Marchand
> > <david.marchand@redhat.com> wrote:
> > >
> > > Don't *require* mlx5dev library when testing its presence.
> >
> > For the record, this was seen in a UNH env that seems to have
> > partially installed mlx5 dependencies.
> >
> > Has header "mlx5devx.h" : YES
> > drivers\common\mlx5\windows\meson.build:10:0: ERROR: C shared or
> > static library 'mlx5devx' not found
> >
> > >
> > > Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard
> > variables")
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] common/mlx5: fix dependency detection on Windows
2025-06-13 8:10 [PATCH] common/mlx5: fix dependency detection on Windows David Marchand
2025-06-13 9:42 ` David Marchand
@ 2025-06-18 9:42 ` David Marchand
1 sibling, 0 replies; 5+ messages in thread
From: David Marchand @ 2025-06-18 9:42 UTC (permalink / raw)
To: David Marchand
Cc: dev, probb, andremue, Dariusz Sosnowski, Viacheslav Ovsiienko,
Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad, Thomas Monjalon,
Tal Shnaiderman, Tyler Retzlaff
On Fri, Jun 13, 2025 at 10:10 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> Don't *require* mlx5dev library when testing its presence.
>
> Fixes: 85c51a4ffab8 ("common/mlx5: get Windows dependency from standard variables")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied with updated commitlog.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-18 9:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-13 8:10 [PATCH] common/mlx5: fix dependency detection on Windows David Marchand
2025-06-13 9:42 ` David Marchand
2025-06-13 21:48 ` Patrick Robb
2025-06-16 7:35 ` Thomas Monjalon
2025-06-18 9:42 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).