From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 780C9A0527;
Mon, 9 Nov 2020 11:02:10 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 8E10C592C;
Mon, 9 Nov 2020 11:02:08 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [216.205.24.124])
by dpdk.org (Postfix) with ESMTP id 7D6005916
for <dev@dpdk.org>; Mon, 9 Nov 2020 11:02:06 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1604916124;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=EOdBm6Yeo/ziEwZ0EN4oePP0LlyG87TMt0zz3nB8DUw=;
b=f7XOtjxMpkihc2jRJXdNwiBosQ/3lmcpVRmmS0oTlfr50dSCvY0P6QVUWyaoTZeyJsSib5
dy+15r3kYZHtsqQZfPXMRtBBJqcKTTLGfQ8VqnkC6/0TN56/ydCN7MkBkaywbO/fw9nYK9
78XChNXXQq3tiEoZZrMU4cQzIQQ1Y6A=
Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com
[209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-471-NB8yjfS-PzSfHnItzsw24Q-1; Mon, 09 Nov 2020 05:02:01 -0500
X-MC-Unique: NB8yjfS-PzSfHnItzsw24Q-1
Received: by mail-vk1-f200.google.com with SMTP id v17so1064439vke.10
for <dev@dpdk.org>; Mon, 09 Nov 2020 02:02:01 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=EOdBm6Yeo/ziEwZ0EN4oePP0LlyG87TMt0zz3nB8DUw=;
b=dY+JLerp7I0sBdOoOJqFlOQN4X9ae9S7/gSu4UxFJuvmwvOKYDwkGXhgnj/2Tpdxtg
KiuXL5PtzowzAnem7wzGHFXYEl5xqXM5aIxmSsJZtukl3zsBXN5Nz7qfv0m1rpH/luAJ
CyIzd3Ku1FwRyOJKGl/2gidSo7+sVeNhLjmZFCbLQj0j74jNKEMlTuH2zYjR274se6mC
mPqGzfNrrvvTCnv++RNPC6bUCmnGIrUbszz9mT1Y8AI70esdUirms10lHZW8yzOa5/uf
uDeDzqJuIkjsXvvThp9Xba9FFgy54TTK9CaceMhXAl1IgIKt0hNbPl1twqwwasGXSY+2
INag==
X-Gm-Message-State: AOAM530EtlXhDMJYXTyxZz/697u3Qff5JY5x4lODedOuKSPGf+EO6Y2z
qPmZnPk0EnwgAVoArvW8At/K42vS1nxyCIqj3gjW0O9zLfRjdG2K2tRWQ6g4o6KVRGe8PCh2MEv
hbuRnBk4TsEr0/3aib+Q=
X-Received: by 2002:a1f:38d2:: with SMTP id f201mr6236222vka.17.1604916121428;
Mon, 09 Nov 2020 02:02:01 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzL+7CX3V67t1KxQmX9EzVVinjOfdKDbBBWquNIq8FpeN9rotKutJC12r+5GQ+3QSD7n19YXgdw+TFvQ9yk5R4=
X-Received: by 2002:a1f:38d2:: with SMTP id f201mr6236217vka.17.1604916121198;
Mon, 09 Nov 2020 02:02:01 -0800 (PST)
MIME-Version: 1.0
References: <20201027173836.891184-1-bruce.richardson@intel.com>
In-Reply-To: <20201027173836.891184-1-bruce.richardson@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 9 Nov 2020 11:01:50 +0100
Message-ID: <CAJFAV8w66thRqsJsnyY0WRbFNDXkSYRGd6yuZ1XFVUFQmWpaiQ@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set
of examples
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, Oct 27, 2020 at 6:39 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> To test the installation process of DPDK using "ninja install"
> test-meson-builds.sh builds a subset of the examples using "make". To allow
> more flexibility for people testing, allow the set of examples chosen for
> this make test to be overridden using variable "DPDK_BUILD_TEST_EXAMPLES"
> in the environment.
>
> Since a number of example apps link against drivers directly even for
> shared builds, we need to ensure that LD_LIBRARY_PATH points to the main
> DPDK lib folder so any dependencies of those drivers can be found e.g. that
> the PCI/vdev bus driver .so is found. [All drivers are symlinked from
> drivers dir back to lib dir on install, so only one dir rather than two is
> needed in the path.]
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> devtools/test-meson-builds.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index a87de635a2..b9cde5b366 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -238,11 +238,15 @@ fi
> load_env cc
> pc_file=$(find $DESTDIR -name libdpdk.pc)
> export PKG_CONFIG_PATH=$(dirname $pc_file):$PKG_CONFIG_PATH
> +libdir=$(dirname $(find $DESTDIR -name librte_eal.so))
> +export LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH
> +
> +examples_to_test=${DPDK_BUILD_TEST_EXAMPLES:-"cmdline helloworld l2fwd l3fwd skeleton timer"}
>
> # if pkg-config defines the necessary flags, test building some examples
> if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then
> export PKGCONF="pkg-config --define-prefix"
> - for example in cmdline helloworld l2fwd l3fwd skeleton timer; do
> + for example in $examples_to_test; do
> echo "## Building $example"
> $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example clean shared static
> done
> --
> 2.25.1
>
I had something similar in store for a while, happy to get a better fix.
Acked-by: David Marchand <david.marchand@redhat.com>
Caught more issues when compiling examples externally, I will send
fixes on kni, l2fwd-crypto, vhost and vhost_blk.
--
David Marchand