DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	 "timothy.mcdaniel@intel.com" <timothy.mcdaniel@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [pull-request] next-eventdev 20.11 RC2
Date: Mon, 2 Nov 2020 16:50:38 +0100	[thread overview]
Message-ID: <CAJFAV8w6HT5VV1AtkBxXy_ORd1Yf6Ze139jDyLq6fKA0dgoNUw@mail.gmail.com> (raw)
In-Reply-To: <BYAPR18MB2424DAF1B44291DDA8C7965AC8100@BYAPR18MB2424.namprd18.prod.outlook.com>

On Mon, Nov 2, 2020 at 3:31 PM Jerin Jacob Kollanukkaran
<jerinj@marvell.com> wrote:
>
> The following changes since commit 79d69c6dcf0debea38ac258d230e2f8c93e5ad12:
>
>   mbuf: remove seqn field (2020-10-31 22:14:44 +0100)
>
> are available in the Git repository at:
>
>   http://dpdk.org/git/next/dpdk-next-eventdev
>
> for you to fetch changes up to e06cd1ddfeac30b4926a52a69336b4f25a9cd209:
>
>   eventdev: check input parameter for dump op (2020-11-02 19:16:51 +0530)
>
> ----------------------------------------------------------------
> David Marchand (1):
>       eventdev: check input parameter for dump op

About this patch, could we squash some change in the dlb/dlb2 drivers?
I guess Thomas could do it while pulling if nobody objects?


diff --git a/drivers/event/dlb/dlb_xstats.c b/drivers/event/dlb/dlb_xstats.c
index 89186d506e..5f4c590307 100644
--- a/drivers/event/dlb/dlb_xstats.c
+++ b/drivers/event/dlb/dlb_xstats.c
@@ -921,11 +921,6 @@ dlb_eventdev_dump(struct rte_eventdev *dev, FILE *f)
        struct dlb_hw_dev *handle;
        int i;

-       if (f == NULL) {
-               DLB_LOG_ERR("Invalid file pointer\n");
-               return;
-       }
-
        dlb = dlb_pmd_priv(dev);

        if (dlb == NULL) {
diff --git a/drivers/event/dlb2/dlb2_xstats.c b/drivers/event/dlb2/dlb2_xstats.c
index a274779fee..8c3c3cda94 100644
--- a/drivers/event/dlb2/dlb2_xstats.c
+++ b/drivers/event/dlb2/dlb2_xstats.c
@@ -972,11 +972,6 @@ dlb2_eventdev_dump(struct rte_eventdev *dev, FILE *f)
        struct dlb2_hw_dev *handle;
        int i;

-       if (f == NULL) {
-               DLB2_LOG_ERR("Invalid file pointer\n");
-               return;
-       }
-
        dlb2 = dlb2_pmd_priv(dev);

        if (dlb2 == NULL) {



-- 
David Marchand


  reply	other threads:[~2020-11-02 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 14:30 Jerin Jacob Kollanukkaran
2020-11-02 15:50 ` David Marchand [this message]
2020-11-02 15:57   ` McDaniel, Timothy
2020-11-03 10:04     ` Thomas Monjalon
2020-11-03 10:40 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8w6HT5VV1AtkBxXy_ORd1Yf6Ze139jDyLq6fKA0dgoNUw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).