From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 48152A0471 for ; Mon, 17 Jun 2019 15:44:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 306F91BD24; Mon, 17 Jun 2019 15:44:55 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 93FDD1BC01 for ; Mon, 17 Jun 2019 15:44:53 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id a186so6125579vsd.7 for ; Mon, 17 Jun 2019 06:44:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HcAynOprW3OoVH5Fplox/nfijZX3fKfuI6VonXouOg8=; b=IOpf5xdk2IeGaMbmC1otY4vpo3Q88T0ZUXpErowDf7CjpORIs17TQpzgdkT3jK0rpI 6hvpdh8RnhjvVrlu4GBb6r/3JLT7bFt1E26Nd8c31Z/EQQZBdIsKoLMJ45E7C5v7Y8I3 7/WwGtwD44cYGpCnDyUFyqDbfj36VRfKK7fIpLVIC1QxqID8ajbuHppTdWLtTxNWw9gZ /DVYW9OqekbXfgrcZa3mkX0yJA2W0EZhtVYXAPSTPpj3Vzv4kHHDFThUkhF8I2J0Rvbg Lx0QA0wRzTSNZK3asbMUaTckUOdGSm98e9DrQ42iAtqxmYp2NA4jgt08bLg1SFe3A22Y 5zaw== X-Gm-Message-State: APjAAAVGGVsvFFmMGeEDjh0y86Arz9Muk8psRccdWEHUVA9ygo4qJTf1 5XJkd/KWxZYMQlYHaJXVCyQTNPeUymSeYZY6DqTYUg== X-Google-Smtp-Source: APXvYqwBFmjsdRLuON++ZiFzWojqmuYQ7PBs9D2Q9yqKKAv6a/HcVS5qF/BwNVBwVvZv8GEEYMA3T4YYfdrgFA7164c= X-Received: by 2002:a67:da99:: with SMTP id w25mr2344128vsj.141.1560779093030; Mon, 17 Jun 2019 06:44:53 -0700 (PDT) MIME-Version: 1.0 References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1560580950-16754-1-git-send-email-david.marchand@redhat.com> <20190617100027.GA527@bricha3-MOBL.ger.corp.intel.com> <20190617111713.GD527@bricha3-MOBL.ger.corp.intel.com> <20190617115654.GE527@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190617115654.GE527@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Mon, 17 Jun 2019 15:44:41 +0200 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon , Aaron Conole , Michael Santana Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 17, 2019 at 1:57 PM Bruce Richardson wrote: > On Mon, Jun 17, 2019 at 01:41:21PM +0200, David Marchand wrote: > > On Mon, Jun 17, 2019 at 1:18 PM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > On Mon, Jun 17, 2019 at 12:46:03PM +0200, David Marchand wrote: > > > On Mon, Jun 17, 2019 at 12:02 PM Bruce Richardson > > > <[1][2]bruce.richardson@intel.com> wrote: > > > > > > On Sat, Jun 15, 2019 at 08:42:15AM +0200, David Marchand > > wrote: > > > > This is a joint effort to make the unit tests ready for CI. > > > > The first patches are fixes that I had accumulated. > > > > Then the second part of the series focuses on skipping > > tests when > > > some > > > > requirements are not fulfilled so that we can start them in > > a > > > restrained > > > > environment like Travis virtual machines that gives us two > > cores > > > and does > > > > not have specific hw devices. > > > > > > > > We are still not ready for enabling those tests in Travis. > > > > At least, the following issues remain: > > > > - some fixes on librte_acl have not been merged yet [1], > > > > - the tests on --file-prefix are still ko, and have been > > isolated > > > in a > > > > test that we could disable while waiting for the fixes, > > > > - rwlock_autotest and hash_readwrite_lf_autotest are taking > > a > > > little more > > > > than 10s, > > > > - librte_table unit test crashes on ipv6 [2], > > > > - the "perf" tests are taking way too long for my taste, > > > > - the shared build unit tests all fail when depending on > > mempool > > > since > > > > the mempool drivers are not loaded, > > > > > > > For the autotest app shared builds, it is probably worthwhile > > > linking in > > > all drivers explicitly to avoid issues like this. > > > > > > Yes, I'll look into this. > > > While at it, do you know why the i40e and ixgbe drivers are > > linked to > > > app/test in meson? > > > -- > > There are unit tests for the device-specific functions in those > > drivers, so > > they need to be given at link time. > > > > For testpmd, I can understand. > > But I can't see code for driver specific apis in app/test. > > It looks like a copy/paste error when adding meson support. > > -- > Ok, could be. Simple question is does it still build ok if you remove them? > It would have been strange if it did not build, since on Makefile side we do nothing. Yes, it builds fine with meson without this. I managed to get the same test results than with static builds by linking the skeleton eventdev driver and the mempool sw drivers. Should be enough. -- David Marchand