From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8672EA034F; Mon, 22 Mar 2021 11:33:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2786E40042; Mon, 22 Mar 2021 11:33:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 878F040040 for <dev@dpdk.org>; Mon, 22 Mar 2021 11:33:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616409231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DBF7YyItiQanxNZ2l49T+A++u88nqhebi9O4p6xB66U=; b=Y7mnxWYMZz7TwpQkt62pqvCgaT3vhIBVtBl3ycB7cWkmIK+jLEvppN9SiuQwneagp69YUj QvlZdtNEogz/vYL9v9Zpvt/IYWqczG+TifonjBq4A6K2hsNRX+6G+pt4CUDFlJOP4vaaPT Tw0woD0odbsBt4YpqCzrF/WmzC36Gpk= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-UDXfOkgfMMKEBWFgeuKkZQ-1; Mon, 22 Mar 2021 06:33:45 -0400 X-MC-Unique: UDXfOkgfMMKEBWFgeuKkZQ-1 Received: by mail-vk1-f199.google.com with SMTP id n196so15602856vkn.23 for <dev@dpdk.org>; Mon, 22 Mar 2021 03:33:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DBF7YyItiQanxNZ2l49T+A++u88nqhebi9O4p6xB66U=; b=a/4Lfbq9GlFjZBs3P4XgZ0PHcNEr30zfhR1MQFYpvDNjkzTrGpmsOhlxvuGtPcVD2Y NZi40WDxLhbUCUORjnoyGm7RvOe/DzWN4pIjZxr2ETa4sljqhKtEx6eo8p9vedHwhnUr ZA6xWyHDyf94oq+L0gwes1/KWsS6VKCI/CBdMntv4nEP0IkZYwwjmQsMPE2IO9hWeuEk GFPB3FZI1oFhyBwbwc2zy+F3Y4YQcy5KHbDZJAnzObs0Qg15Fjd+qAPo83p7tbAoj449 AI0bbexkh/gg+SPiWMr5mbF+t/QBZitQdxiz6NcdPVyJrLagO3TLiq9TtKTVN829zIrS xUMA== X-Gm-Message-State: AOAM530lW/I7aTgIPlNR7VDd9q6SZbsCWcKbBAsaGWbrWUjfiAwCfZ0G CmLOAuNaN2LKHcZwRqtSUa1YKC9cqyzZtJGRFyXiVCDWZRDZOZgtGPGJgoG1G32mhDUzuzFRF3j 9RdbINJksJU7eviVgxY8= X-Received: by 2002:a05:6102:ed4:: with SMTP id m20mr7819831vst.27.1616409225484; Mon, 22 Mar 2021 03:33:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwF8UZOtKkYR9d20+jOtdtIKUlGVay0bZ8S3sCyQat8acKIHNV2gcdWuwBTcAk3anP1jwPd2af3D0fxY6q+DXQ= X-Received: by 2002:a05:6102:ed4:: with SMTP id m20mr7819820vst.27.1616409225217; Mon, 22 Mar 2021 03:33:45 -0700 (PDT) MIME-Version: 1.0 References: <20210310140107.2730088-1-thomas@monjalon.net> <20210310140107.2730088-4-thomas@monjalon.net> In-Reply-To: <20210310140107.2730088-4-thomas@monjalon.net> From: David Marchand <david.marchand@redhat.com> Date: Mon, 22 Mar 2021 11:33:34 +0100 Message-ID: <CAJFAV8w7fGx=HrpYJXMtUXiUje8QNGSFWEOQKK6pQcMwuOU3fA@mail.gmail.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: dev <dev@dpdk.org>, John Griffin <john.griffin@intel.com>, Fiona Trahe <fiona.trahe@intel.com>, Deepak Kumar Jain <deepak.k.jain@intel.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>, Vikas Gupta <vikas.gupta@broadcom.com>, Rosen Xu <rosen.xu@intel.com>, Tianfei zhang <tianfei.zhang@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Xiao Wang <xiao.w.wang@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/3] drivers: align log names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon <thomas@monjalon.net> wrote: > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 6a1b44bc77..bf7afe4610 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -25,7 +25,7 @@ > > #include "base/ifcvf.h" > > -RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.net.ifcvf_vdpa, NOTICE); > +RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); The driver is in drivers/vdpa/ifc, I would expect pmd.vdpa.ifc We have some little variations for the af_packet and bonding drivers, worth aligning from my pov. drivers/net/af_packet/rte_eth_af_packet.c:RTE_LOG_REGISTER(af_packet_logtype, pmd.net.packet, NOTICE); drivers/net/bonding/rte_eth_bond_pmd.c:RTE_LOG_REGISTER(bond_logtype, pmd.net.bond, NOTICE); And ipn3ke is odd too: drivers/net/ipn3ke/ipn3ke_ethdev.c:RTE_LOG_REGISTER(ipn3ke_afu_logtype, pmd.afu.ipn3ke, NOTICE); -- David Marchand