From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, roretzla@linux.microsoft.com,
"Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: Re: [PATCH v2] eal/x86: fix build on systems with WAITPKG support
Date: Mon, 28 Aug 2023 16:39:02 +0200 [thread overview]
Message-ID: <CAJFAV8w8EEbLfEwTZ4bDPFdj0gGyX9OrOEAWr-SuRYyypuR5ow@mail.gmail.com> (raw)
In-Reply-To: <20230828103933.1047285-1-bruce.richardson@intel.com>
On Mon, Aug 28, 2023 at 12:40 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> When doing a build for a system with WAITPKG support and a modern
> compiler, we get build errors for the "_umonitor" intrinsic, due to the
> casting away of the "volatile" on the parameter.
>
> ../lib/eal/x86/rte_power_intrinsics.c: In function 'rte_power_monitor':
> ../lib/eal/x86/rte_power_intrinsics.c:113:22: error: passing argument 1
> of '_umonitor' discards 'volatile' qualifier from pointer target type
> [-Werror=discarded-qualifiers]
> 113 | _umonitor(pmc->addr);
> | ~~~^~~~~~
>
> We can avoid this issue by casting through "uintptr_t" and thereby
> remove the volatile without warning. We also ensure comments are
> correct for each leg of the ifdef..else..endif block.
>
> Fixes: 60943c04f3bc ("eal/x86: use intrinsics for power management")
> Cc: roretzla@linux.microsoft.com
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> Tested-by: David Marchand <david.marchand@redhat.com>
Applied to fix build on the main branch, thanks.
We can look at the casting helper as a followup.
--
David Marchand
prev parent reply other threads:[~2023-08-28 14:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 15:28 [PATCH] " Bruce Richardson
2023-08-25 16:07 ` Morten Brørup
2023-08-28 7:08 ` David Marchand
2023-08-28 8:05 ` David Marchand
2023-08-28 9:29 ` David Marchand
2023-08-28 10:29 ` Bruce Richardson
2023-08-28 10:42 ` Stephen Hemminger
2023-08-28 11:03 ` Bruce Richardson
2023-08-28 14:31 ` Ferruh Yigit
2023-08-28 15:56 ` Tyler Retzlaff
2023-08-28 10:39 ` [PATCH v2] " Bruce Richardson
2023-08-28 14:39 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8w8EEbLfEwTZ4bDPFdj0gGyX9OrOEAWr-SuRYyypuR5ow@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).