From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FB0343D47; Mon, 25 Mar 2024 13:08:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7286A40271; Mon, 25 Mar 2024 13:08:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2C58E4021D for ; Mon, 25 Mar 2024 13:08:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711368499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oW3HPkt1iQQXtio8xgDMQ4aFTQEcH9AjF5eobTmf21g=; b=aRY6npoO2xo1f9mclxTT0Jt71iRS8EVqjC02vfe0kPGIYkOOYddY8tiet8Vee0CkPw67WX 8K8ZroMvb1HkjWCG9fE9yb6Y7r9anU+H7A7dfH2zlxdLK0Fx0guzU+wbhjoY40FE5uv/aU Nso1veFDbjZQmy6SeavoQ3idBT0mHRU= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-mKYhLNBMP7qcsl1LKttLFA-1; Mon, 25 Mar 2024 08:08:18 -0400 X-MC-Unique: mKYhLNBMP7qcsl1LKttLFA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d48b182917so44189681fa.1 for ; Mon, 25 Mar 2024 05:08:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711368496; x=1711973296; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oW3HPkt1iQQXtio8xgDMQ4aFTQEcH9AjF5eobTmf21g=; b=Ooau8E9y2PMBzeek54pt0NC0OqSaYd5clw2lhiTpH6M9PWl68oBQ9ReLMIniSX6ldS garDufD/fGJbL1DIx+3NGmjtvDFh6+2YGzWr3bL7JdZpSRGqp1EiDXTgfC3Sne/wNKMH xURPYWOmrXeq5aBdTMGJ9b8fF3rzX8f3zzbNSM52Ad5QaBPp2SeIf3oKJIUyUPoDBG4y TIVvFV1TDhwhUVkJ6/Jlz42EfCkM9QnKExF4KffhqA6dYMNKupq5fkvjwOHspVH2b64B O8RpRaBFPuUmI/1ohS7VAywiBV2JQEPSrvLhxZInIhlad3yYvQ6J9GyFFDChcBeKXHJz Xn0A== X-Forwarded-Encrypted: i=1; AJvYcCVSVI7eZ/7LB45cCVdfzAB89NvDIYfD34VAb8ceJiAxWtZTnodO6TCZmEu3CARvSqkvryeVZTiGk2cNSZg= X-Gm-Message-State: AOJu0Yx1kyLPaI8iH2QobaRl2CMTzDtsR/gnH6b/1f1ssMa2PM6vTEwb oD394WgsgGP2h73IUOJ0l7t5wQlNsS51i+6O77zsu9dkOCkXPmz61rN6kei/cHDSBybwlJUirRf Ta74Xe2CWvuFisrC/JuYIkA5uTWM5CF0F+vioGDyU+ecfOonM1DNgb+j9ZG+vmXmsaD01soT4/d Y8pEaGMGTVu0oqV6M= X-Received: by 2002:a2e:a54b:0:b0:2d6:d529:a464 with SMTP id e11-20020a2ea54b000000b002d6d529a464mr2201251ljn.52.1711368496685; Mon, 25 Mar 2024 05:08:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSpB5GA2KAVn+A66JAv2a0hQMHUIyOcEUDiiD1WMylW/vBPqcwKpj5BMD5XHlcmmuVUL8S823kzlfLZOmdXxY= X-Received: by 2002:a2e:a54b:0:b0:2d6:d529:a464 with SMTP id e11-20020a2ea54b000000b002d6d529a464mr2201230ljn.52.1711368496374; Mon, 25 Mar 2024 05:08:16 -0700 (PDT) MIME-Version: 1.0 References: <20240325100500.694748-2-rjarry@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 25 Mar 2024 13:08:04 +0100 Message-ID: Subject: Re: [PATCH v3] graph: expose node context as pointers To: Jerin Jacob Cc: Robin Jarry , dev@dpdk.org, Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan , Tyler Retzlaff X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 25, 2024 at 12:35=E2=80=AFPM Jerin Jacob wrote: > > On Mon, Mar 25, 2024 at 4:45=E2=80=AFPM Robin Jarry w= rote: > > > > Jerin Jacob, Mar 25, 2024 at 12:08: > > > > It will not be taken into account for MSVC. Is that OK? > > > > > > Why?. rte_mbuf has a similar scheme. > > > RTE_MARKER cacheline1 __rte_cache_min_aligned; > > > > RTE_MARKER* types seem not defined for the MSVC toolchain. There is some work in progress to stop using those markers. https://patchwork.dpdk.org/project/dpdk/list/?series=3D31579&state=3D* > > > > https://github.com/DPDK/dpdk/blob/v24.03-rc4/lib/eal/include/rte_common= .h#L589-L602 > > Hmm. Not sure, how mbuf is building for MSCV tool chain then. Atm, MSVC builds a really small list of libraries. http://git.dpdk.org/dpdk/tree/lib/meson.build#n71?id=3Dv24.03-rc4 if is_ms_compiler libraries =3D [ 'log', 'kvargs', 'telemetry', 'eal', 'ring', ] endif > > Another option could be to have a helper inline function/macro to take > care of casting to make app code clean of casting. That could be an option. --=20 David Marchand