DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	Sameh Gobriel <sameh.gobriel@intel.com>,
	 Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Yipeng Wang <yipeng1.wang@intel.com>,
	 mb@smartsharesystems.com, fengchengwen@huawei.com
Subject: Re: [PATCH v5 0/6] more replacement of zero length array
Date: Tue, 11 Jun 2024 17:15:25 +0200	[thread overview]
Message-ID: <CAJFAV8w=_aLanaicxmCAmrzXX9Ar-y8cKaaC1Jtuz3ztKAbZag@mail.gmail.com> (raw)
In-Reply-To: <1709756036-24068-1-git-send-email-roretzla@linux.microsoft.com>

On Wed, Mar 6, 2024 at 9:14 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Replace some missed zero length arrays not captured in the
> original series.
> https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=*
>
> Zero length arrays are a GNU extension that has been
> superseded by flex arrays.
>
> https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
>
> v5:
>   * no changes, rebase for upstream merge / conflicts.
>
> v4:
>   * add another temporary suppression of libabigail bug
>     for rte_rcu_qsbr. As with pipeline i cannot see that
>     rte_rcu_qsbr is nested in any other struct.
>
> v3:
>   * add temporary suppression of libabigail bug
>     https://sourceware.org/bugzilla/show_bug.cgi?id=31377
>   * add 2 more patches covering lpm and table
>     (series ack has not been extended)
>   * add another zero length array missed in rcu and pipeline
>
> v2:
>   * added additional patches for fib & pipeline libs.
>     series-acks have been placed only against original
>     hash and rcu patches.
>
> Tyler Retzlaff (6):
>   hash: replace zero length array with flex array
>   rcu: replace zero length array with flex array
>   fib: replace zero length array with flex array
>   pipeline: replace zero length array with flex array
>   lpm: replace zero length array with flex array
>   table: replace zero length array with flex array
>
>  devtools/libabigail.abignore      | 5 +++++
>  lib/fib/dir24_8.h                 | 2 +-
>  lib/fib/trie.h                    | 2 +-
>  lib/hash/rte_thash.c              | 4 ++--
>  lib/lpm/rte_lpm6.c                | 2 +-
>  lib/pipeline/rte_pipeline.h       | 2 +-
>  lib/pipeline/rte_port_in_action.c | 2 +-
>  lib/rcu/rcu_qsbr_pvt.h            | 2 +-
>  lib/rcu/rte_rcu_qsbr.h            | 2 +-
>  lib/table/rte_table_acl.c         | 2 +-
>  lib/table/rte_table_array.c       | 2 +-
>  lib/table/rte_table_hash_cuckoo.c | 2 +-
>  lib/table/rte_table_hash_ext.c    | 2 +-
>  lib/table/rte_table_hash_key16.c  | 2 +-
>  lib/table/rte_table_hash_key32.c  | 2 +-
>  lib/table/rte_table_hash_key8.c   | 2 +-
>  lib/table/rte_table_hash_lru.c    | 2 +-
>  lib/table/rte_table_lpm.c         | 2 +-
>  lib/table/rte_table_lpm_ipv6.c    | 2 +-
>  19 files changed, 24 insertions(+), 19 deletions(-)

libabigail 2.5 got released.
I had a try with it in GHA, and the false positive errors around
lib/pipeline and lib/rcu are gone.
Yet there may still be people using older version, so let's take this
series as is with the temporary exceptions.

Series applied, thanks.


-- 
David Marchand


      parent reply	other threads:[~2024-06-11 15:15 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 22:17 [PATCH 0/2] " Tyler Retzlaff
2024-01-24 22:17 ` [PATCH 1/2] hash: replace zero length array with flex array Tyler Retzlaff
2024-01-24 22:57   ` Honnappa Nagarahalli
2024-01-25  7:16   ` Morten Brørup
2024-01-24 22:17 ` [PATCH 2/2] rcu: " Tyler Retzlaff
2024-01-24 22:57   ` Honnappa Nagarahalli
2024-01-25  7:14   ` Morten Brørup
2024-01-25 12:57 ` [PATCH 0/2] more replacement of zero length array fengchengwen
2024-02-12 22:36 ` [PATCH v2 0/4] " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 1/4] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 2/4] rcu: " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 3/4] fib: " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 4/4] pipeline: " Tyler Retzlaff
2024-02-12 22:57   ` [PATCH v2 0/4] more replacement of zero length array Stephen Hemminger
2024-02-13  8:31     ` Morten Brørup
2024-02-13 13:14   ` David Marchand
2024-02-13 19:20     ` Tyler Retzlaff
2024-02-14  7:36       ` David Marchand
2024-02-16 10:14         ` David Marchand
2024-02-16 20:46           ` Tyler Retzlaff
2024-02-18 12:31           ` Dodji Seketeli
2024-02-27 23:56 ` [PATCH v3 0/6] " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 2/6] rcu: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 3/6] fib: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 4/6] pipeline: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 5/6] lpm: " Tyler Retzlaff
2024-02-28  7:26     ` Morten Brørup
2024-02-27 23:56   ` [PATCH v3 6/6] table: " Tyler Retzlaff
2024-02-28  7:27     ` Morten Brørup
2024-02-29 22:58 ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 2/6] rcu: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 3/6] fib: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 4/6] pipeline: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 5/6] lpm: " Tyler Retzlaff
2024-03-01  8:12     ` Morten Brørup
2024-02-29 22:58   ` [PATCH v4 6/6] table: " Tyler Retzlaff
2024-03-01  8:13     ` Morten Brørup
2024-03-06 19:39   ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 " Tyler Retzlaff
2024-03-06 20:13   ` [PATCH v5 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-03-06 20:52     ` Medvedkin, Vladimir
2024-03-06 20:13   ` [PATCH v5 2/6] rcu: " Tyler Retzlaff
2024-03-06 20:13   ` [PATCH v5 3/6] fib: " Tyler Retzlaff
2024-03-06 20:53     ` Medvedkin, Vladimir
2024-03-06 20:13   ` [PATCH v5 4/6] pipeline: " Tyler Retzlaff
2024-03-06 20:13   ` [PATCH v5 5/6] lpm: " Tyler Retzlaff
2024-03-06 20:53     ` Medvedkin, Vladimir
2024-03-06 20:13   ` [PATCH v5 6/6] table: " Tyler Retzlaff
2024-06-11 15:15   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8w=_aLanaicxmCAmrzXX9Ar-y8cKaaC1Jtuz3ztKAbZag@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=mb@smartsharesystems.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=sameh.gobriel@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).