From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDA96424C3; Tue, 11 Jun 2024 17:15:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D27D40A73; Tue, 11 Jun 2024 17:15:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8A8FF40A67 for <dev@dpdk.org>; Tue, 11 Jun 2024 17:15:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718118942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vhwcWZ+h22g9CdIxLCqh/QJDSrxorrZ9KMdL6Fw3e64=; b=ZxOIpj981SUjLcGYeRbca6LdlELtPpwaq2lxo/BKtQu/wuDbIfERz05f8pF6ve+72H4Hvz cELRmVMoHb3FwxhnMfZW3SY/5jb0oY29TYhyzwlbRJvkJbL5KIcm6rWP9HEsh5O+SxjGmL NRhDWcLTXUflp6BrG2GchJvbOfBJ6oU= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-f36mre86PHyMVCY3-uuo2A-1; Tue, 11 Jun 2024 11:15:39 -0400 X-MC-Unique: f36mre86PHyMVCY3-uuo2A-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ebea1c1124so10954331fa.1 for <dev@dpdk.org>; Tue, 11 Jun 2024 08:15:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718118937; x=1718723737; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vhwcWZ+h22g9CdIxLCqh/QJDSrxorrZ9KMdL6Fw3e64=; b=fbNYKDZ41TiLMMuXF5iUSU6CueSNn6c3zxcaLkXIiIfjY3sZCbhRuI0PJh7SAoHpmB TddYCsK5QOOUPkL3D3jx+J1+w8frPsDrTfzwCbNVFT6TrGUTp4PNrqTrAtPA/OcCOL2K 5MW/LTTEGhOrU85XlDvo0pyq2J844ZtO6B/vz7t3Bxnaa3xRVjg3BCbhfQrLZo3DbksX wH6otHnL/pUA8wk6IQ5fxMvpUkkI7tcy1bQBY125xzrx+L3TR6XniF9TqdLrqRb83v53 PGT7ELvsqfDlwN9+dSp+MO1v759xJLu8KgHVS3/RyunBvn1v3IZMusWDWuIs7PlfPEWj cUZQ== X-Gm-Message-State: AOJu0YwHnL4C2FDTgn91/V73Kxe60aP/+tHf2xDdYugJ76NNP03N/cu+ z20Nc75CtNmvLiNxxSk2k050IDHbBUJj1mgOOfBD4VW+A6/DLPWSIJ/Ka2gsff3MdxairtBzGi4 /4wzQx4coR0Hgi9NWvKCr1twy4CbblWii3k1OrzHyNC9cbVWoqjySmaGGR7FbMyeyJZl5IGCj+j CjQ4wwz9Pzmq4LOXU= X-Received: by 2002:a2e:91d0:0:b0:2eb:d924:43fb with SMTP id 38308e7fff4ca-2ebd924456dmr63762811fa.41.1718118937698; Tue, 11 Jun 2024 08:15:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBIe26FqJNJR6QFbEAgsRIWTVfEKRqSGvnlYxBbUW14Kk/FAUZE7J1RRcmW+S9HYJrvEaAmwuraH+HNV7jSzk= X-Received: by 2002:a2e:91d0:0:b0:2eb:d924:43fb with SMTP id 38308e7fff4ca-2ebd924456dmr63762611fa.41.1718118937344; Tue, 11 Jun 2024 08:15:37 -0700 (PDT) MIME-Version: 1.0 References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com> <1709756036-24068-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1709756036-24068-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand <david.marchand@redhat.com> Date: Tue, 11 Jun 2024 17:15:25 +0200 Message-ID: <CAJFAV8w=_aLanaicxmCAmrzXX9Ar-y8cKaaC1Jtuz3ztKAbZag@mail.gmail.com> Subject: Re: [PATCH v5 0/6] more replacement of zero length array To: Tyler Retzlaff <roretzla@linux.microsoft.com> Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Yipeng Wang <yipeng1.wang@intel.com>, mb@smartsharesystems.com, fengchengwen@huawei.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Mar 6, 2024 at 9:14=E2=80=AFPM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > Replace some missed zero length arrays not captured in the > original series. > https://patchwork.dpdk.org/project/dpdk/list/?series=3D30410&state=3D* > > Zero length arrays are a GNU extension that has been > superseded by flex arrays. > > https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > > v5: > * no changes, rebase for upstream merge / conflicts. > > v4: > * add another temporary suppression of libabigail bug > for rte_rcu_qsbr. As with pipeline i cannot see that > rte_rcu_qsbr is nested in any other struct. > > v3: > * add temporary suppression of libabigail bug > https://sourceware.org/bugzilla/show_bug.cgi?id=3D31377 > * add 2 more patches covering lpm and table > (series ack has not been extended) > * add another zero length array missed in rcu and pipeline > > v2: > * added additional patches for fib & pipeline libs. > series-acks have been placed only against original > hash and rcu patches. > > Tyler Retzlaff (6): > hash: replace zero length array with flex array > rcu: replace zero length array with flex array > fib: replace zero length array with flex array > pipeline: replace zero length array with flex array > lpm: replace zero length array with flex array > table: replace zero length array with flex array > > devtools/libabigail.abignore | 5 +++++ > lib/fib/dir24_8.h | 2 +- > lib/fib/trie.h | 2 +- > lib/hash/rte_thash.c | 4 ++-- > lib/lpm/rte_lpm6.c | 2 +- > lib/pipeline/rte_pipeline.h | 2 +- > lib/pipeline/rte_port_in_action.c | 2 +- > lib/rcu/rcu_qsbr_pvt.h | 2 +- > lib/rcu/rte_rcu_qsbr.h | 2 +- > lib/table/rte_table_acl.c | 2 +- > lib/table/rte_table_array.c | 2 +- > lib/table/rte_table_hash_cuckoo.c | 2 +- > lib/table/rte_table_hash_ext.c | 2 +- > lib/table/rte_table_hash_key16.c | 2 +- > lib/table/rte_table_hash_key32.c | 2 +- > lib/table/rte_table_hash_key8.c | 2 +- > lib/table/rte_table_hash_lru.c | 2 +- > lib/table/rte_table_lpm.c | 2 +- > lib/table/rte_table_lpm_ipv6.c | 2 +- > 19 files changed, 24 insertions(+), 19 deletions(-) libabigail 2.5 got released. I had a try with it in GHA, and the false positive errors around lib/pipeline and lib/rcu are gone. Yet there may still be people using older version, so let's take this series as is with the temporary exceptions. Series applied, thanks. --=20 David Marchand