From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E83CC43AF9; Mon, 12 Feb 2024 11:16:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 718CE40274; Mon, 12 Feb 2024 11:16:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D355840151 for ; Mon, 12 Feb 2024 11:16:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707732973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cf4CsXmoxP2ZoS9b1IP3lIIYEX4gZddyc2Ho1VSbmy8=; b=O5PgryNQR5yZxovmOjBVzcA5ynOC/v2+VqIOgaTtx11ZG/jyvB4UBRWsiS95pmdLkGKz/X 0vK5cytisSJS04aWw5JLi7vgLOr+bhF4Q7efj5YsSt3lcNsWIVEX3Q7yGg3oK2HUjwT2f5 eP2k9Eyb8jEbhJ2rvT53pJdXBZgawqM= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-CMKAzJrrNpaZENwpqmTsIA-1; Mon, 12 Feb 2024 05:16:12 -0500 X-MC-Unique: CMKAzJrrNpaZENwpqmTsIA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5115b4756d4so1214400e87.1 for ; Mon, 12 Feb 2024 02:16:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707732970; x=1708337770; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cf4CsXmoxP2ZoS9b1IP3lIIYEX4gZddyc2Ho1VSbmy8=; b=sc4q5s8Wzh02qLBAkkWuN9wFIzSfpuc/l0Jd0nQjBjTOaViHyJT7Vf0a9rkXB1uN2M EmgH6JS/j4jTuudjCKfg+yjJOr2l5qKeFsIZQBdCMKouAhGcEbTf+Zy+v7nt0kv2TgnA 3T8MHVxE6TQ9yy4t1p/cS1KqyF2OpsWsqqrq7O8nkudZy11iB/smTU99oYouSrHcTII2 CPjvFGPrTR6rWpbxolyaiKURAfuxl/wxvUbNeY1Qv5w8nsgK3gYxoyMun2O6SFPw870M B7VKfbA5QzduQdYFQoY9CvDRI+9S2ON+PSYxqURbVQKPaqdziHCUlxAUQXGMoUpBHeOh 4Rfg== X-Forwarded-Encrypted: i=1; AJvYcCUE1uEXo6eQTfqXKF4xMxDEsFMmBFxEvtgvvighYa9X2b8V7Qha1MJ5XLFSZR9hQ8zZdrX1Exuh2CDcr0c= X-Gm-Message-State: AOJu0YxZgKzQCbafoOUu0gnjeyNb818HqGUP9nSx4LMHTmnGbKsqA0JI +BG4LTxJ9j1/ZzDy8KJdJXKy/Po0Lq3016Nz3N7NBQvKktkzDF06AP6u07FvReywHiUVBN+nrOz ERjTa4gX08kxiUKswbR3+SzjqtD9NyTUikCfQBkBXnfN7K52eOH9P20fUfskFQ5x4ClAALf2hyS mpF4was02pkwwr79g= X-Received: by 2002:a05:6512:348a:b0:511:3ed0:f0e with SMTP id v10-20020a056512348a00b005113ed00f0emr4184565lfr.13.1707732970572; Mon, 12 Feb 2024 02:16:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7ryw5BqMDISjKUwbot+RnPdNHCbJL6c9wknQaCtZCvJG0AxDaCZTOQ5yTYFga7ZA0QlAZ80Cl+Ko0yf5YOlg= X-Received: by 2002:a05:6512:348a:b0:511:3ed0:f0e with SMTP id v10-20020a056512348a00b005113ed00f0emr4184553lfr.13.1707732970299; Mon, 12 Feb 2024 02:16:10 -0800 (PST) MIME-Version: 1.0 References: <20231224220201.762377-1-jonathan.erb@threater.com> <20240118172602.898004-1-jonathan.erb@threater.com> In-Reply-To: <20240118172602.898004-1-jonathan.erb@threater.com> From: David Marchand Date: Mon, 12 Feb 2024 11:15:58 +0100 Message-ID: Subject: Re: [PATCH] telemetry: correct json empty dictionaries To: Jonathan Erb Cc: ciara.power@intel.com, dev@dpdk.org, bruce.richardson@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 19, 2024 at 8:48=E2=80=AFAM Jonathan Erb wrote: > > Fix to allow telemetry to handle empty dictionaries correctly. > > This patch resolves an issue where empty dictionaries are reported > by telemetry as '[]' rather than '{}'. Initializing the output > buffer based on the container type resolves the issue. > Fixes: c933bb5177ca ("telemetry: support array values in data object") Cc: stable@dpdk.org > Signed-off-by: Jonathan Erb Acked-by: Ciara Power Applied thanks. --=20 David Marchand