From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by dpdk.org (Postfix) with ESMTP id 2A8843572 for ; Thu, 14 Mar 2019 16:12:12 +0100 (CET) Received: by mail-vk1-f172.google.com with SMTP id k64so1455189vke.1 for ; Thu, 14 Mar 2019 08:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JunMO9wVZrWKsB6mYsDFgZshd5mk0FJz97C2r90MJ/g=; b=tYg85hPSBojQl45h9XqCACMD99HoxfF7z8V2/Aq/V8FK8MVtr2HAql1r9O1XwA4cqr fhfXW5YOs9Bbu8aY/Z+qZe0vPxzj7aCBfqF5t7SGkQgPZOYvhBbNVYwu8zdFYk5bUt3m Dx7ZewDYWHhYKLhlJ4mj5o/E0IbASR2znWRyTjI+b494cOPfm5ekx5AqazQVEbEN9Q0h Ir0RlMP1kBzYpxiruyekX3J6wEzSbNGo5BwMIYr+WblSMXvaTkXX4jyEbIEDFoKGu8t5 nzXpFsRGmq1ZICXuQpL2/eF0PXd8m5VHCqq04uPchT5QtzO+nwevz16Jt6ITSvLigHCC R7sA== X-Gm-Message-State: APjAAAVg9r6iIMEnWnBQLgpSrOAWW6kC55IRP5h6TJEHml9/6jrnxS6e xCKze421vl74QyzOo9jU52JPse0DYS9jO9aiOzC6jw== X-Google-Smtp-Source: APXvYqw95qL4yyuey2Z9fdupyG+mGfGObeLxmm3hF9KOOacodGxkHAmNTX6jqz3hPLhBDFM99qHbhc4Sdoliwa9dO8c= X-Received: by 2002:a1f:1441:: with SMTP id 62mr10790481vku.31.1552576331417; Thu, 14 Mar 2019 08:12:11 -0700 (PDT) MIME-Version: 1.0 References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 14 Mar 2019 16:12:00 +0100 Message-ID: To: Ferruh Yigit Cc: dev , Thomas Monjalon , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 15:12:12 -0000 On Mon, Mar 11, 2019 at 7:09 PM David Marchand wrote: > On Mon, Mar 11, 2019 at 6:22 PM Ferruh Yigit > wrote: > >> On 3/4/2019 11:18 AM, David Marchand wrote: >> > According to the api, the q_errors[] per queue statistic is for >> reception >> > errors not transmit errors. >> > This is a first cleanup on statistics before looking at oerrors. >> > >> >> Yes, the patchset looks aligned with the API documentation [1]. >> >> What can be the solution after cleanup? We can merge this cleanup and >> solution >> next to each-other to not leave a gap? >> 1- Different variables for Rx and Tx errors? >> 2- Combine Rx & Tx into this single variable? >> >> It can be good to find a solution because new PMDs doing same mistake >> because of >> copy/paste... >> > > Might not be feasible but how about we could introduce an internal stats > structure containing the needed field for tx. > pmd would use it but ethdev would translate it to the current exposed api > rte_eth_dev_stats_get ? > The additional field would be formatted by ethdev to be provided through > the xstats api. > Sending RFC patches to have something to discuss on. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4AB6DA0096 for ; Thu, 14 Mar 2019 16:12:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 824EF47CE; Thu, 14 Mar 2019 16:12:13 +0100 (CET) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by dpdk.org (Postfix) with ESMTP id 2A8843572 for ; Thu, 14 Mar 2019 16:12:12 +0100 (CET) Received: by mail-vk1-f172.google.com with SMTP id k64so1455189vke.1 for ; Thu, 14 Mar 2019 08:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JunMO9wVZrWKsB6mYsDFgZshd5mk0FJz97C2r90MJ/g=; b=tYg85hPSBojQl45h9XqCACMD99HoxfF7z8V2/Aq/V8FK8MVtr2HAql1r9O1XwA4cqr fhfXW5YOs9Bbu8aY/Z+qZe0vPxzj7aCBfqF5t7SGkQgPZOYvhBbNVYwu8zdFYk5bUt3m Dx7ZewDYWHhYKLhlJ4mj5o/E0IbASR2znWRyTjI+b494cOPfm5ekx5AqazQVEbEN9Q0h Ir0RlMP1kBzYpxiruyekX3J6wEzSbNGo5BwMIYr+WblSMXvaTkXX4jyEbIEDFoKGu8t5 nzXpFsRGmq1ZICXuQpL2/eF0PXd8m5VHCqq04uPchT5QtzO+nwevz16Jt6ITSvLigHCC R7sA== X-Gm-Message-State: APjAAAVg9r6iIMEnWnBQLgpSrOAWW6kC55IRP5h6TJEHml9/6jrnxS6e xCKze421vl74QyzOo9jU52JPse0DYS9jO9aiOzC6jw== X-Google-Smtp-Source: APXvYqw95qL4yyuey2Z9fdupyG+mGfGObeLxmm3hF9KOOacodGxkHAmNTX6jqz3hPLhBDFM99qHbhc4Sdoliwa9dO8c= X-Received: by 2002:a1f:1441:: with SMTP id 62mr10790481vku.31.1552576331417; Thu, 14 Mar 2019 08:12:11 -0700 (PDT) MIME-Version: 1.0 References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 14 Mar 2019 16:12:00 +0100 Message-ID: To: Ferruh Yigit Cc: dev , Thomas Monjalon , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190314151200.DUYZitpQpJaSEE_uHU-OLwhJdBniyiEYOYS1I5lf9rQ@z> On Mon, Mar 11, 2019 at 7:09 PM David Marchand wrote: > On Mon, Mar 11, 2019 at 6:22 PM Ferruh Yigit > wrote: > >> On 3/4/2019 11:18 AM, David Marchand wrote: >> > According to the api, the q_errors[] per queue statistic is for >> reception >> > errors not transmit errors. >> > This is a first cleanup on statistics before looking at oerrors. >> > >> >> Yes, the patchset looks aligned with the API documentation [1]. >> >> What can be the solution after cleanup? We can merge this cleanup and >> solution >> next to each-other to not leave a gap? >> 1- Different variables for Rx and Tx errors? >> 2- Combine Rx & Tx into this single variable? >> >> It can be good to find a solution because new PMDs doing same mistake >> because of >> copy/paste... >> > > Might not be feasible but how about we could introduce an internal stats > structure containing the needed field for tx. > pmd would use it but ethdev would translate it to the current exposed api > rte_eth_dev_stats_get ? > The additional field would be formatted by ethdev to be provided through > the xstats api. > Sending RFC patches to have something to discuss on. -- David Marchand