Re: [PATCH v5 0/3] lcore options cleanup

[David Marchand <david.marchand@redhat.com>]

On Sun, Jun 8, 2025 at 11:12 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 27/05/2025 17:29, Bruce Richardson:
> > This patchset performs some basic cleanup of EAL lcore arguments before
> > any more serious work is done on them (as discussed in previous patchset
> > revisions).
> >
> > * mark the old coremask parameter (-c) and service core mask (-s) as
> >   deprecated, so they can be dropped in future. Everything should now be
> >   done using core lists where possible.
> > * consolidate the, previously separate but similar, "-l" and "--lcores"
> >   flags into just short and long versions of the same thing. This does
> >   not affect the "--lcores" flag at all, but expands the scope of what
> >   was possible with "-l".
> > * Add documentation of examples of use of the -l/--lcores parameter
> >
> > V5: adjust the examples in patch 3, to only use quotes where necessary
> >   and explain in a note why they are sometimes used in the examples.
> >
> > Bruce Richardson (3):
> >   eal: deprecate old coremask-based EAL parameters
> >   eal: merge corelist and core mapping options
> >   doc: provide examples of using lcores EAL parameter
>
> This first step looks reasonnable,
> but we need more acks for the deprecation.
>
> Applied without the first patch deprecating the famous -c option,
> pending for a later stage in this release cycle.

Sorry, I wanted to review this series sooner.
It looks good to me, even though it is already applied.

The deprecation notice lgtm, I sent some comments on it.


-- 
David Marchand