From: David Marchand <david.marchand@redhat.com>
To: Chengwen Feng <fengchengwen@huawei.com>
Cc: thomas@monjalon.net, ferruh.yigit@amd.com, dev@dpdk.org
Subject: Re: [PATCH 0/9] fix kvargs callback prototype not clearly defined
Date: Thu, 9 Mar 2023 16:19:33 +0100 [thread overview]
Message-ID: <CAJFAV8wB5Wo7XbpvA=wa-HwpRrTfNrw0mY7QZGze+ejPg4BFxw@mail.gmail.com> (raw)
In-Reply-To: <20230302075012.32423-1-fengchengwen@huawei.com>
On Thu, Mar 2, 2023 at 8:56 AM Chengwen Feng <fengchengwen@huawei.com> wrote:
>
> The rte_kvargs_process() was used to parse KV pairs, it also supports
> to parse 'only keys' (e.g. socket_id) type. And the callback function
> parameter 'value' is NULL when parsed 'only keys'.
>
> But where there is no detailed definition of 'value' maybe NULL. this
> leads to a lot of processing errors (some may cause segment errors).
> This patchset fixes some of them.
>
> Chengwen Feng (9):
> kvargs: detailed definition of callback prototype
> compressdev: fix segment fault when parse input args
> compressdev: fix null name when parse input args
> cryptodev: fix segment fault when parse input args
> cryptodev: fix null name when parse input args
> net/hns3: fix segment fault when parse runtime config
> net/virtio: fix segment fault when parse devargs
> dma/skeleton: fix segment fault when parse devargs
> raw/skeleton: fix segment fault when parse devargs
>
> drivers/dma/skeleton/skeleton_dmadev.c | 8 +++++++-
> drivers/net/hns3/hns3_common.c | 9 +++++++++
> drivers/net/virtio/virtio_ethdev.c | 3 +++
> drivers/net/virtio/virtio_pci_ethdev.c | 3 +++
> drivers/raw/skeleton/skeleton_rawdev.c | 2 ++
> lib/compressdev/rte_compressdev_pmd.c | 6 ++++++
> lib/cryptodev/cryptodev_pmd.c | 7 +++++++
> lib/kvargs/rte_kvargs.h | 14 +++++++++++++-
> 8 files changed, 50 insertions(+), 2 deletions(-)
Series applied, thanks Chengwen.
--
David Marchand
next prev parent reply other threads:[~2023-03-09 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 7:50 Chengwen Feng
2023-03-02 7:50 ` [PATCH 1/9] kvargs: detailed definition of callback prototype Chengwen Feng
2023-03-09 13:12 ` Olivier Matz
2023-03-02 7:50 ` [PATCH 2/9] compressdev: fix segment fault when parse input args Chengwen Feng
2023-03-02 7:50 ` [PATCH 3/9] compressdev: fix null name " Chengwen Feng
2023-03-02 7:50 ` [PATCH 4/9] cryptodev: fix segment fault " Chengwen Feng
2023-03-02 8:11 ` [EXT] " Akhil Goyal
2023-03-02 9:21 ` fengchengwen
2023-03-02 7:50 ` [PATCH 5/9] cryptodev: fix null name " Chengwen Feng
2023-03-02 7:50 ` [PATCH 6/9] net/hns3: fix segment fault when parse runtime config Chengwen Feng
2023-03-08 7:37 ` Dongdong Liu
2023-03-02 7:50 ` [PATCH 7/9] net/virtio: fix segment fault when parse devargs Chengwen Feng
2023-03-09 15:21 ` Maxime Coquelin
2023-03-02 7:50 ` [PATCH 8/9] dma/skeleton: " Chengwen Feng
2023-03-02 7:50 ` [PATCH 9/9] raw/skeleton: " Chengwen Feng
2023-03-02 9:17 ` [PATCH 0/9] fix kvargs callback prototype not clearly defined fengchengwen
2023-03-09 15:19 ` David Marchand [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-02 7:48 Chengwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wB5Wo7XbpvA=wa-HwpRrTfNrw0mY7QZGze+ejPg4BFxw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).