From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0CEB41E1C; Thu, 9 Mar 2023 16:19:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D10C8410EE; Thu, 9 Mar 2023 16:19:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A89A40ED7 for ; Thu, 9 Mar 2023 16:19:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678375187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vzv/i8ePO5+66GOdLjDAWEU0YlW/32gHdIVsV9AMTHw=; b=ck1xqmXLnFsYWar0TSoBQn+8Pmk2TaazR5f5x5noB1/XFY1MMnNqNWMKTEmPHwopw0PXaV co07i6+0h8Gx3Pj5WNJ1s7zk2IKFPYDlW7F2pTyj7F0OPuskDgDzDHQFiu+Qzsy9WXMUUB hLVg+6njENYfLAF011DEw3U91RVzJUI= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-cjyTmr3SMQGnxbPyv3TZig-1; Thu, 09 Mar 2023 10:19:46 -0500 X-MC-Unique: cjyTmr3SMQGnxbPyv3TZig-1 Received: by mail-pf1-f197.google.com with SMTP id s20-20020a056a00179400b005c4d1dedc1fso1342344pfg.11 for ; Thu, 09 Mar 2023 07:19:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678375185; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vzv/i8ePO5+66GOdLjDAWEU0YlW/32gHdIVsV9AMTHw=; b=dZl2Aiax5EHQqPMxuADIdDXTnj6pSogC+vj3BAm3gOAzFTpINRB47aMYlIi302YXza SG9Ar70LrXzb6wFYfmzL17t4QehfvNtlpIfaa1IyX1+Gxep/EbrQU7UHzfbR4rYM1dIc UMAsgvjhrvXGuCWyTLcPyHrfCIeFXKkHZFZSpAGa69+IVE3IpE9EP3sk9ZW6KdhqHCMS VvTw9CQGMZA6BfA6b/h86aUFWMT5b+z8GJEwnuwvo9BCnvcZFR63t67wUyhRbHa08tZa L4l+12lV/4CHt4+iN2GPVAOr0rizKIW54mMlfcnlWW9Y3d0tbyEZVBouxL02E9OzG8Tk gkNw== X-Gm-Message-State: AO0yUKUpzQqPW18S32eaPmtBv5EOoT24H9GiTFTz0DG80qWpnAJZYBGq tApfBNVeMkpsIFgajhpN7ekuvo4TntGI7HUrQfWBx7O3ikkkdy59ycIOnAIqKRtP8Nj/BzXCnne ih89kfNW3vZ+sl6nPIz8= X-Received: by 2002:a17:903:13c6:b0:198:adbc:9b1e with SMTP id kd6-20020a17090313c600b00198adbc9b1emr11425547plb.5.1678375185135; Thu, 09 Mar 2023 07:19:45 -0800 (PST) X-Google-Smtp-Source: AK7set+H6pxBur1sCF8nT1YNdUpd4gNPASF/bBLIXxqfRh4bbgGdIMyQE7TzGuGq9rVDn0iiPrvqHws0dYMnJvhhM5A= X-Received: by 2002:a17:903:13c6:b0:198:adbc:9b1e with SMTP id kd6-20020a17090313c600b00198adbc9b1emr11425532plb.5.1678375184835; Thu, 09 Mar 2023 07:19:44 -0800 (PST) MIME-Version: 1.0 References: <20230302075012.32423-1-fengchengwen@huawei.com> In-Reply-To: <20230302075012.32423-1-fengchengwen@huawei.com> From: David Marchand Date: Thu, 9 Mar 2023 16:19:33 +0100 Message-ID: Subject: Re: [PATCH 0/9] fix kvargs callback prototype not clearly defined To: Chengwen Feng Cc: thomas@monjalon.net, ferruh.yigit@amd.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 2, 2023 at 8:56=E2=80=AFAM Chengwen Feng wrote: > > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > But where there is no detailed definition of 'value' maybe NULL. this > leads to a lot of processing errors (some may cause segment errors). > This patchset fixes some of them. > > Chengwen Feng (9): > kvargs: detailed definition of callback prototype > compressdev: fix segment fault when parse input args > compressdev: fix null name when parse input args > cryptodev: fix segment fault when parse input args > cryptodev: fix null name when parse input args > net/hns3: fix segment fault when parse runtime config > net/virtio: fix segment fault when parse devargs > dma/skeleton: fix segment fault when parse devargs > raw/skeleton: fix segment fault when parse devargs > > drivers/dma/skeleton/skeleton_dmadev.c | 8 +++++++- > drivers/net/hns3/hns3_common.c | 9 +++++++++ > drivers/net/virtio/virtio_ethdev.c | 3 +++ > drivers/net/virtio/virtio_pci_ethdev.c | 3 +++ > drivers/raw/skeleton/skeleton_rawdev.c | 2 ++ > lib/compressdev/rte_compressdev_pmd.c | 6 ++++++ > lib/cryptodev/cryptodev_pmd.c | 7 +++++++ > lib/kvargs/rte_kvargs.h | 14 +++++++++++++- > 8 files changed, 50 insertions(+), 2 deletions(-) Series applied, thanks Chengwen. --=20 David Marchand