From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58C32A0C4D; Thu, 15 Jul 2021 10:00:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 901C140689; Thu, 15 Jul 2021 10:00:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 600C640143 for <dev@dpdk.org>; Thu, 15 Jul 2021 10:00:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626336033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n4++ybVbd65OI6D0oyqbB5XSfjWEwEtxgYVM0sAbRFA=; b=g4r2x+rPJdaCOyTSqukhrSx3BskLgDu0LM+TtwXfYFPEQU4Ih6k2DQRNFsUIm3w2vha7lD zeMTxrfSO64Nj+exJK4AWvbPXB2T7DwbR6waFZSXc9ZflL3ohS0C+bBMcJKLV1tBqkyhl2 HCA54hPHiC02ddBr8Nqa4dnJWbt7QoI= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-nvdvQCrgOROp58N0SOLB4A-1; Thu, 15 Jul 2021 04:00:31 -0400 X-MC-Unique: nvdvQCrgOROp58N0SOLB4A-1 Received: by mail-vs1-f72.google.com with SMTP id e13-20020a056102034db02902995cc3024fso1782687vsa.14 for <dev@dpdk.org>; Thu, 15 Jul 2021 01:00:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n4++ybVbd65OI6D0oyqbB5XSfjWEwEtxgYVM0sAbRFA=; b=dfTas0/nj+dw6q/CS180ZvApHHhXtgF+IHtoEhyUTuA7CoOJU5ui+lyXppkShmuw1+ GP+MWoAZIYUF/PpoorkpZzHdI6lWfnhDZJ+3L9HCEeY7W1HWRgQVGywA/lYNG7kY/QBV nb1Yg6jmjYcbpm4BSVBJuho4hHtM0jsQCSD82F5VwcorVhAWKRs2BkZAabtpN03sJc4M J9Muzz6JWwyAuNKkZMe/NYTK901goqhj3KDoyBHoHfKBtsYIceuSBlFVM/IGW7OpGa/G 5i0z/xNjwtYxiqdxLChLuC+h097GnBpnWofTylTjSDOvY+V34FfhxApFUCvsM8dO8YOb 3mKQ== X-Gm-Message-State: AOAM532ER2LgIcZlCb4GQhB8z+a8h1xcu+2+hGkljyuAmFeZ6TJNAOg8 zGj4Nlu/81EvmFDipZ9nGaCFmCn9+e8bcQSI07S83GJ9BKeRQVDKvM1LiPZEzVxb5V3ThAZJ0iV uzYHwEtipFBXEDF9SxII= X-Received: by 2002:a05:6102:21b:: with SMTP id z27mr4674568vsp.18.1626336031265; Thu, 15 Jul 2021 01:00:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlwM/Kfga93r5gvWHEq/QnZeAhDYXpyMtUSwW9Gs6qHoei65/njfUtMiGWHbgo3cS0JQi0yj/E0ySFgLqb1TM= X-Received: by 2002:a05:6102:21b:: with SMTP id z27mr4674501vsp.18.1626336030945; Thu, 15 Jul 2021 01:00:30 -0700 (PDT) MIME-Version: 1.0 References: <20210630092613.70647-1-mohamad.noor.alim.hussin@intel.com> <BYAPR11MB29019C45173776CCEEDCE22A89019@BYAPR11MB2901.namprd11.prod.outlook.com> <DM6PR11MB313172FE145950817053F23CE3009@DM6PR11MB3131.namprd11.prod.outlook.com> <MWHPR11MB201329DC61D770B7D5E6269E8D1F9@MWHPR11MB2013.namprd11.prod.outlook.com> <BN9PR11MB54837BF4710F18ACC16F4659E3139@BN9PR11MB5483.namprd11.prod.outlook.com> In-Reply-To: <BN9PR11MB54837BF4710F18ACC16F4659E3139@BN9PR11MB5483.namprd11.prod.outlook.com> From: David Marchand <david.marchand@redhat.com> Date: Thu, 15 Jul 2021 10:00:19 +0200 Message-ID: <CAJFAV8wB=gtzvgTsEhdLfUiFxwgK+LFG5+pM18kAvPjQ5LCCxw@mail.gmail.com> To: "Zhang, Tianfei" <tianfei.zhang@intel.com>, "Hussin, Mohamad Noor Alim" <mohamad.noor.alim.hussin@intel.com> Cc: "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Huang, Wei" <wei.huang@intel.com>, "stable@dpdk.org" <stable@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hello, On Wed, Jul 14, 2021 at 5:40 AM Zhang, Tianfei <tianfei.zhang@intel.com> wrote: > > > > > Hi Tianfei, > > > > To reproduce this, assume using Ubuntu 20.04. > > 1. Install libfdt (It will include ifpga driver from drivers/raw/ifpga/base) > > $ sudo apt-get install libfdt-dev > > 2. configure DPDK library > > $ meson build > > 3. check libdpdk.pc file in build/meson-private/libdpdk.pc. It will include path > > to librt.so without this patch. > > I have checked the libdpdk.pc and got the different between with and without this patch. > Without this patch, there are a full path for librt.so in libdpdk.pc. With this patch, it provide "-lrt" in libdpdk.pc. > > This patch looks good for me. > > Acked-by: Tianfei Zhang <Tianfei.zhang@intel.com> I can't find the original mail to dev@dpdk.org and patchwork did not help. Please, can you resubmit this patch? Also copy Bruce as this touches a meson subtlety I was not aware of, and he should probably have a look. Thanks. -- David Marchand