From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D45242B8C; Wed, 24 May 2023 14:57:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDAF14067E; Wed, 24 May 2023 14:57:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BD9C640156 for ; Wed, 24 May 2023 14:57:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684933077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kycTuf2Ib8ruWzCT5Q8VPjW4CXJcnYIsGr5WLBil2Dg=; b=fFG08MZMOuLvrRn+E0FdzM3qnB350REeRJyEZ4YO9pG7yDt2ipH4IjW2kVBpbPiibdu74U Tr7UOFUuP7vPWBmkKFM9gRR5cstDfxeFW1kY7ACVwn8d+i29CyA9GemUpJXrKh4rjQHlHn t1zXf906GyX02KXKSXuXOn86mJxBKEI= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-TGLzN74GPmaTT0Oqc-c2qg-1; Wed, 24 May 2023 08:57:56 -0400 X-MC-Unique: TGLzN74GPmaTT0Oqc-c2qg-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1ae57e53a26so1234785ad.1 for ; Wed, 24 May 2023 05:57:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684933075; x=1687525075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kycTuf2Ib8ruWzCT5Q8VPjW4CXJcnYIsGr5WLBil2Dg=; b=J5JYNse92mcCf/Yq/6zmTUXmoyaL0dqS2bpUqWS4ueL5DvUIqxA6UdF906WYy2Lmi9 9HbkXPIVNlrAGFfYwEvHyVnUi0OMsa91itqryPsDxoChIrPRBBPN9U4hKcv4R2dOgo9M 9iSLzE6aFRx7kV4CusrCZPUrtsCLZCMWr7wDCiIk8qEoEmDLVDjZu64cs6FCB8uRXDk2 fxB0LzDE7loXx+rkmWjwStASMMZI0o7tSS0g93IzgBTpxo8UPq6RO+muR0R17rFrs3Jw qzOMTWDy1KFxrkcYktRafDql2jiddqHUxppIvyUi1uW2ze946Y5H9zhFS6xfmahQGpfb MjXA== X-Gm-Message-State: AC+VfDw1LqD1KxF2JFa8aTMkePwnosB6IhNVY2d/X6nBUPn+5qjp4Nss BT4vww6mEGRvO5ErBmkGZoQVKfNDJX9CUS/cwvE7tQqk8RTyezueMWVZSyhImMOH2WaP6ZyTLQv v9tOcFElpsESNFh1LVE4= X-Received: by 2002:a17:902:f54d:b0:1a6:45e5:a26a with SMTP id h13-20020a170902f54d00b001a645e5a26amr22701218plf.27.1684933075030; Wed, 24 May 2023 05:57:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4wJVbd6tV3eqbnZziSwIRCu9yJbkIM62+zYlz3r4sRAu0EvG9JwQKrYioNpreC/AzkBCwXD+MZ28f4JcyiMh8= X-Received: by 2002:a17:902:f54d:b0:1a6:45e5:a26a with SMTP id h13-20020a170902f54d00b001a645e5a26amr22701200plf.27.1684933074804; Wed, 24 May 2023 05:57:54 -0700 (PDT) MIME-Version: 1.0 References: <20230505103102.2912297-1-david.marchand@redhat.com> In-Reply-To: <20230505103102.2912297-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 24 May 2023 14:57:43 +0200 Message-ID: Subject: Re: [RFC PATCH] ethdev: advertise flow restore in mbuf To: Ori Kam , thomas@monjalon.net, Ferruh Yigit Cc: dev@dpdk.org, i.maximets@ovn.org, Aman Singh , Yuying Zhang , Matan Azrad , Viacheslav Ovsiienko , Andrew Rybchenko X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello guys, On Fri, May 5, 2023 at 12:31=E2=80=AFPM David Marchand wrote: > > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_info() impacts an application performance for driver= s > that do not provide this ops. > It could also impact processing of packets that require no call to > rte_flow_get_restore_info() at all. > > Advertise in mbuf (via a dynamic flag) whether the driver has more > metadata to provide via rte_flow_get_restore_info(). > The application can then call it only when required. > > Link: http://inbox.dpdk.org/dev/5248c2ca-f2a6-3fb0-38b8-7f659bfa40de@ovn.= org/ > Signed-off-by: David Marchand > --- > Note: I did not test this RFC patch yet but I hope we can resume and > maybe conclude on the discussion for the tunnel offloading API. Any comment? Thanks. --=20 David Marchand