From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4186BA0519; Fri, 3 Jul 2020 09:43:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88EB11DA16; Fri, 3 Jul 2020 09:43:18 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 1CD211DA0F for ; Fri, 3 Jul 2020 09:43:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593762196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bR62MDFRu3EAWskyrWU9LzgtogtLdU2ogX+3doaV7jg=; b=RGEJndWGqUJfl0in8VwNCHi+eYDdo8EIqtgGNnuwSETLCHMDbCgveVTbXyIuB7OaAD+QmV lXkjjz7/5Ra8q8f/9lXgp5xpO8AdkGvo5MDPLWpKZDyT9Y2ObUlcr2z99LSJOcmUUPYvOs ZiaHoiI6GflW5E2teFXkbLfO2FrcGAA= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-MdxcY82JNieAQ-_uSG1QNg-1; Fri, 03 Jul 2020 03:43:12 -0400 X-MC-Unique: MdxcY82JNieAQ-_uSG1QNg-1 Received: by mail-vs1-f70.google.com with SMTP id o71so7117411vsd.5 for ; Fri, 03 Jul 2020 00:43:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bR62MDFRu3EAWskyrWU9LzgtogtLdU2ogX+3doaV7jg=; b=i4R0Vi3K2Qn18E1IKO89UdDFx4aw4gkEFTkU2se3uVTG+Y+WMBiVCIq2QsMqYtNBlC itOew3Fa1sJBB6Qd5B94Eu2NCaHyql8S81UA4Nr1RcJbrlcMWqggaahP8fz/f+zH/wwe t1b3soyF26Ko2d9OTAcoyVpfwio/54yJqp5rXrOc7ne+mW8+fYoTVZ/oKJWVy7E6nMX3 O8UiFwoSxlUHwAsXRkSnV5gcW+8DQJFULLsf1BF7oRWAXDV1E6215rVuNt8EY16XBFkA HnkGV/1VLXXBJFTEy3lIiV+uB9ueIHF9XAE8Cezjjdy/LExzw6Mn9CQlPhudjj4dUVMT crFg== X-Gm-Message-State: AOAM530VQ90NqdXjK6j8Y98qK17B21lydS9k1cRhhbXIy7IaABAY7P9Z icAGtTnbqn2LKMW4+NkmEbzYyT1eTyrr+b7yw7W2mvB7EkI1937c35RroOYoVXkBggSfZBfT0DX AEGXct68aCr7vZ6PIiIg= X-Received: by 2002:a67:2ed6:: with SMTP id u205mr5692274vsu.198.1593762192418; Fri, 03 Jul 2020 00:43:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUl8+S4UhvDFfgTDfQBArY/8mNAV16H7heYTeUu9FUmyiWta6xmB++jvHq0CItGXxLy20ccEBM9cQpDbQeeGg= X-Received: by 2002:a67:2ed6:: with SMTP id u205mr5692260vsu.198.1593762192127; Fri, 03 Jul 2020 00:43:12 -0700 (PDT) MIME-Version: 1.0 References: <20190906094534.36060-1-ruifeng.wang@arm.com> <20200629080301.97515-1-ruifeng.wang@arm.com> <20200629080301.97515-2-ruifeng.wang@arm.com> In-Reply-To: From: David Marchand Date: Fri, 3 Jul 2020 09:43:01 +0200 Message-ID: To: Ruifeng Wang , Honnappa Nagarahalli Cc: John McNamara , Marko Kovacevic , Ray Kinsella , Neil Horman , dev , "Ananyev, Konstantin" , nd , Vladimir Medvedkin , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 1/3] lib/lpm: integrate RCU QSBR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Ruifeng, On Mon, Jun 29, 2020 at 1:56 PM David Marchand wrote: > > diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c > > index 38ab512a4..41e9c49b8 100644 > > --- a/lib/librte_lpm/rte_lpm.c > > +++ b/lib/librte_lpm/rte_lpm.c > > @@ -1,5 +1,6 @@ > > /* SPDX-License-Identifier: BSD-3-Clause > > * Copyright(c) 2010-2014 Intel Corporation > > + * Copyright(c) 2020 Arm Limited > > */ > > > > #include > > @@ -245,13 +246,84 @@ rte_lpm_free(struct rte_lpm *lpm) > > TAILQ_REMOVE(lpm_list, te, next); > > > > rte_mcfg_tailq_write_unlock(); > > - > > +#ifdef ALLOW_EXPERIMENTAL_API > > + if (lpm->dq) > > + rte_rcu_qsbr_dq_delete(lpm->dq); > > +#endif > > All DPDK code under lib/ is compiled with the ALLOW_EXPERIMENTAL_API flag set. > There is no need to protect against this flag in rte_lpm.c. Please can you look at this? Thanks. -- David Marchand