From: David Marchand <david.marchand@redhat.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
Nicolas Chautru <nicolas.chautru@intel.com>,
Gagandeep Singh <g.singh@nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Elena Agostini <eagostini@nvidia.com>,
Liron Himi <lironh@marvell.com>, Ori Kam <orika@nvidia.com>
Subject: Re: [PATCH] drivers: add dependencies for some classes
Date: Sat, 26 Aug 2023 10:40:49 +0200 [thread overview]
Message-ID: <CAJFAV8wCc5BRoh2=kzms0h3g2EZ46XjLBL=YTXiDY1pd23jgbw@mail.gmail.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B44@smartserver.smartshare.dk>
On Fri, Aug 25, 2023 at 8:18 PM Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > From: David Marchand [mailto:david.marchand@redhat.com]
> > Sent: Friday, 25 August 2023 19.03
> >
> > A few classes meson.build were not expressing dependencies to the
> > associated device library. Define std_deps for baseband, gpu and regex
> > drivers.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
>
> On the surface, it looks like you are also removing a lot of (superfluous) dependencies. If not just a side effect of the added std_deps, perhaps the patch description should mention this too.
The dependency to the device library in a driver become superfluous as
a result of adding it to std_deps:
- std_deps is passed to drivers as the default deps:
https://git.dpdk.org/dpdk/tree/drivers/meson.build#n125
- none of those updated drivers meson.build was overriding/resetting
deps (grep -w deps $patch).
I'll add a note in the commitlog to make this explicit.
>
> Anyway,
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
Thanks.
--
David Marchand
next prev parent reply other threads:[~2023-08-26 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 17:02 David Marchand
2023-08-25 17:17 ` Bruce Richardson
2023-08-25 18:18 ` Morten Brørup
2023-08-26 8:40 ` David Marchand [this message]
2023-08-28 19:38 ` Maxime Coquelin
2023-08-29 8:05 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wCc5BRoh2=kzms0h3g2EZ46XjLBL=YTXiDY1pd23jgbw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=lironh@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=nicolas.chautru@intel.com \
--cc=orika@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).