From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D29ED4310C; Sat, 26 Aug 2023 10:41:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76CBD40E6E; Sat, 26 Aug 2023 10:41:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7D8414068E for ; Sat, 26 Aug 2023 10:41:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693039265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6WT/op4IWswGSk1ZlNsobnKYf0tKUEhEsbzgcouc698=; b=h+S8nNuMsQULgV/LfHVtL0KMh9dmQWNsnBMxU9WYO2DrDCg/1QKrpjWA2zpcuWLRMYQlWx yjyOZXUlHB2Vbhx6LBhe5fNGVTr8C+A0dIb5EU7yZ7jqlkhds4lyTzvkxpgvvSZeOW4KYz xrX69g95hvW3xan1gbVDNEgk0viDK1w= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482-fFAvmuj5MuqPE9x06MqZvA-1; Sat, 26 Aug 2023 04:41:02 -0400 X-MC-Unique: fFAvmuj5MuqPE9x06MqZvA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fe1d8bd885so1930440e87.1 for ; Sat, 26 Aug 2023 01:41:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693039260; x=1693644060; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6WT/op4IWswGSk1ZlNsobnKYf0tKUEhEsbzgcouc698=; b=EwtSiV4QCq74IQIgnxhsxymfxXUIUF9XamiMCGNsmoPExANvhHUoFrR29e+BUpbRjv Jy8sIclmh/yNUWTX1wsJ5KMUiO3y1i2n00TqDiTLy8xkjex1++ZD21rhfmULF5HoP5GX 85oodUGxbEEYyHirdkR/hsBKDmrvXcVmFadgMJQK/klr+hFpkS/IT6p0hYihqq4DXfuH p7i2n3DaGVzpZwPg5UNFXDD7crN/VZi4tPi7CD7WU7/DtbwaZCZq8TdGp8zNASP96O0N M7/f/t2r2R5Atr1mlBhSELzeKQTiU1VBlabhLOUgEP2ayLXZUXtOHElP4Ff21BqScBY7 ZtJw== X-Gm-Message-State: AOJu0Yz9ALCrbcYc5Cq7QK+u1hbqLymzWrWsEtQ6kFpvlHsYVP2iS3pf B1MdHv7TULMlClHZ6HM7mCpP5FrjTRpyIZpBmWHVpC5sa7u9Mp6iUM4lW+psNf4iF68CjDl/w42 KCNi5ETcPjLpi/TZOr7M= X-Received: by 2002:a05:6512:1294:b0:4f9:6adf:3981 with SMTP id u20-20020a056512129400b004f96adf3981mr8509392lfs.33.1693039260648; Sat, 26 Aug 2023 01:41:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyEqlmkZ+kTOD1wfSS4/yGe4oBai2G8UvyiGXoNzO3Xp1VpEJzEf/djpu7GEuk7Vj1p70NQj9Ugge9Sl5E3Nw= X-Received: by 2002:a05:6512:1294:b0:4f9:6adf:3981 with SMTP id u20-20020a056512129400b004f96adf3981mr8509383lfs.33.1693039260352; Sat, 26 Aug 2023 01:41:00 -0700 (PDT) MIME-Version: 1.0 References: <20230825170237.3829998-1-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D87B44@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B44@smartserver.smartshare.dk> From: David Marchand Date: Sat, 26 Aug 2023 10:40:49 +0200 Message-ID: Subject: Re: [PATCH] drivers: add dependencies for some classes To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dev@dpdk.org, bruce.richardson@intel.com, Nicolas Chautru , Gagandeep Singh , Hemant Agrawal , Elena Agostini , Liron Himi , Ori Kam X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 25, 2023 at 8:18=E2=80=AFPM Morten Br=C3=B8rup wrote: > > > From: David Marchand [mailto:david.marchand@redhat.com] > > Sent: Friday, 25 August 2023 19.03 > > > > A few classes meson.build were not expressing dependencies to the > > associated device library. Define std_deps for baseband, gpu and regex > > drivers. > > > > Signed-off-by: David Marchand > > --- > > On the surface, it looks like you are also removing a lot of (superfluous= ) dependencies. If not just a side effect of the added std_deps, perhaps th= e patch description should mention this too. The dependency to the device library in a driver become superfluous as a result of adding it to std_deps: - std_deps is passed to drivers as the default deps: https://git.dpdk.org/dpdk/tree/drivers/meson.build#n125 - none of those updated drivers meson.build was overriding/resetting deps (grep -w deps $patch). I'll add a note in the commitlog to make this explicit. > > Anyway, > > Acked-by: Morten Br=C3=B8rup > Thanks. --=20 David Marchand