From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7301C42D07; Tue, 20 Jun 2023 13:53:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ADCB4068E; Tue, 20 Jun 2023 13:53:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A4A8B400D6 for ; Tue, 20 Jun 2023 13:53:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687261983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jAFyznviXNWMvl/A+7r7M9kFye44+95ZRSM/QLKGHZ4=; b=XqwEIgD79Wco0vV1NLnpT7Q3Pchzx6dsv/NxAGKWzw56gc2z+qTa/9Xrj2yCq6Vv0fvnMP cqYYI0ARaWaePF83fz+JsvI7sUqctKg29B6jr127Ij3Gc7q4DZV/35RyhmKR/7fzDfZZLz sB7Ei03FthtyeGEK/iCy4OxyJ6gTrgg= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-_355n92KMbe2LpugtNo2WQ-1; Tue, 20 Jun 2023 07:53:02 -0400 X-MC-Unique: _355n92KMbe2LpugtNo2WQ-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1b50a3809a1so27066875ad.0 for ; Tue, 20 Jun 2023 04:53:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687261980; x=1689853980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jAFyznviXNWMvl/A+7r7M9kFye44+95ZRSM/QLKGHZ4=; b=kY+L3JDbCOaiYgFqpRx4Kbwbw94O/uGb5sJQXAKd9wS6zZwpoz9j8l5IATmjsRGKyf OyAZZhQ3sgBTcAVDPm9+eyHIK3TSCyQt9jbZS9ULHB0qK3885+Wg+7j2wTlrcxXapuCa x71pv08tY8HstOEY3dEF8kkHjLJqVHeu3n0cqE/vYquRTPp3/Fs7gjLUSck1pVtybZ73 7rWGJGcQPwj18SH2PsVH0dyCcf0A02pWpiXtMh4tYGevD5SKdAx/k+pwitmBTgFXaEfv /QbLwOMKqcY2tNW5qshoMZ+OJTSpc+vFydEnw+TocAbZjuT/ovQqKbEBHvptvD624qLt oeVQ== X-Gm-Message-State: AC+VfDzMF91+vPZQ0VEkTRljg6GEqf5za5CwaUdt+6/ySj91gHFz8L2w OrByBrDtjn4Q+dQGdz8g/W0D8OvMIbBGZCMs1ZIcXeiv7fG6oGZjjeohCmfN3nSrfPMPgE7Q6N3 NlgNsZYUeuuZLyVwCdVU= X-Received: by 2002:a17:902:f545:b0:1b6:6751:95f5 with SMTP id h5-20020a170902f54500b001b6675195f5mr7139971plf.25.1687261980462; Tue, 20 Jun 2023 04:53:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6A8TnXXArZt/DPWmX2vzDkY73G629on3XA3UnlKTgMzJXns/yfbRhQPX87n2j2/z920syXrw9Z5Rq71Q9RlcM= X-Received: by 2002:a17:902:f545:b0:1b6:6751:95f5 with SMTP id h5-20020a170902f54500b001b6675195f5mr7139959plf.25.1687261980220; Tue, 20 Jun 2023 04:53:00 -0700 (PDT) MIME-Version: 1.0 References: <20230619204650.3348681-1-david.marchand@redhat.com> <131df642-00ea-8317-bd09-9cc347a0d194@redhat.com> In-Reply-To: <131df642-00ea-8317-bd09-9cc347a0d194@redhat.com> From: David Marchand Date: Tue, 20 Jun 2023 13:52:49 +0200 Message-ID: Subject: Re: [PATCH 1/2] test: add graph tests To: Kevin Traynor Cc: Jerin Jacob , Luca Boccassi , "Xueming(Steven) Li" , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 12:32=E2=80=AFPM Kevin Traynor wrote: > > On 20/06/2023 07:56, David Marchand wrote: > > On Tue, Jun 20, 2023 at 8:50=E2=80=AFAM Jerin Jacob wrote: > >> > >> On Tue, Jun 20, 2023 at 2:17=E2=80=AFAM David Marchand > >> wrote: > >>> > >>> We forgot to add graph unit tests to the CI testsuites. > >>> > >>> Signed-off-by: David Marchand > >> > >> Could we add Fixes: ? > >> Either way, > >> Acked-by: Jerin Jacob > > > > Indeed. > > I don't think the graph unit tests and code changed much, so it should > > be ok to backport down to 20.11 and enable these ut in the CI. > > > > > > Sounds ok to me to add "Fixes:" tag and backport. If they pass, great - > if they don't, the graph maintainers would need to spend time updating > the tests etc or we could just drop the patch. Modulo some easy to fix conflict when backporting, the graph tests pass fin= e: - 20.11: 2023-06-20T11:30:44.7171265Z 87/96 DPDK:fast-tests / graph_autotest OK 0.13 s 2023-06-20T11:30:44.7171724Z 88/96 DPDK:fast-tests / node_list_dump OK 0.13 s - 21.11: 2023-06-20T11:32:37.2132951Z 90/101 DPDK:fast-tests / graph_autotest OK 0.17 s 2023-06-20T11:32:37.2133397Z 91/101 DPDK:fast-tests / node_list_dump OK 0.17 s - 22.11: 2023-06-20T11:50:48.2519983Z 92/106 DPDK:fast-tests / graph_autotest OK 0.17 s 2023-06-20T11:50:48.2520344Z 93/106 DPDK:fast-tests / node_list_dump OK 0.17 s --=20 David Marchand