Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument

[David Marchand <david.marchand@redhat.com>]

On Wed, Aug 7, 2019 at 10:57 AM Ye Xiaolong <xiaolong.ye@intel.com> wrote:
>
> On 08/07, David Marchand wrote:
> >On Wed, Aug 7, 2019 at 10:28 AM Congwen Zhang <zhang.congwen@zte.com.cn> wrote:
> >>
> >> The type of rss_conf is struct ixgbe_rte_flow_rss_conf *,
> >>  not struct rte_eth_rss_conf *.
> >
> >What is the actual issue?
> >Does it deserve a Fixes: tag?
> >
> >>
> >> Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
> >> ---
> >>  drivers/net/ixgbe/ixgbe_flow.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> >> index 92377b8..b2a2bfc 100644
> >> --- a/drivers/net/ixgbe/ixgbe_flow.c
> >> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> >> @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> >>         /* check if the next not void item is END */
> >>         act = next_no_void_action(actions, act);
> >>         if (act->type != RTE_FLOW_ACTION_TYPE_END) {
> >> -               memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
> >> +               memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
> >
> >Not sure what the maintainer prefers, but I would go with:
> >+               memset(rss_conf, 0, sizeof(*rss_conf));
> >
>
> Since all other occurrences of memset in ixgbe_flow.c are using
>         memset(aaa, 0, sizeof(struct bbb))
> format, maybe it's better to make it consistent with others.

Yes, fine with me.

A better commitlog is still needed though.

-- 
David Marchand