From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 41D40A04C2;
Fri, 15 Nov 2019 14:31:36 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id F3B822C28;
Fri, 15 Nov 2019 14:31:35 +0100 (CET)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[205.139.110.120]) by dpdk.org (Postfix) with ESMTP id D2BA12B86
for <dev@dpdk.org>; Fri, 15 Nov 2019 14:31:33 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1573824693;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=bV2txTf7TM4qS6qj5xTXNA1uS2aweQDuTLpSI1Cp+9U=;
b=bO3Zya638xRsFrwFibEZUkVt5JRIt/VtObp1pqyzLSbWb7oqZTx34lSDXpjWvgqAN9nbcw
wuQyBEKshw3zmZsieP0Z1Z+72/KNRWTHV8wURiTy3JSAo4kUTFYig3e5c5rDcldvogFZJX
WeIBUqLMHpUyqJjh9dLy/93Q7hFOz3o=
Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com
[209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-236-lw0L8r0tPzW5dOf6EieRGQ-1; Fri, 15 Nov 2019 08:31:31 -0500
Received: by mail-vk1-f199.google.com with SMTP id s17so4167738vkb.5
for <dev@dpdk.org>; Fri, 15 Nov 2019 05:31:31 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=TTTbMa8HR07jlBm8mxDSrlNZ2M+h4ALrXbdwV2zIx5E=;
b=cX4kH35fVcxBD1400i+qF8OwXtKBNahAYKvdOe4vwOA6cOT5or2wKl51DHVAg+r7Fw
2BBUyQZVmdSfZ4tQViO1JQRcfFntjlR+8KlU7WI6P0to/YVBtrtQQmGLvztRkkhr/zyn
1odbFftEajt62fZRdBwu4jRhfFQvaAWgyQRvDfFUh0BDYnjJQX6/lkB/UewWE772s7EQ
KBwxQCo8kMO/dj697t7tmQ/ECIrRbic13iF9QRNyCdyY7ZkPyQRbXHBUuV0Q38cGor7f
fNB07dx0fsHqhJufFV4lWkwIiik4P4Hnb8K/zr9mYMjIRrUN3FMScZ+GyKK/P/kEfrMs
3l/w==
X-Gm-Message-State: APjAAAUZ4nPBKgTU2g1WMI3ZyujZROhdj5CcjzzxWCdqodWlud6fJslw
99YGWJvmV70N/rQmcZRG7wFxP1sSqpYNDngoszymzHut1lTyHKd4xTNi9y+WWjcpLdElHznIr86
prwOjiQeyqhucsPcRXec=
X-Received: by 2002:a1f:60ce:: with SMTP id u197mr3035129vkb.80.1573824690951;
Fri, 15 Nov 2019 05:31:30 -0800 (PST)
X-Google-Smtp-Source: APXvYqxeLjWyYKF5XNe9KtmzAxwVZonKWD4ep76P+C4tWx6v0XND3+mfiHHPNw2SbIWkR1Wbu57CkYRvUhutBcDHrms=
X-Received: by 2002:a1f:60ce:: with SMTP id u197mr3035095vkb.80.1573824690433;
Fri, 15 Nov 2019 05:31:30 -0800 (PST)
MIME-Version: 1.0
References: <1573643008-8216-1-git-send-email-wangzk320@163.com>
<36d4ff71-bce4-6b69-7110-c4f6b9bfa51d@redhat.com> <20191115041520.GA22736@___>
In-Reply-To: <20191115041520.GA22736@___>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 15 Nov 2019 14:31:19 +0100
Message-ID: <CAJFAV8wD5fyK7V_x4Tf-mMnwjHCQS009ZjTKyUPN1LRR5NJKnA@mail.gmail.com>
To: Zhike Wang <wangzk320@163.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>, security@dpdk.org, wangzhike@jd.com,
Tiwei Bie <tiwei.bie@intel.com>
X-MC-Unique: lw0L8r0tPzW5dOf6EieRGQ-1
X-Mimecast-Spam-Score: 0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix vring message
handling broken in some case
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Nov 15, 2019 at 5:14 AM Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> On Thu, Nov 14, 2019 at 09:52:30AM +0100, Maxime Coquelin wrote:
> > Maybe change the title to something like:
> >
> > vhost: fix vring requests validation broken if no FD in payload
For the title, aligning to backport patches:
"vhost: fix vring requests validation broken if no FD"
> >
> > On 11/13/19 12:03 PM, Zhike Wang wrote:
> > > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0,
> > > so validate_msg_fds() will return error. In this case,
> > > the negotiation of vring message between vhost user front end and
> > > back end would fail, and as a result, vhost user link could NOT be up=
.
> > >
> > > How to reproduce:
> > > 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk.
> > > 2.Notice that inside ovs there are endless logs regarding failure to
> > > handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up.
> > >
> > > Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs=
")
Fixes: bf472259dde6 ("vhost: fix possible denial of service by leaking FDs"=
)
Cc: stable@dpdk.org
> > > Signed-off-by: Zhike Wang <wangzk320@163.com>
> > > ---
> > > lib/librte_vhost/vhost_user.c | 13 ++++++++++---
> > > 1 file changed, 10 insertions(+), 3 deletions(-)
> > >
> >
> > otherwise:
> >
> > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >
> > The title can be changed while applying if you agree with it, no need t=
o
> > send v3.
> >
> > I'll take care of the different backports.
> >
>
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Applied, thanks.
--=20
David Marchand