From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87FA2A0093; Tue, 23 Aug 2022 10:41:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BD4A4114B; Tue, 23 Aug 2022 10:41:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8A139400D6 for ; Tue, 23 Aug 2022 10:41:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661244116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eReKgYZ3GHA6uY9ZUbZQQXtVn8ebln214l26JTgPPX8=; b=HxT9avr+NSHok/dgF3bYKzwItX3/sanHqBSAn7biIpCrGiY+RfxVL2JOxQKAVYCy/nEqkb fC9XStzuxyxZHhLNO3Bx3gLmYPrr24Tqg17edtB8K3NeDOnqW+FnUu2DLqFg/2iivyBwym j7avMtK/MsGqlZ4HplHcc+6qOzHdvYA= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-647-GcPT1O29MRybZBUFQboYZQ-1; Tue, 23 Aug 2022 04:41:54 -0400 X-MC-Unique: GcPT1O29MRybZBUFQboYZQ-1 Received: by mail-lf1-f69.google.com with SMTP id y3-20020a197503000000b00492f3a13baeso687402lfe.12 for ; Tue, 23 Aug 2022 01:41:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=eReKgYZ3GHA6uY9ZUbZQQXtVn8ebln214l26JTgPPX8=; b=oCmw1Topgp4ifV2K3hghebxRgtvRfO8O4Ot5Jo3rii0nFL3RxXl+csVzI22XNe3OtE z6nIhdSD1z+uMYQfRYYyF/4wutGU2nXuLrW0DPCvNnaB+k04yeyLc48MACX4OBj39Gmu cHNOUqgngKL0iDwQAu72Hy4MmYGyzuIledhLJ58qv2YnlFzl//xVvciF+h6tMRCvT++/ npkQ9MdlgGnSqCOH/lj/N+gEFGRXUWBqb4owbawtlt9ZBjN6w5+jx91Vws0cJcImAuUY nuNvr/+mOt+SyeANlLqB7JoDwklWQxHhuO0Ev2aKuxJaTvNrTCZSJ/4Y7bEhrcWKRpqW ab3A== X-Gm-Message-State: ACgBeo3qzsZCYNRToxwhQYldmLX9I/NwPNgSG+1c0UHKDQmIkGu1byL4 Jd7YvXLAb4DP8yGYOPbqGa10C1R5hPbbXI7s7Jx0PWL195TpNZ1fze+Z9OpRtcewpGZC1YkQ4LJ Xyvnl4pWcGKxHZVc2R5A= X-Received: by 2002:a05:651c:a12:b0:261:d3bd:51c with SMTP id k18-20020a05651c0a1200b00261d3bd051cmr1338974ljq.55.1661244113038; Tue, 23 Aug 2022 01:41:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR7yOkv4U63I8wrxmy/FFyHEiqBXUG8inz8aT2QIjpssvJR/UO2tXVmg8cfbFK24N3wCSX+Ncf3MymcZkI8+CTs= X-Received: by 2002:a05:651c:a12:b0:261:d3bd:51c with SMTP id k18-20020a05651c0a1200b00261d3bd051cmr1338970ljq.55.1661244112839; Tue, 23 Aug 2022 01:41:52 -0700 (PDT) MIME-Version: 1.0 References: <20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru> <20220804190602.1045171-7-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20220804190602.1045171-7-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Tue, 23 Aug 2022 10:41:41 +0200 Message-ID: Subject: Re: [PATCH 06/10] ethdev: remove deprecated tunnel type defines To: Andrew Rybchenko Cc: Thomas Monjalon , Ferruh Yigit , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko wrote: > > Remove deprecated ``RTE_TUNNEL_*`` defines. Use corresponding defines > with ``RTE_ETH_TUNNEL_`` prefix instead. > > Signed-off-by: Andrew Rybchenko We have some private RTE_TUNNEL_IPTYPE_* defines. HEAD~4:lib/ethdev/ethdev_driver.h: RTE_TUNNEL_IPTYPE_IPV4 = 0, /**< IPv4 */ HEAD~4:lib/ethdev/ethdev_driver.h: RTE_TUNNEL_IPTYPE_IPV6, /**< IPv6 */ Those defines and the associated rte_tunnel_iptype type look strange to me. Do you know what this is about and if this requires a followup cleanup? -- David Marchand