From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 924B24D3A for ; Tue, 9 Apr 2019 12:34:18 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id n4so9481418vsm.3 for ; Tue, 09 Apr 2019 03:34:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nhD525bJySoNz1RFv9v2xwZ3BU/o8ydJVSF64kgTwRk=; b=jfp+FaA2TPFT1zF/SHvXvnUtIL1Kj1QTdOPo3n7PrICdvWUBoM+FMZTMskBJzPrLA8 gSNFmT+k9sh+zLTGsxuNsUZ+NOtyNDSAIPolf38yGsCa78A7Tebqxx5awPSOcXMSftey Pi0EOS7CKanj3QDFnJ8Vnmw2xyZY6i+mXpII4XNpv81vrgNTO+Ypc5YdoXu/VG3YHGln b/ZA24l/CI9nwDyIUG5n6tvEwCaA6pC7Gx21CQMFkjORz5G6xiPJmeFtiq2bnVV2qH9Q YJA+IFivgsvaB9Am4/WicG+Ej9SmLFhGtRA8AlukQ+wHyCREo86t+Zs0zOp2c3lhCK3G 9Xxw== X-Gm-Message-State: APjAAAVpWZhM81Bk4xraSrFgmw1HYeUiTQEFDhG9BBpDt4p/EQGktV3c NDVIEGiqoWRJyfqSAhpoxeBrD4K0pAi3rqIY94Ns2Q== X-Google-Smtp-Source: APXvYqywADKIFV1Z+3/AH/v0ULoIuN+v4Ui05aS3wpMJoN9dHpo/yuY3LiptSHErMoQZcrGtXzJcWoX4F1sU79TfNA8= X-Received: by 2002:a67:f588:: with SMTP id i8mr16171770vso.91.1554806057997; Tue, 09 Apr 2019 03:34:17 -0700 (PDT) MIME-Version: 1.0 References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-5-bruce.richardson@intel.com> <20190409100341.GB655@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190409100341.GB655@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Tue, 9 Apr 2019 12:34:06 +0200 Message-ID: To: Bruce Richardson Cc: dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 10:34:18 -0000 On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson wrote: > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > The definition of CPU_AND differs from Linux to BSD, so we need to > > use > > RTE_CPU_AND instead. > > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for > > PQoS CAT and CDP") > > Cc: [2]stable@dpdk.org > > > > This creates a dependency on backporting c3568ea37670 ("eal: restrict > > control threads to startup CPU affinity") which introduced the > > RTE_CPU_AND macro. > > -- > > David Marchand > > > Shall I drop the stable reference from the v2, then? > We can backport in 18.11, as I would expect c3568ea37670 to be backported. The question is more what we want to do with 17.11. We could backport only the macro bits from this patch if needed. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D2AE7A0096 for ; Tue, 9 Apr 2019 12:34:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 863344F98; Tue, 9 Apr 2019 12:34:19 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 924B24D3A for ; Tue, 9 Apr 2019 12:34:18 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id n4so9481418vsm.3 for ; Tue, 09 Apr 2019 03:34:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nhD525bJySoNz1RFv9v2xwZ3BU/o8ydJVSF64kgTwRk=; b=jfp+FaA2TPFT1zF/SHvXvnUtIL1Kj1QTdOPo3n7PrICdvWUBoM+FMZTMskBJzPrLA8 gSNFmT+k9sh+zLTGsxuNsUZ+NOtyNDSAIPolf38yGsCa78A7Tebqxx5awPSOcXMSftey Pi0EOS7CKanj3QDFnJ8Vnmw2xyZY6i+mXpII4XNpv81vrgNTO+Ypc5YdoXu/VG3YHGln b/ZA24l/CI9nwDyIUG5n6tvEwCaA6pC7Gx21CQMFkjORz5G6xiPJmeFtiq2bnVV2qH9Q YJA+IFivgsvaB9Am4/WicG+Ej9SmLFhGtRA8AlukQ+wHyCREo86t+Zs0zOp2c3lhCK3G 9Xxw== X-Gm-Message-State: APjAAAVpWZhM81Bk4xraSrFgmw1HYeUiTQEFDhG9BBpDt4p/EQGktV3c NDVIEGiqoWRJyfqSAhpoxeBrD4K0pAi3rqIY94Ns2Q== X-Google-Smtp-Source: APXvYqywADKIFV1Z+3/AH/v0ULoIuN+v4Ui05aS3wpMJoN9dHpo/yuY3LiptSHErMoQZcrGtXzJcWoX4F1sU79TfNA8= X-Received: by 2002:a67:f588:: with SMTP id i8mr16171770vso.91.1554806057997; Tue, 09 Apr 2019 03:34:17 -0700 (PDT) MIME-Version: 1.0 References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-5-bruce.richardson@intel.com> <20190409100341.GB655@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190409100341.GB655@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Tue, 9 Apr 2019 12:34:06 +0200 Message-ID: To: Bruce Richardson Cc: dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409103406.eNm9U-fISTXaCVjxZFC2_M5-KYBlIDgYAV2YtAxt0A4@z> On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson wrote: > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > The definition of CPU_AND differs from Linux to BSD, so we need to > > use > > RTE_CPU_AND instead. > > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for > > PQoS CAT and CDP") > > Cc: [2]stable@dpdk.org > > > > This creates a dependency on backporting c3568ea37670 ("eal: restrict > > control threads to startup CPU affinity") which introduced the > > RTE_CPU_AND macro. > > -- > > David Marchand > > > Shall I drop the stable reference from the v2, then? > We can backport in 18.11, as I would expect c3568ea37670 to be backported. The question is more what we want to do with 17.11. We could backport only the macro bits from this patch if needed. -- David Marchand