From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA736A054F; Mon, 15 Mar 2021 17:59:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5AB7242749; Mon, 15 Mar 2021 17:59:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 4E2B6242740 for ; Mon, 15 Mar 2021 17:59:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615827573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LionXHi1+UTLKgPZbH/E0dG34grYfq5B8HTzk+gk0s0=; b=V84hx4beziWlP451fRM46+1x7/abnUtqS7yn1iZoqw8a0fVxqEUIib0I4XRoLSxouS8oHd T844g9rg1mHRhXoaaYT/lLYLaLw3IKREYlUbI6ceWeu/YctfJF4nlB9LUwpzo3rGW7T3x1 jG5XPhVYs1Qaoqg+oUK6Qg4bELM2ziA= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-QuWKtSFCNgW93f5dRkpaxg-1; Mon, 15 Mar 2021 12:59:22 -0400 X-MC-Unique: QuWKtSFCNgW93f5dRkpaxg-1 Received: by mail-vk1-f200.google.com with SMTP id b83so9274204vke.21 for ; Mon, 15 Mar 2021 09:59:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LionXHi1+UTLKgPZbH/E0dG34grYfq5B8HTzk+gk0s0=; b=oiZEqQZjs2sAx9MDWiG274f2rjMQjY9deHv28IVlDs4MZhTCy8FsYKWaAyd9+qJPJm oXjjRPTmj+dyHqkyiQu4x/iVD4rFFgUEWGXsbz5er5BgGY3CpEnp4s2W8baOXcTMni4O 5uNDxp2R8PJduVbP4uowb75ATWfQTGex6H4FcYPsgz6zAurQ7Iw2SPf3sDZ4q66doMLv 2dV0rJtgG7cJoaT71hMk7+6lZbFEkHD+lcEGJrtIfTPldwNfW4KApWGJIwESBJfB/6y4 ggRPA/jcxlIZ6JX5IYuJSV66JnyEG3vKrEY7O9oGN1jajuvEe/Vt8rfAFng3nAXJZxpQ efNQ== X-Gm-Message-State: AOAM533CSMapENkIcLz6Vzhw2/v8EVcqSB+KAiZGf9zDN7HqEoGSHIw6 OM15tOd8bsVVDcoAQaTTkvlB1NTpr1QUkWLozV4Rm139XU1VpOn4JnQrSCvnCqwFdJG4PShP+y1 7ON1tNwdXNSt7u3wNrUA= X-Received: by 2002:a67:d210:: with SMTP id y16mr15761889vsi.17.1615827561648; Mon, 15 Mar 2021 09:59:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1MjmlSiwc5wdcAEUINoWPEcV86cNO745mgLn8K7coB680SWyD2jXX1bPCtckvBNdPm3li/dULxOQVCU7AGxY= X-Received: by 2002:a67:d210:: with SMTP id y16mr15761878vsi.17.1615827561444; Mon, 15 Mar 2021 09:59:21 -0700 (PDT) MIME-Version: 1.0 References: <20210315164619.372575-1-maxime.coquelin@redhat.com> In-Reply-To: <20210315164619.372575-1-maxime.coquelin@redhat.com> From: David Marchand Date: Mon, 15 Mar 2021 17:59:10 +0100 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Adrian Moreno Zapata , Olivier Matz , bnemeth@redhat.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 0/4] net/virtio: make virtqueue struct cache-friendly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 15, 2021 at 5:46 PM Maxime Coquelin wrote: > > This series optimizes the cache usage of virtqueue struct, > by making a "fake" mbuf being dynamically allocated in Rx > virtnet struct, by removing a useless virtuque pointer > into the virtnet structs and by moving a few fields > to pack holes. > > With these 3 patches, the virtqueue struct size goes from > 576 bytes (9 cachelines) to 248 bytes (4 cachelines). > > Changes in v3: > ============== > - Use rte_zmalloc_socket for fake mbuf alloc (David) > - Fix typos in commit messages > - Remove superfluous pointer check befor freeing (David) > - Fix checkpatch warnings Once fixed patch 3, you can add for the series, Reviewed-by: David Marchand -- David Marchand