From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 236F4A0561; Mon, 20 Apr 2020 14:25:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 030671D52B; Mon, 20 Apr 2020 14:25:42 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 68BDC1C043 for ; Mon, 20 Apr 2020 14:25:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587385539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tutm1Pw1ss2o0ol7U3KDfj/exki0zuT+Pb4cP0glWRo=; b=JN3vvTxOMTTk5vCFQ8f43OddiQyI8a9hP0f2hN9+X56WOgA0meV40d6z9UKvhO1m13fRkV 4T6KxrvO7vqdNOtjod5KFby6afwUGus6WKhT9QbEK/klbsHPC3NvGXq6BoH4imswHrZPPE EDJOCfz8k7SLzJ0uGPMEmv3TiTFn9/A= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-Q8iVCT-XMSGvrLmuYtWnGw-1; Mon, 20 Apr 2020 08:24:04 -0400 X-MC-Unique: Q8iVCT-XMSGvrLmuYtWnGw-1 Received: by mail-vk1-f198.google.com with SMTP id m76so3697709vke.4 for ; Mon, 20 Apr 2020 05:24:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cD+7g4fhJ1Ny1fHty/XTbMRoHEfXKchhK8HwmRB+i+M=; b=VY2BTCxlq8NpF9FjdvliElA44Dq2EmqTlgyAoQdbOdrlxQwjzOj1436T384JYlxur5 PEtVBX4lPmGkKdERxeg7N1Pu5wmV1zyU5MI6NnOBVzPw69+ddnMOfq+AoFqUQMR2YMdI OLedEWnXZNf9wDatF8FaezKxNt6OU2qZi1iUH5UIq+L3EMvd16MhRQZImdIek97EfjI+ Ps5BxEE935EVv5xnUX09sGhGWPJJpFDdD7ursHYQxe4yZA39ccEByJ9HSwoNZ58/Y+Zp 8kz5HcXAB4Q+CBgLYiuwbOEJ727MwzsjEtyR+Ep+mfaX57qcM0p2kOuockpFm5sxB9rT X0kA== X-Gm-Message-State: AGi0PuaaHv6n+vGiUmhtsSSh4qGnNxzq9rRF/ds8ZInoGlgPtviMdaqw SOb8ftAFUCJFFQYWnnyc5tIE1b/er9lnX4y9y9HmOiGHNfnNq5BMT1vDLE9IqxaOXC7gOgESkbn an9B52VeO1NrCDyOyv5Q= X-Received: by 2002:a05:6102:1043:: with SMTP id h3mr11352384vsq.39.1587385443659; Mon, 20 Apr 2020 05:24:03 -0700 (PDT) X-Google-Smtp-Source: APiQypKMScb4qOeKV3+NZwFMpfwIi+4PTqmbGsCDcA/uqVTZqrUVyWS/bpY13bqVIrZGvgoyxeO1g+q92b9JPUegfk0= X-Received: by 2002:a05:6102:1043:: with SMTP id h3mr11352368vsq.39.1587385443356; Mon, 20 Apr 2020 05:24:03 -0700 (PDT) MIME-Version: 1.0 References: <20200420062638.80181-1-ajit.khaparde@broadcom.com> <7e558b9b-c5e6-d276-0ae3-55b966c8cc26@intel.com> In-Reply-To: <7e558b9b-c5e6-d276-0ae3-55b966c8cc26@intel.com> From: David Marchand Date: Mon, 20 Apr 2020 14:23:51 +0200 Message-ID: To: Ferruh Yigit Cc: Ajit Khaparde , dev , Raslan Darawsheh , Lance Richardson , Somnath Kotur X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix CLANG compilation error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 20, 2020 at 2:22 PM Ferruh Yigit wrote= : > On 4/20/2020 8:14 AM, David Marchand wrote: > > On Mon, Apr 20, 2020 at 8:28 AM Ajit Khaparde > > wrote: > >> > >> Fix a compilation error seen with CLANG. > >> The current code causes a typedef redefinition error because > >> 'p__LINE__' is a C11 feature. Fixing it by defining it to something > >> which is not already defined in the language. > > > > Can't you reuse the RTE_BUILD_BUG_ON macro instead of redefining this > > in your driver? > > If the EAL macro is not enough, I suppose we could improve it. > > > > Will squash it on next-net to fix the build error. +1 to using > 'RTE_BUILD_BUG_ON' comment if it possible but it can be done as increment= al patch. Ack. --=20 David Marchand