From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com
 [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 8F1D44C9C
 for <dev@dpdk.org>; Thu, 20 Dec 2018 13:55:18 +0100 (CET)
Received: by mail-vs1-f66.google.com with SMTP id x64so989131vsa.5
 for <dev@dpdk.org>; Thu, 20 Dec 2018 04:55:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=4f0XVJd5+U2Lh0FJuLi2UZRdCIW5jNgmZ2rNpwmwjds=;
 b=rUtyikAsOvPe/mdbRl3W+f+uWP98pB0ndBWIve281NaQtMGbhV2n02E40CFkYrDl4D
 We+goR/M06ErLWrWXMn8deuUOVvU9pJJIZVq0NB98+hzbWHRrlafmCVnhrVGHALmOkHD
 cB2OR/CLa0UWLHRyuK8kxvDiRhJ5ERPr1BupJULZANeLVtQNwIS8miSCa4GBOcoztrZN
 VOKX63aKMio6hVjgc5u4oLTiiOXUyIwailbl7Mi8RmakHhXCXgF2AksPF9g0v3N6hrtf
 M5FOx1pek/RIpIjBGTQmUf2vp00v3K6d8ITa66/Sf9H3kRuQTzMpJeQsRR2g6z0bpWH4
 OYdA==
X-Gm-Message-State: AA+aEWYP9kuYchqqvMOFCJtwr/oEVWQG50HlIYuPrW8rSzxmbU4JsB5u
 Df/kQs4KLu9mUQj3J9xmvO2Mihpx6zHldVvcn2ruKA==
X-Google-Smtp-Source: AFSGD/VJdJSP8X2//cJ3a1hbByyeYjh4oBLNtthNLNrEF7fmiQGiUreI2b5oWOcqotARu1hQnolgO4eERsRNqId2r3o=
X-Received: by 2002:a67:2045:: with SMTP id g66mr12346323vsg.180.1545310517999; 
 Thu, 20 Dec 2018 04:55:17 -0800 (PST)
MIME-Version: 1.0
References: <20181220104246.5590-1-gavin.hu@arm.com>
 <20181220104246.5590-5-gavin.hu@arm.com>
 <CAJFAV8yh5VRn38Dnrm=eKm6j_wS_zAJX0kyV5_Z+zCO1NtCj+A@mail.gmail.com>
In-Reply-To: <CAJFAV8yh5VRn38Dnrm=eKm6j_wS_zAJX0kyV5_Z+zCO1NtCj+A@mail.gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 20 Dec 2018 13:55:07 +0100
Message-ID: <CAJFAV8wEx=sWdG6LHY_06iL6SotTp3x5Cg8FfUr=BUVv3tmEnw@mail.gmail.com>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, jerinj@marvell.com, 
 hemant.agrawal@nxp.com, bruce.richardson@intel.com, 
 chaozhu@linux.vnet.ibm.com, nd@arm.com, Honnappa.Nagarahalli@arm.com
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to
 arm specific file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 12:55:18 -0000

On Thu, Dec 20, 2018 at 1:47 PM David Marchand <david.marchand@redhat.com>
wrote:

> On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu <gavin.hu@arm.com> wrote:
>
>> remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the implementation
>> to the arm specific file, x86 and POWER have their own implementations.
>>
>
> No, x86 and ppc define their own implementation when _not_ having
> RTE_FORCE_INTRINSICS.
>

Actually, I wondered in the past if we realled needed those double
implementations...
Is there really a point in maintaining both ? I am pretty sure people only
use the default configuration per architecture.


-- 
David Marchand