From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39A1FA0487 for ; Thu, 4 Jul 2019 12:52:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE7861BE08; Thu, 4 Jul 2019 12:52:17 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 6F6331BDFA for ; Thu, 4 Jul 2019 12:52:16 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id m23so1705288vso.1 for ; Thu, 04 Jul 2019 03:52:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8PHkF33HFUx9uk7/KjImxAUbpKXZ42YmnWw/bti5bdM=; b=aB8hGMYEPehkudhyhd5WSz3j4IUo3LG9RvAR4oEo5i1LnZNM+YjBiIfc/e8J1uQ6An OhjuAjZvYTWKBn9ZOtTu6EXW88XOiq2M98p0GqQ6T1Eo4BVvQsjtcxF2pUS5zyaoeyo0 6OU5c5V9jioDamwbKEVAKY5iYocthpEHy0Odf7nC2YxdpxlckIIHW6nRQ6mUrFARKRkW ou8MIWggragZgMbWOBorePzLKoA8D+MoR1xlWwMoaz7zElRpfNCZ8m7j+NM2F5enTPzg 2iVaOe6wiURATOHvUmiR8Ej5TuqPlsR70t7mHGcZNFQ9870apAY36ByT5KeqV8SR2YgS TwCw== X-Gm-Message-State: APjAAAUqRG3+qlR1Yipq7VhDxnDfLgpynlqGF/Qb7whv12RvYGXh3xZr rYWPzIu8VHlb23SLY1bFqhARgGohkAXethZFOimxkA== X-Google-Smtp-Source: APXvYqyAQNzHUD4tqBKZG5HTOtnbwAngXUPVNGO/9qRmVaL7NM3G0qJ0CJb4XmndJKU66gY1Tv/fjAFhZi75DFHTtDQ= X-Received: by 2002:a67:f998:: with SMTP id b24mr21665915vsq.180.1562237535795; Thu, 04 Jul 2019 03:52:15 -0700 (PDT) MIME-Version: 1.0 References: <0e63b2e2abe185b711737a7102f6d6cd03101cab.1561635481.git.anatoly.burakov@intel.com> In-Reply-To: From: David Marchand Date: Thu, 4 Jul 2019 12:52:04 +0200 Message-ID: To: "Burakov, Anatoly" Cc: dev , Neil Horman , John McNamara , Marko Kovacevic , Konstantin Ananyev , David Hunt , Bruce Richardson , Byron Marohn , Pablo de Lara Guarch , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Olivier Matz , Andrew Rybchenko , Reshma Pattan , Thomas Monjalon , Stephen Hemminger Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 09/14] eal: hide shared memory config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 4, 2019 at 12:47 PM Burakov, Anatoly wrote: > On 04-Jul-19 8:43 AM, David Marchand wrote: > > On Thu, Jun 27, 2019 at 1:39 PM Anatoly Burakov < > anatoly.burakov@intel.com> > > wrote: > > > >> diff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h > >> b/lib/librte_eal/common/include/rte_eal_memconfig.h > >> index 58dcbb96d..1b615c892 100644 > >> --- a/lib/librte_eal/common/include/rte_eal_memconfig.h > >> +++ b/lib/librte_eal/common/include/rte_eal_memconfig.h > >> @@ -5,13 +5,12 @@ > >> #ifndef _RTE_EAL_MEMCONFIG_H_ > >> #define _RTE_EAL_MEMCONFIG_H_ > >> > >> -#include > >> -#include > >> -#include > >> -#include > >> -#include > >> -#include > >> -#include > >> +/** > >> + * @file > >> + * > >> + * This API allows access to EAL shared memory configuration through an > >> API. > >> + */ > >> + > >> #include > >> > >> #ifdef __cplusplus > >> @@ -38,68 +37,6 @@ struct rte_memseg_list { > >> struct rte_fbarray memseg_arr; > >> }; > >> > >> > > You left the rte_memseg_list definition here and the inclusion of > > rte_fbarray.h. > > Is this intentional? > > Yes, it is intentional. I can move them to rte_memory, but they have to > be externally visible. > It makes more sense in rte_memory.h yes. But I tried to do this, and hit compilation issues with conflicts on bool type in base drivers... Anyway, this could be a cleanup later. -- David Marchand