From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 405BC43C60; Wed, 6 Mar 2024 21:49:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 631F442E94; Wed, 6 Mar 2024 21:49:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1DD2A42DC3 for ; Wed, 6 Mar 2024 21:49:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709758186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WSRZI2vJrpYmbKBPGxrfczFQTLrEsvri3pTONSjO6mw=; b=ViKdAlg9MXbG8dxKVo0acFYeYKt+wmXb4njgVy1Xo703g2KjTXPAZ7ktvRNIxMKAGtGc3z mlMGHFK0PE0Bev3OW6ye2ZFX81YUZHViyCBuaCJgFxlEGjbjiRGjQNUPSVsKESCjIDckwC Ty1tay8O/NrcgkvGC6PQ3QjQHUrXMxo= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-w3wqQITKODiEuOJ7CnmPqQ-1; Wed, 06 Mar 2024 15:49:45 -0500 X-MC-Unique: w3wqQITKODiEuOJ7CnmPqQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5134251ef6eso90393e87.2 for ; Wed, 06 Mar 2024 12:49:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709758184; x=1710362984; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WSRZI2vJrpYmbKBPGxrfczFQTLrEsvri3pTONSjO6mw=; b=AmsDeSlOZZZPVozinzmeWhP0B0aMH1KAbXbXTKvVs2NICJmJ9HLJl6WyHZMUk3VMTN sjQQVBU0J9zlhULKRvXfOw6quVnJ6SmGllx+lJzRD2Q9cCXJ1FVlmDmotn13g2EUjwyj THsn8kaxCRtQSwsgrtpEL2wr3GKexgE0wTBwvgiQgLVsCbJ/YqaKXErwgcZfaQnnVNAP TzXA1kiuvpnfcQh4hhKJKTxkhD+kwkxSp4sm+XwYTIJcLXlxz2gkB2yKGgljaJZ7rG8v TgKQ/9epGjJwRdtlNdUyd6m9j++K+Rk6Fjl9yO51ZIeh7DxnccdsiMt03GzYOlJ1i/TG CTnQ== X-Gm-Message-State: AOJu0YyFcobWnD701d5WtkGOBWAqTRDKRGFHjP41JEd8P0srDBkQ/ofC /lgZ6Xu4Q7Zyh4wK/+MD0j0cYSnXtBUNnxGCSIDRRpHi63TJnC7KNniLYr3PLX+GXnrFpKfEM7g dNRPWUDMXGO+n9uR0SyBkxcxLzxmOyliy69fdE3AOqQ681rf+iXTJLmNEBzJvFoKYbCdKyDkdhO 6rPk4M11yo4h15Jd0= X-Received: by 2002:ac2:4249:0:b0:513:33ac:fe61 with SMTP id m9-20020ac24249000000b0051333acfe61mr143380lfl.60.1709758183918; Wed, 06 Mar 2024 12:49:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHdBvhgZNpl5Z3lZekMirce5JXO7AYrzRZrfmyEFuXLttPcEf8SZbONfA2Lz/Jw68Fil4ceOqHfXw0vivVyTQ= X-Received: by 2002:ac2:4249:0:b0:513:33ac:fe61 with SMTP id m9-20020ac24249000000b0051333acfe61mr143371lfl.60.1709758183621; Wed, 06 Mar 2024 12:49:43 -0800 (PST) MIME-Version: 1.0 References: <1709075273-6885-1-git-send-email-roretzla@linux.microsoft.com> <1709146076-22254-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1709146076-22254-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 6 Mar 2024 21:49:31 +0100 Message-ID: Subject: Re: [PATCH v2 0/3] use rte macros instead of GCC __attribute To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Honnappa Nagarahalli , Vladimir Medvedkin , mb@smartsharesystems.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 28, 2024 at 7:48=E2=80=AFPM Tyler Retzlaff wrote: > > Clean up direct uses of GCC __attribute__ in libs outside of EAL. A > checkpatch check already warns for new additions. > > v2: > * fix typo __rte_pure -> __rte_may_alias in rcu commit message > > Tyler Retzlaff (3): > eal: add rte pure attribute macro > lpm: use rte macro instead of GCC attribute > rcu: use rte macro instead of GCC attribute > > lib/eal/include/rte_common.h | 9 +++++++++ > lib/lpm/rte_lpm.c | 4 ++-- > lib/lpm/rte_lpm6.c | 2 +- > lib/rcu/rcu_qsbr_pvt.h | 2 +- > 4 files changed, 13 insertions(+), 4 deletions(-) Introducing __rte_pure and converting lib/lpm looks fine. But please finish the job for the other occurence in the tree as it is a mechanical change. Thanks. --=20 David Marchand