From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7F24A0C55; Mon, 6 Sep 2021 19:18:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8313410F0; Mon, 6 Sep 2021 19:18:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 70522410EF for ; Mon, 6 Sep 2021 19:18:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630948679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A1cXds1I/08qFpbAt1MBKAKAQHR7MYtHpPRWgaORdbo=; b=i7jVVmHptVTOPsAmHXYnx8FEaIfiltY+odffl0lN/Nt4A6KtdyN/KMltd2B4cS3oi+o8Zs 8WNV2Z79BJtOHsINeNtKkbdRM0LhbWG8ZPj5CZWiMGvoJYAo8OXykmfxIScNpyoqnruWUc bfeVSUBvc7wrAA6EsFz/GlJ8YDsZp6A= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-77-ltuz2UtBOSmgttS_Z-oM5Q-1; Mon, 06 Sep 2021 13:17:56 -0400 X-MC-Unique: ltuz2UtBOSmgttS_Z-oM5Q-1 Received: by mail-lj1-f199.google.com with SMTP id a38-20020a05651c212600b001ca48d59b47so3530211ljq.22 for ; Mon, 06 Sep 2021 10:17:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1cXds1I/08qFpbAt1MBKAKAQHR7MYtHpPRWgaORdbo=; b=mAUgCmwdIhLoqPqGGCE/HldCm03SafI89ZDnep9yeN/ruvjqIteHsR8AuIx+3G0oUV hS24/CWR647b1GrIKpPSHkpuvlvgd8ndSBGuxn9f3awXLTTZ0ycpc8Sww2efx/ZgwBzp mFS9f35LtKO6f/eqpqInEHbpvHhDVfZJUfiOTg8hRGEM65vLZwBN+65P3pWv04rQnX2W 7K7QVHYTYmPe2vHOpLW9G3up/tqMYH/6MkcmuaHw5AyL3ExBMDFJX/ugx8Zp3uBTloJm NL9M8FJZAWsRBaJbLatcXo6MnTDlAYTc1GmCpNCkdrnAwK/UwIxj8aS63J6GQ6DySXxx jk8Q== X-Gm-Message-State: AOAM532HeXkCmsyfeWfoghRv8peZp1dW2EdEOMIRYEq+GatB1p1YN677 TmEzoSZxR/fQ9utWKRnuPfif9hGalIwcNpV+MazgDY9ut8V2MEkYajT9kaadcK5Xbhf6/bphU7s LCKgERUSq2shptpHPuZU= X-Received: by 2002:a05:6512:368e:: with SMTP id d14mr2977289lfs.217.1630948675194; Mon, 06 Sep 2021 10:17:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuw7t17+JnpawYw2CCMW+L3VDkoN/qT/f1eH3wYOb6AQCMEE2OjgW0WAnKpaDLLmXYo3Nu/eFoNr9moCPRtsI= X-Received: by 2002:a05:6512:368e:: with SMTP id d14mr2977274lfs.217.1630948674956; Mon, 06 Sep 2021 10:17:54 -0700 (PDT) MIME-Version: 1.0 References: <20210906165556.65015-1-selwin.sebastian@amd.com> In-Reply-To: <20210906165556.65015-1-selwin.sebastian@amd.com> From: David Marchand Date: Mon, 6 Sep 2021 19:17:43 +0200 Message-ID: To: Selwin Sebastian Cc: dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC PATCH v2] raw/ptdma: introduce ptdma driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 6, 2021 at 6:56 PM Selwin Sebastian wrote: > > Add support for PTDMA driver - This description is rather short. Can this new driver be implemented as a dmadev? See (current revision): https://patchwork.dpdk.org/project/dpdk/list/?series=18677&state=%2A&archive=both - In any case, quick comments on this patch: Please update release notes. vfio-pci should be preferred over igb_uio. Please check indent in meson. ABI version is incorrect in version.map. RTE_LOG_REGISTER_DEFAULT should be preferred. The patch is monolithic, could it be split per functionnality to ease review? Copy relevant maintainers and/or (sub-)tree maintainers to make them aware of this work, and get those patches reviewed. Please submit new revisions of patchsets with increased revision number in title + changelog that helps track what changed between revisions. Some of those points are described in: https://doc.dpdk.org/guides/contributing/patches.html Thanks. -- David Marchand