From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7C25A0487 for ; Wed, 3 Jul 2019 11:38:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C04AC1B95C; Wed, 3 Jul 2019 11:38:17 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 71A961B94E for ; Wed, 3 Jul 2019 11:38:14 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id s7so3163124iob.11 for ; Wed, 03 Jul 2019 02:38:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iBjCHcXLMstssmX1FSU0KwLvrAg7bCOPbF6cE2NSmSw=; b=VqFwa2zlr0z9auizhE39htpqe2J9bsvAqdBP2arxEOs3dASBMIU8eW9RmU6qgUZtV3 xHRssPVMQvukxbRmAUtaYAK8eotGceKmpuzOhoDCIwKxIHbOBLXcbjnelB5TahEhmitn y6fiqKDP5yFPGUDjzTZUWZm2hLgu3spNtV71HHp9DCTkFeiicopFep7JELTY7XXuDxOY 60n7bAH6yek9v1zVaT49K/a873/CaKcx0iYeXOlnChbQJdNeVIo3brBe2Krra4We1xvk 5GF6J48/PzevVGge1IWmj6rGzkNAVQBohK6gnXj819fEdoV2BA6AFpC/XXcnLgMBEEp5 UsaA== X-Gm-Message-State: APjAAAUpYfe5Xs03X+kfcLf0Rwj4q5sHml5b6OnR0vM3nd4fvYePwXd7 5Pj9kgHZNJUvmOU+dxDqL+/xmItsPh2C9gptXlZddxXHVqQ= X-Google-Smtp-Source: APXvYqyk9dHzEbuycnEFXpsqAnKijbFe5dogOsv6nd9DRHDfRrjNsrXU6O1McMj3IcCwNhXpDFgEcClk87rE1SdIH5I= X-Received: by 2002:a05:6638:cf:: with SMTP id w15mr41988531jao.136.1562146693826; Wed, 03 Jul 2019 02:38:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 3 Jul 2019 11:38:02 +0200 Message-ID: To: Anatoly Burakov Cc: dev , Thomas Monjalon , Stephen Hemminger Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Anatoly, On Thu, Jun 27, 2019 at 1:39 PM Anatoly Burakov wrote: > This patchset removes the shared memory config from public > API, and replaces all usages of said config with new API > calls. > > A lot of the patchset is a search-and-replace job and should > be pretty easy to review. The rest are pretty trivial EAL > changes. > > This patchset depends on FreeBSD fixes patchset: > > http://patches.dpdk.org/project/dpdk/list/?series=5196 > > v3: > - Rebase on top of latest master > > v2: > - Collapsed all changes into fewer patches > - Addressed review comments > - Created a new file to store the code > - Changed namespace to "rte_mcfg_" > - Added some unification around config init > - Removed "packed" attribute from mem config > - Removed unnecessary inlining > - Added a check to explicitly forbid running multiprocess > applications that differ in their DPDK versions > For the parts I already had a look at, I still think the changes are in too many patches. A lot of this is just search/replace we can have it with the patch that introduces it. - patch 1, 2 and 3 could be squashed as a single one (plus removing the unused macro from patch 8) - idem with patch 4 and 5 - idem with patch 6 and 7 (plus removing the unused macro from patch 8) I will look at the rest tomorrow (hopefully). -- David Marchand