From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C827B45A11; Mon, 23 Sep 2024 17:43:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BFBE4027C; Mon, 23 Sep 2024 17:43:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8D41F40274 for ; Mon, 23 Sep 2024 17:43:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727106186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B15U6c7KQR5kS3DdeUkDy3Tj5hp9EYbT0eYlpf8kX30=; b=UKVzbqXEIBHAkyWwljbN7oGy1VmRZqFycS9bezD5fjP860qW7RefLQn5fT7ErxBYoQ/m1S mVxuuMF8bRpUazGk+Np5JOO31thWCKhle3rWuFhYAAyR8k46QW5c0vdkxGvUmTCri++/LB gznHGCOTIcS069yMDnFWgPWeKbdZtIM= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-AXeCTqypOYiRmCMPlSdFpA-1; Mon, 23 Sep 2024 11:43:05 -0400 X-MC-Unique: AXeCTqypOYiRmCMPlSdFpA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5365fd3fab3so3618988e87.2 for ; Mon, 23 Sep 2024 08:43:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727106182; x=1727710982; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B15U6c7KQR5kS3DdeUkDy3Tj5hp9EYbT0eYlpf8kX30=; b=HTGJuful0ywVaZI+CpLOys8RtogVahW01lWlof2hNYE6zCKbiofz6V3bQpFF8lsgv8 OmAbn7v2oi9Jo8MePiwpA6YFyfTNAL9UfDAPaKTSsuuH9HlcDGs4qW9/xCQa+ERYfuHD McUGVjWUu+oT2295VEj+HjNRrYyIFyFbpycyPtLkvUhiDK/OuMDRz932kV9ku3vxDyuN h/PWVrlyEmj+G/9YeI/FYqMNxxzH/O0DPYRvZf7XXSh3gGrXa/jKE2uPVf5fZXHVeBay SrTOUHp1Vl1xhG5H2O/u1aC5prctKwRdUwQaujfyvwY4HbZlGCUjB3uJ07sztnY0z7dk 7f3g== X-Gm-Message-State: AOJu0YzUXz9fOlEW8JLr3Pz6tN43GLrNHi1FD/X8Frrad2fxQ+ix/PeV 8TlzPYTjoTw/eXF91hT7WXgNAWXFa/jAuHrSrdWYVmrC0FnhnXvmYcIZ9GTlK9y3Xpazuk3njKH 5pYMdU/awhdTtylWDt5/y8Q1uVETZTgx1CbeakuUK4Yt+GQnu/QxHhlyP3nv3zIhHKBpMpuiEfk mNYDq+9s66+ayjCYk= X-Received: by 2002:a05:6512:2807:b0:52e:9f6b:64 with SMTP id 2adb3069b0e04-536ad18207emr5317712e87.34.1727106182434; Mon, 23 Sep 2024 08:43:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLsKNBqyUkrbDwepa8n/XUgu7TFvVP/7l2JHEXUwFCqb8UvGszS11C1Qnk3LQmSuWT/9zKNGJgnRA7aCAckEw= X-Received: by 2002:a05:6512:2807:b0:52e:9f6b:64 with SMTP id 2adb3069b0e04-536ad18207emr5317692e87.34.1727106182053; Mon, 23 Sep 2024 08:43:02 -0700 (PDT) MIME-Version: 1.0 References: <20240920150921.994434-1-maxime.coquelin@redhat.com> <20240920150921.994434-2-maxime.coquelin@redhat.com> In-Reply-To: <20240920150921.994434-2-maxime.coquelin@redhat.com> From: David Marchand Date: Mon, 23 Sep 2024 11:42:49 -0400 Message-ID: Subject: Re: [PATCH v2 1/2] vhost: add logging mechanism for reconnection To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 20, 2024 at 11:09=E2=80=AFAM Maxime Coquelin wrote: > > This patch introduces a way for backend to keep track > of the needed information to be able to reconnect without > frontend cooperation. > > It will be used for VDUSE, which does not provide interface > for the backend to save and later recover local virtqueues > metadata needed to reconnect. > > Vhost-user support could also be added for improved packed > ring reconnection support. > > Signed-off-by: Maxime Coquelin vq->last_avail_idx gets updated in other places and I suspect we are missing some calls to vhost_virtqueue_reconnect_log_split/packed. I spotted: - lib/vhost/vhost.c: rte_vhost_set_vring_base() - lib/vhost/vhost_user.c: translate_ring_addresses(), vhost_user_set_vring_base(). The rest lgtm. --=20 David Marchand