From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B31CA00C4; Fri, 30 Sep 2022 16:21:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1695B410FA; Fri, 30 Sep 2022 16:21:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 758BD40684 for ; Fri, 30 Sep 2022 16:20:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664547658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9X63RkdcGN2mIWBDqOMBmdXr1npUGy2JFehOzyo7OZ0=; b=JGTNGw2XKuuIjJx1HlS+VilZQ3izmJh4VrOLfEzc0wxbBS8Kvjg9fddJ4ZVme7amjK0uok vTkvJmewa4SsG08kRtpoe2HEtU6cEkLdd3jsMonxSPOehS/CPCROEndTjeFrCECYGCdKVW J1JOXJBrgvbFgJz15uEOXmbsID7J1yI= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-661-DXk5IBMVNa2ADB_Ao1DUtA-1; Fri, 30 Sep 2022 10:20:56 -0400 X-MC-Unique: DXk5IBMVNa2ADB_Ao1DUtA-1 Received: by mail-pg1-f200.google.com with SMTP id l72-20020a63914b000000b00434ac6f8214so2955594pge.13 for ; Fri, 30 Sep 2022 07:20:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=9X63RkdcGN2mIWBDqOMBmdXr1npUGy2JFehOzyo7OZ0=; b=a/PtL3O2B/pAM9oYZD33eM0X1OK+Qujx20CmUNZ87d2cBN3QzCKxWn7GuBV5ZfYw4q prw1XzHdPrWanwDX6EkTBYTtOXP1+WwKlP0+stXHcjPPTu/Ssv+w+hN52PVsUDbKdlKy 0m4G3h9c8Pc0BbLf2YKwbSzvd1qPL9pSO3150jx1FOh87HPe85tFNxZDwPOWeNDBhYnn F8oylgXxGu3AtJdZHQbpoU17T5tFm2uRg9Q+RXawewhI1hHJt/2+83eVfandwiPUwekN aOKl3VrvcPvxoaxRElUwj/TX17/u1MQPo1bDG9s2LIFsqFPNWWLjSWhMz7/In9B8FQlO ZSZw== X-Gm-Message-State: ACrzQf3+gzT8Z9dmZ/beksoW9yGHbZ8QsbZmUY7zcIf4iW4lpYppEKK7 551jcaAq394ryUGBaT/aTq4tUyX/eRFl9amBf722Yw+b0DMeABE/Lx8KtjX7VONIqnAC7JKV8Cy K9jGtewiQPLtLPsZiuw8= X-Received: by 2002:a17:903:2302:b0:178:286c:86a8 with SMTP id d2-20020a170903230200b00178286c86a8mr8765716plh.172.1664547655266; Fri, 30 Sep 2022 07:20:55 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6+4r8YBhcsNR36u0W+kbXHxEunH72Ka0CeFi2kmyMTGUWZoIUuDMFIjDGQvgjczwMYlFlN6HIhsKDPK9WOGB8= X-Received: by 2002:a17:903:2302:b0:178:286c:86a8 with SMTP id d2-20020a170903230200b00178286c86a8mr8765679plh.172.1664547654927; Fri, 30 Sep 2022 07:20:54 -0700 (PDT) MIME-Version: 1.0 References: <20220930080228.864681-1-zhoumin@loongson.cn> <3219c10e-79fa-39df-30f5-c2287fd1872b@loongson.cn> In-Reply-To: <3219c10e-79fa-39df-30f5-c2287fd1872b@loongson.cn> From: David Marchand Date: Fri, 30 Sep 2022 16:20:43 +0200 Message-ID: Subject: Re: [PATCH v7 0/7] Introduce support for LoongArch architecture To: zhoumin Cc: thomas@monjalon.net, bruce.richardson@intel.com, anatoly.burakov@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, jgrajcia@cisco.com, konstantin.v.ananyev@yandex.ru, dev@dpdk.org, maobibo@loongson.cn, Aaron Conole , Ali Alnubani , dpdklab , ci@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 30, 2022 at 12:05 PM zhoumin wrote: > On Fri, Sep 30, 2022 at 16:13, David Marchand wrote: > > On Fri, Sep 30, 2022 at 10:02 AM Min Zhou wrote: > >> > >> The online documents of LoongArch architecture are here: > >> https://loongson.github.io/LoongArch-Documentation/README-EN.html > >> > >> The latest build tools for LoongArch (binary) can be downloaded from: > >> https://github.com/loongson/build-tools > > Could you confirm which sources have been used to generate it? and > > instructions to compile it? > > Only the cross compiler [1] is required. The instructions can be found in > the new added file cross_build_dpdk_for_loongarch.rst. I had added the > CI job for cross compiling DPDK for LoongArch in patch v7 7/7. The CI job > can run successfully if without the GCC warning caused by vhost. - Sorry, but those instructions are not useful. Is this architecture support in upstream gcc not functional? Maybe I missed the information.. I spent some time at the different links in the docs and in github, but I always end up with a set of headers, or binaries, and no reference to the exact sources that were used. I have limited trust in binaries uploaded somewhere in github. I don't want to spend more time on this. What I ask for, is clear instructions how to get the toolchain sources, and how to generate this toolchain. - About the vhost compilation issue, a fix in the same area of the code is in progress. It will take some time to get the fix. I will postpone merging the last patch until the vhost fix is ready. (I am rather confident all of this will be resolved by the time 22.11 is released). > > >> v7: > >> - rebase the patchset on the main repository > >> - add errno.h to rte_power_intrinsics.c according with > >> commit 72b452c5f259 > > Thanks, I will look at this last revision. > > > > > > There is still one aspect that is unclear to me. > > How will the DPDK community make sure changes won't break this > > architecture? (I mean, runtime checks, not only compilation) > > IOW, what do you plan to hook to our CI to test patches submitted to > > the mailing list? > > We can send our machine to UNH lab, but it may take a long time. > > GHA seems to be a good choice. However, I found that the codes of CI > runner of GHA [2] are arch-specific. So the CI runner currently cannot > run on > LoongArch machine. I see. The better solution is probably to go with "your" own CI so that that LoongArch has runtime non regression (functional and performance) tests. See below. > > Are there other CI clients which are not arch-specific and can be used > for DPDK? > We can provide machines accessible by the public network. These machines run > Loongnix-server system which was built based on the source rpms of CentOS 8. > We can deploy DPDK CI client on these machines. There is no "DPDK CI client" per se. The DPDK project has a distributed CI made of at least 3 CI entities. Those CI test patches and post reports via mail: the ovsrobot, Intel CI and UNH lab. A CI retrieves patches from patchwork, a set of scripts is available in https://git.dpdk.org/tools/dpdk-ci/ (especially the poll-pw script). Then the way the patches are tested is something each CI handles on its side: - the ovsrobot creates a branch per series under the ovsrobot/dpdk github repository, and let GitHub action run (this is how your current series has been tested in GHA), - Intel CI have their own tool for which I have little detail, - UNH lab have their infrastructure too, using some Jenkins iirc. They provide a dashboard for reports https://lab.dpdk.org/results/dashboard/ and to get all details and logs. The common point is that, at the end of testing a series, a test report is sent to the (sender-restricted) test-report@ mailing list. Those reports could be done per patch, but given the amount of patches on the dev@ mailing list, the consensus is to test the whole series and report back against the last patch of a series. All of this is gathered by patchwork (the details of how it is done are not 100% clear to me, maybe Ali can confirm later if a modification is required). If you look at your v7 series, you will see: https://patchwork.dpdk.org/project/dpdk/list/?series=24929&state=%2A&archive=both - ovsrobot: ci/github-robot link http://mails.dpdk.org/archives/test-report/2022-September/310836.html - Intel CI: ci/Intel-* links, for example on the compilation test http://mails.dpdk.org/archives/test-report/2022-September/310822.html - UNH lab: all ci/iol-* links, for example on the compilation test http://mails.dpdk.org/archives/test-report/2022-September/310834.html So what LoongSoon could do is setup some Loongnix systems with a similar infrastructure and provide (native?) compilation and runtime test reports. I Cc'd a few people involved in all this. And there is the ci@ mailing list where all CI people can discuss. -- David Marchand