From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EAF945AAC; Fri, 4 Oct 2024 11:54:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 731C24027F; Fri, 4 Oct 2024 11:54:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E1F4040268 for ; Fri, 4 Oct 2024 11:54:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728035694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PDww45mbuV75s1bZQij7J4N9VVXsdLtT5LCNDIJ05+k=; b=TwZt7UWFTr1fZ52qWmm4PcHBCY/M0bZNNL3a/S2GWHh+vJAB13yzPO76GdRr+7+P6BFIVZ IDSjUrHWTDDNxFkCIa6o11gnMRn1wK7J9Zt5rrF/R/39hom6DBBxCLi67k6Hj1YB7B1Axd oYEOnboCP22rD/y5RlpynqFR21iIaoQ= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477--7Ik9YZFOxGXfz07QeneYg-1; Fri, 04 Oct 2024 05:54:52 -0400 X-MC-Unique: -7Ik9YZFOxGXfz07QeneYg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2fad9502741so19518681fa.0 for ; Fri, 04 Oct 2024 02:54:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728035690; x=1728640490; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PDww45mbuV75s1bZQij7J4N9VVXsdLtT5LCNDIJ05+k=; b=gtyLv/OKbH9HZQKU9NavyI+v40xZfY5YVpzvkKHo+OyeqGJfHgCVMp8uMkojSLjHVe YOoFubR9NEHDxdAYPxfBA2EBH9DqbTwzceBjrJK0Lmp3neuzrgCAhcF+0JURhCYYfEPM BoCjbOsQXrUreK/fOpTZb+caQRvEN2p1d2kYyQwxkWePVdRM1SpWtf7EBc4MXaqJrOfI qY6GpnhXYJr3uAKjmv9ZPjTerIStkuSCUV729as0VVFmtKwtBqGh0/HK+fyu57N3KpN8 P5OiZzNYHmEOkcLX+QNe2jMmfyeHlc0keWaYl5VYkIb9ECihpemEOD7/HVG3G89IYRPy hTYA== X-Forwarded-Encrypted: i=1; AJvYcCVCciAJTRJoYaySaia64qKFql/knMUHzOEgyo5jcGYSm3KLO1Sbty4ogvqRWzdEwWOIBeE=@dpdk.org X-Gm-Message-State: AOJu0YxjO+wk/zXAuR3DMkziFZih8jpRzsE6WpTbgxJcn9L7sEcgT3Fr 5sVI/io8qbGaSS+YDtwft56Oud7PxD9GpgS4fucy7NP/h/YkRgs9olKCW2PW7j/0BeChZfGNbN3 pNiESum/if+EzOxZ8NraHRacL8RJrZS8iPnYWmZSeudC9oSSuTTSqJ53RBgZqY3zFGCzV4uZJBN Lj+/FlN+vxsda/2ao= X-Received: by 2002:a2e:d11:0:b0:2f3:f111:9bc4 with SMTP id 38308e7fff4ca-2faf3d79202mr9346331fa.43.1728035690415; Fri, 04 Oct 2024 02:54:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmmAbdfwI80b5z2nMWd0hI5Mhg27udv9svTdEHgzu+5X6BSct6jIWTmEw7Bh8zpVOhIVVFU7hpO/Elp9q5Gxo= X-Received: by 2002:a2e:d11:0:b0:2f3:f111:9bc4 with SMTP id 38308e7fff4ca-2faf3d79202mr9346161fa.43.1728035689890; Fri, 04 Oct 2024 02:54:49 -0700 (PDT) MIME-Version: 1.0 References: <20240724075357.546248-2-mattias.ronnblom@ericsson.com> <20240920102716.738940-1-mattias.ronnblom@ericsson.com> <20240920102716.738940-6-mattias.ronnblom@ericsson.com> <8e63fd80-2ab0-4afe-94e8-ce3277338fdf@lysator.liu.se> In-Reply-To: <8e63fd80-2ab0-4afe-94e8-ce3277338fdf@lysator.liu.se> From: David Marchand Date: Fri, 4 Oct 2024 11:54:38 +0200 Message-ID: Subject: Re: [PATCH v6 5/7] eal: provide option to use compiler memcpy instead of RTE To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Stephen Hemminger , Pavan Nikhilesh , Bruce Richardson , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 4, 2024 at 11:21=E2=80=AFAM Mattias R=C3=B6nnblom wrote: > > - Now, looking at what was available for arches so far in DPDK: > > * ARM was relying by default on compiler implementation, with specific > > implementations for ARM32 and ARM64 available (see for more details > > below) =3D> possible values (default first) RTE_USE_CC_MEMCPY =3D true = / > > false > > * loongarch was relying on compiler implementation, with no specific > > implementations, =3D> RTE_USE_CC_MEMCPY =3D true > > * ppc was relying on arch specific implementation, =3D> RTE_USE_CC_MEMC= PY =3D false > > * risc was relying on compiler implementation, with no specific > > implementations, =3D> RTE_USE_CC_MEMCPY =3D true > > * x86 was relying on arch specific implementation, =3D> RTE_USE_CC_MEMC= PY =3D false > > > > We can't get a unified default value for a meson option and keep > > compat for all arches (except maybe introduce a "auto" value). > > > > Plus, disabling RTE_USE_CC_MEMCPY on loongarch and risc makes no > > sense, as there was never a specific implementation. > > > > My suggestion is to drop the meson option and instead just set > > RTE_USE_CC_MEMCPY in config/$arch/meson.build. > > Testers / interested users may edit config/$arch/meson.build on their o= wn. > > > > So we've gone from... > > "Eliminate DPDK custom per-arch memcpy altogether" > to > "Keep custom memcpy, but make cc memcpy the default" > to > "Keep custom memcpy as the default, but make cc memcpy a build option" > to > "Keep custom memcpy as the default, and have the user modify some > obscure build file to use cc memcpy" > > I seems like the natural next step is just > > "Keep the custom memcpy. Period." Well, the current implementation has holes, that I tried to list so we can move forward. About adding a meson option, we try to have as less of them as possible to reduce complexity. And this is why an obscure option is probably the best so that performance tests can be run with the compiler, without breaking existing users. If what I replied is irrelevant to others, well, I will let others review _*in* *depth*_ and Thomas can merge the series. Thanks. --=20 David Marchand