From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5709DA0546; Tue, 6 Apr 2021 18:53:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D94140F35; Tue, 6 Apr 2021 18:53:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 930FC4067C for ; Tue, 6 Apr 2021 18:53:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617728030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1v7PAer1BM4GJnBOUGYzOzsamSQaOU2fhp+n60lG1Pc=; b=e4TntUfIJPcOg7hg34RcvKn0mtfG9XS7v76mx3JbQsKSl4QJIOD2w2IJfAFcXrVegG7ml7 S/3nE9bIhMqf/iFltfk2AGdfLw58a7wZ9o+j56EZG0rfeQmuqQ1Ob/x0UNjLn5qe7Rvpub ulD0TN/f3SPA9OhDj8eML/Xu6z9AJAg= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-UPrt3INZNvudkj7YFu86QA-1; Tue, 06 Apr 2021 12:53:48 -0400 X-MC-Unique: UPrt3INZNvudkj7YFu86QA-1 Received: by mail-vs1-f71.google.com with SMTP id c20so751642vso.18 for ; Tue, 06 Apr 2021 09:53:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1v7PAer1BM4GJnBOUGYzOzsamSQaOU2fhp+n60lG1Pc=; b=PotsRmHYfn8Uw59ImUsa/CPWtRprusSeBWtKl0xCrByIYOOQy/7Ofyuar25Jk3uSds rd8RDaFMuqivkzKOvgsyqj2BWqB9BCRe7/qjZh6fvyZ/tH2SoqYsdGoGfciN5dXkKJ6n t8qbyqScl91dkYPo7+I+DYiv5LylI/pRs5QOarULUm9g9ueGhLfZnRG/Fiy/6u0oTo3T q6/gaF8W7J72/TS3u57WM9FjHzFRxIwluHtUXtM6EbxHLnOFA/AVpxT3eWqZCtQxLMh8 t71KshfR+KrpL6pWz0SsSjIXabzsKnuT4JakuQtyRvsnx5VLZG+qSY3rnkTrSPChkfYr BN5Q== X-Gm-Message-State: AOAM532cjFtDY3MCnk4e1BokSroShluZrtPgk5h3VZT0nUGGnkpnr5Un 2lTYJQSTeMqvdNW70wK7DYDxyq71uLNKLYvw9Y4MUQVM27lWww269qfgsIl+K/YaptB1JViJV27 xF1AEnF2RJKeBb1cx5Eg= X-Received: by 2002:ab0:e17:: with SMTP id g23mr10615920uak.87.1617728027998; Tue, 06 Apr 2021 09:53:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz++NdI9KCsOOCwjooz2Yqm3Q0a1N8aPo5iTbJTapTy0ge6zVsRqeD+XEVU9sPm0i7tt9tTrYWToA1oCGL6koU= X-Received: by 2002:ab0:e17:: with SMTP id g23mr10615919uak.87.1617728027831; Tue, 06 Apr 2021 09:53:47 -0700 (PDT) MIME-Version: 1.0 References: <20210406163231.19663-1-david.marchand@redhat.com> <20210406165058.GD551@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20210406165058.GD551@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Tue, 6 Apr 2021 18:53:36 +0200 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 6, 2021 at 6:51 PM Bruce Richardson wrote: > > -# special case, allow override if an def file already exists alongside map file > > - override_file = join(dirname(args[1]), basename(args[2])) > > - if exists(override_file): > > - with open(override_file) as f_in: > > - functions = f_in.readlines() > > - > > If this is removed, then drivers/common/mlx5/version.map similarly needs to > be annotated so that we can remove rte_common_mlx5_exports.def Erf, and I thought I had checked... v2 incoming. -- David Marchand