From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75389A0573; Wed, 19 Oct 2022 09:38:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65FC040A8B; Wed, 19 Oct 2022 09:38:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9080C4069C for ; Wed, 19 Oct 2022 09:38:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666165131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tgAmmFhXvr6dAgv+q7i+KLmAITXuBTEAGY7mYXp/BM=; b=JeYQapT92RiwMiN/8fx2v6oJXAs5Etv4yb2uL1Nia2Nf2NAVnfIGaOQqFj8qpncBI/zai3 eT8Gtx1fex8uW239cYoQlF25HojGoDf+A6L46pPHU8wRU/DNGwvO08xm3qWQimUAg0nfbT FETcx2wcYPJ3ID93PxsVxq6nEO7TsvI= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-424-9XnzVopuMqSc539PqSA8yA-1; Wed, 19 Oct 2022 03:38:49 -0400 X-MC-Unique: 9XnzVopuMqSc539PqSA8yA-1 Received: by mail-pl1-f199.google.com with SMTP id c10-20020a170902d48a00b001825736b382so11389290plg.15 for ; Wed, 19 Oct 2022 00:38:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7tgAmmFhXvr6dAgv+q7i+KLmAITXuBTEAGY7mYXp/BM=; b=f6F335/P8fFcGH6HiyfgYwVqGP/okRuguO0ym7lnTizyojLKZ0HC+eyy3114kRBMa1 mvZ8Dldnc7iJXYyd1hOkUzXwFzWZ7pfXRwIupIpidfn+fBQIBYH1EwW87sl++DUc85lg 1RLn8GNmEuQVtKXJvfQ380CS8s/HPHAhmCiGbATeno3UzzZDmhP/L8XK6vJy8/TSvWTT wSxl3Xzmj0dXuGg8DWxohDuy7gRfjHl6A0LkTEV5Iynl3ErEiD0fkKxZTzVMbKhtDqjX vPGNc/CouwKL8XRjUQWNc1u8rMFJkiyfgQr2qqWuyHVmO9lhXHr5sF4kkh7u/0Q3WKyK vQDw== X-Gm-Message-State: ACrzQf3lkLCM05dBs+KTCDV9RDELgXeIkeqbg2+MlBrE1ivIzmjpWahm +rWZXCwfvvU+zOWjxe/0akFBq88+E2WAM7e0KqGD2psDW2PynON5AAUNSSWGosrh6ozbtQ4AqHd D5iQDaVsqMud7p2r7aEM= X-Received: by 2002:a05:6a00:4c84:b0:562:ed08:599a with SMTP id eb4-20020a056a004c8400b00562ed08599amr7368995pfb.64.1666165127990; Wed, 19 Oct 2022 00:38:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4FkjUAO+aiH3tZABuzlFyHLV1WEv8t4DbqXs9yM4F7VP3kNABnAHs6RR/QqQheh0YMf64YQ/JEalt/0RO8lag= X-Received: by 2002:a05:6a00:4c84:b0:562:ed08:599a with SMTP id eb4-20020a056a004c8400b00562ed08599amr7368980pfb.64.1666165127725; Wed, 19 Oct 2022 00:38:47 -0700 (PDT) MIME-Version: 1.0 References: <20221013074928.3062458-1-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D87411@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87411@smartserver.smartshare.dk> From: David Marchand Date: Wed, 19 Oct 2022 09:38:36 +0200 Message-ID: Subject: Re: [PATCH] trace: take live traces via telemetry To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , bruce.richardson@intel.com Cc: dev@dpdk.org, Jerin Jacob , Sunil Kumar Kori , Ciara Power X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Morten, Bruce, On Tue, Oct 18, 2022 at 4:34 PM Morten Br=C3=B8rup wrote: > > --> /trace/list,lib.ethdev.* > > {"/trace/list": {"lib.ethdev.configure": "Disabled", > > "lib.ethdev.rxq.setup": "Disabled", > > "lib.ethdev.txq.setup": "Disabled", > > "lib.ethdev.start": "Disabled", > > "lib.ethdev.stop": "Disabled", > > "lib.ethdev.close": "Disabled", > > "lib.ethdev.rx.burst": "Disabled", > > "lib.ethdev.tx.burst": "Disabled"}} > > Jerin commented that "Disabled"/"Enabled" are a bit verbose, and suggeste= d shortening them. I forgot to handle this part (EINTR...), thanks for reminding. > It seems to me that these values are Boolean, and should be true or false= (not surrounded by quotation marks), instead of some string representing a= Boolean value. Note: This would require expanding the telemetry library wi= th a Boolean type. Indeed. > > Alternatively, use integer values 0 or 1. > > If we want to represent Boolean values as strings, I vote for "TRUE" and = "FALSE", using all upper case to indicate that they are magic strings - and= also to help avoid confusion with the JSON true/false Boolean values, whic= h are all lower case. Introducing those strings is confusing, especially if we later introduce the boolean type. I had a quick try and adding the boolean type is relatively easy (I just posted a patch, see https://patchwork.dpdk.org/project/dpdk/patch/20221019073702.3948624-1-davi= d.marchand@redhat.com/). I would either go with adding this new type (though we are past rc1, this addition is self contained and low risk), or use simple integers. --=20 David Marchand