From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78678A2EDB for ; Wed, 2 Oct 2019 09:51:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BF5E1BE0C; Wed, 2 Oct 2019 09:51:51 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 189831B94D for ; Wed, 2 Oct 2019 09:51:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570002709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kmre4I2X/sCUpXvT5sVtbdLLsSPEHZgfdu0R21rHGSU=; b=SHAJD7nES/vG+eooov1Yd0ivK8jLsKLH/9NjSkrgxJ4C7cR1x7U9FcZHLqmUTF/OwoDTUt No1qqd+6dn+4ErEf6VdBnqw7bVZlisY1rbV61bU37qIvfCzfClsU4rR4CpvQXwETb3Jkhp hW2Azj0zfNfOqpIbEHv3x/baZq5IGFM= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-HvpYnDG3P6CRam2dAcXpug-1; Wed, 02 Oct 2019 03:51:47 -0400 Received: by mail-ua1-f69.google.com with SMTP id 66so3273852uao.0 for ; Wed, 02 Oct 2019 00:51:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DY4Aq3COANlmt8xDkaBHp6fucoylqJUdlmQHH7z24eE=; b=ZQSKsadhGMHYIfgrj9N07YYysMzIqCKsJrfWtUAowQLpVfxN3VaiFlDp5FWTwJVtdM pl7s6j5wbs5PfksU2Aijg7DCwOfFa0INVdZPcD0uSZXf3h6j7UNhkGDoHPQ6keIeKUew GAz/INWN7H7lkBmfHtGj9kaxgjOu80TTyBS/nWoWV4S50jaAdJZRrJRdvRJ0XvGysriV jI3dxA3Wy0oZaBrQUB1BjdytyT4KKBouGLI3aGl4ak539Xs41xj1fHfFL1sKGtbauRSZ qSw73RvCYyK4Eq4/K6MkZAzvU25CYpGuGr/ohvnrGwXVP65uYzt+VsGXhkFZ9B4DnXSr yuow== X-Gm-Message-State: APjAAAVRtXejOXufOLqMAuEgU/D0yLIizVfeq7JitnuwGc8rxYwUqNEu Ve+SEWiUrSX9UGjnhyj1zfDzXUMd5y2pCn2SnyjkNogB7GMT1A2GM3rvYQHKtyiXE4cCJLCzH6n fQUdAt+dDHV5XkD+otX0= X-Received: by 2002:a9f:35f0:: with SMTP id u45mr1026205uad.86.1570002706981; Wed, 02 Oct 2019 00:51:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqyvYNIrziREqZHSEt6sLV5NSwzCbFO3oYsD8VNH7C7KH9hyKAaD5tuoxlZh3PLnMjmQMHy+piK8wf6ZX7jasQE= X-Received: by 2002:a9f:35f0:: with SMTP id u45mr1026191uad.86.1570002706542; Wed, 02 Oct 2019 00:51:46 -0700 (PDT) MIME-Version: 1.0 References: <59222af3-d9f1-6f92-f313-1f04402efd86@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 2 Oct 2019 09:51:35 +0200 Message-ID: To: Shahaf Shuler , Ray Kinsella Cc: "anatoly.burakov@intel.com" , Thomas Monjalon , "ferruh.yigit@intel.com" , "nhorman@tuxdriver.com" , "gaetan.rivet@6wind.com" , "dev@dpdk.org" X-MC-Unique: HvpYnDG3P6CRam2dAcXpug-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO DMA map APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 2, 2019 at 6:53 AM Shahaf Shuler wrote: > > Hi David, > > Tuesday, October 1, 2019 6:20 PM, David Marchand: > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO > > DMA map APIs > > > > Hello Shahaf, > > > > On 10/03/2019 09:28, Shahaf Shuler wrote: > > > As those should be replaced by rte_dev_dma_map and > > rte_dev_dma_unmap > > > APIs. > > > > > > Signed-off-by: Shahaf Shuler > > > --- > > > doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- > > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst > > > b/doc/guides/prog_guide/env_abstraction_layer.rst > > > index 929d76dba7..ec2fe65523 100644 > > > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > > > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > > > @@ -282,7 +282,7 @@ The expected workflow is as follows: > > > - If IOVA table is not specified, IOVA addresses will be assumed= to be > > > unavailable > > > - Other processes must attach to the memory area before they can > > > use it > > > -* Perform DMA mapping with ``rte_vfio_dma_map`` if needed > > > +* Perform DMA mapping with ``rte_dev_dma_map`` if needed > > > * Use the memory area in your application > > > * If memory area is no longer needed, it can be unregistered > > > - If the area was mapped for DMA, unmapping must be performed > > > before diff --git a/doc/guides/rel_notes/deprecation.rst > > > b/doc/guides/rel_notes/deprecation.rst > > > index 1b4fcb7e64..48ec4fee88 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -35,6 +35,10 @@ Deprecation Notices > > > > > > + ``rte_eal_devargs_type_count`` > > > > > > +* vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` > > > +APIs which > > > + have been replaced with ``rte_dev_dma_map`` and > > > +``rte_dev_dma_unmap`` > > > + functions. The due date for the removal targets DPDK 20.02. > > > + > > > * pci: Several exposed functions are misnamed. > > > The following functions are deprecated starting from v17.11 and ar= e > > replaced: > > > > > > > > > > With the ABI freeze that is going to happen in 19.11, this can't happen= in > > 20.02. > > > > What would work best from your pov? > > I have no object (even prefer) to remove them at 19.11. > At the time I sent the deprecation I was requested to provide more time f= or application to adopt. > > > > > I can't see any in-tree user of rte_vfio_dma_*map, do you know of users= of > > this api? > > There is one - VPP. They don't use DPDK memory subsystem at all, rather u= se they own allocated memory and map all, wrongly, w/ above APIs. Thanks Shahaf. I cannot see VPP involved people copied in this thread. It would have been great to involve them at the time. Ray, can you reply on this topic (replacement of rte_vfio_dma_map) ? Or could you serve as a gateway/copy the vpp guys? Thanks. -- David Marchand