From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10237A04B1; Wed, 23 Sep 2020 13:45:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE2131DABD; Wed, 23 Sep 2020 13:45:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id F1EFC1DAAF for ; Wed, 23 Sep 2020 13:45:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600861548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FtPD/QROHB/mwNVFA50EWmi4Fo+G7FStHhV7lld012Y=; b=VucbD5QcbEy9U9GwuHzBgkJ8PfBGz3O4j6B00k0eKEbfmAo1KHJxH+9D690cbGZrMHDsAm 6OLyLgeznUYS50oF/XJoPwAyI/LW2uTgtURd4Ru+xX62iZTHMkml50CgIsMP7e/W8SZUe5 K09LvqM6RYlEQ6qiY6TG5e9GTX9v580= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-71-LIVnryFkOkGitQGliv3kFQ-1; Wed, 23 Sep 2020 07:45:45 -0400 X-MC-Unique: LIVnryFkOkGitQGliv3kFQ-1 Received: by mail-vs1-f69.google.com with SMTP id j125so5932759vsc.20 for ; Wed, 23 Sep 2020 04:45:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FtPD/QROHB/mwNVFA50EWmi4Fo+G7FStHhV7lld012Y=; b=FPqmj72uwbXg9oTeKvO4ixOOw96aVgkg3Sz/MeS5kewnW/y89GaqgXh80YFjRnrzz+ LQoJWnEoI9784Cg0eKcW5vXTIBy/EI/axZs57RMiduTfNkJwCJGkyVoXTZ4+a5TarybY KNEi0BWFO6pUp5RHCgBQZmePaQv3eblAITz9cGYAUkJOJo6KDooO7wSD/y/jtBUMIgzK RHCoH6JX23Edb5UDfa5Qhs8zRpRFOL1T7HHcgVi7PEAQDhSRuaHlABKkVKnGJPJXutKM A2VaeQSJ2lRdy5Hfv2H4CGTgBL3+Q/xDYWDMDq6FSW/MByCIlhCsq7CORT7n8/L+WRG7 AgDA== X-Gm-Message-State: AOAM532o43wewW9MZx8Ybkdb0Q/vUTXQp1r5LDa2bmu6pbXjp7VMqS4E FvP8lwmNty/gGsVCwKGp/mfQkNMe9p5nvjpHISNCg95STzQoWCbDso/EjxddTRIzqiaPCZc9cRN Dt5z8ZUPK0Y1H4GktoyQ= X-Received: by 2002:a67:fd44:: with SMTP id g4mr6739218vsr.18.1600861544590; Wed, 23 Sep 2020 04:45:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyU+QGeCI/8GDib2j8LzhTbglEBarhuV3D6ZaKgAZRRQ7EPdPCzvKeAi8Oqe3GsRSQZnaynsqfNF7hPGz/nyqo= X-Received: by 2002:a67:fd44:: with SMTP id g4mr6739212vsr.18.1600861544300; Wed, 23 Sep 2020 04:45:44 -0700 (PDT) MIME-Version: 1.0 References: <20200908201830.74206-2-cristian.dumitrescu@intel.com> <20200910152645.9342-1-cristian.dumitrescu@intel.com> In-Reply-To: <20200910152645.9342-1-cristian.dumitrescu@intel.com> From: David Marchand Date: Wed, 23 Sep 2020 13:45:33 +0200 Message-ID: To: Cristian Dumitrescu Cc: dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Cristian, On Thu, Sep 10, 2020 at 5:27 PM Cristian Dumitrescu wrote: > Cristian Dumitrescu (41): > pipeline: add new SWX pipeline type > pipeline: add SWX pipeline input port > pipeline: add SWX pipeline output port > pipeline: add SWX headers and meta-data > pipeline: add SWX extern objects and funcs > pipeline: add SWX pipeline action > pipeline: add SWX pipeline tables > pipeline: add SWX pipeline instructions > pipeline: add SWX rx and extract instructions > pipeline: add SWX tx and emit instructions > pipeline: add header validate and invalidate SWX instructions > pipeline: add SWX mov instruction > pipeline: add SWX dma instruction > pipeline: introduce SWX add instruction > pipeline: introduce SWX sub instruction > pipeline: introduce SWX ckadd instruction > pipeline: introduce SWX cksub instruction > pipeline: introduce SWX and instruction > pipeline: introduce SWX or instruction > pipeline: introduce SWX xor instruction > pipeline: introduce SWX shl instruction > pipeline: introduce SWX shr instruction > pipeline: introduce SWX table instruction > pipeline: introduce SWX extern instruction > pipeline: introduce SWX jmp and return instructions > pipeline: add SWX instruction description > pipeline: add SWX instruction verifier > pipeline: add SWX instruction optimizer > pipeline: add SWX pipeline query API > pipeline: add SWX pipeline flush > pipeline: add SWX table update high level API > pipeline: add SWX pipeline specification file > port: add ethernet device SWX port > port: add source and sink SWX ports > table: add exact match SWX table > examples/pipeline: add new example application > examples/pipeline: add message passing mechanism > examples/pipeline: add configuration commands > examples/pipeline: add l2fwd example > examples/pipeline: add l2fwd with MAC swap example > examples/pipeline: add VXLAN encapsulation example - This new feature is the future of the pipeline library: it will need unit tests and/or tests in the CI to catch regressions. - Many MACRO_WITH_FLOW_CONTROL warnings reported by checkpatches. - On the patch titles, check-git-log.sh reports: Wrong headline case: "pipeline: add SWX dma instruction": dma --> DMA Wrong headline case: "pipeline: add SWX rx and extract instructions": rx --> Rx Wrong headline case: "pipeline: add SWX tx and emit instructions": tx --> Tx Wrong headline case: "pipeline: introduce SWX xor instruction": xor --> XOR - We have yet another new example, please declare it in MAINTAINERS. - I checked per patch compilation which is fine, thanks. -- David Marchand