From: David Marchand <david.marchand@redhat.com>
To: Isaac Boukris <iboukris@gmail.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org, roretzla@linux.microsoft.com,
dmitry.kozliuk@gmail.com
Subject: Re: [PATCH v5 1/2] timer: lower rounding of TSC estimation to 100KHz
Date: Tue, 8 Oct 2024 09:56:05 +0200 [thread overview]
Message-ID: <CAJFAV8wKgN+NrKZEiuEfueVt-gdT52e=+nGt9ybXOQQQrr8Ztw@mail.gmail.com> (raw)
In-Reply-To: <20241003081336.2f201beb@hermes.local>
On Thu, Oct 3, 2024 at 5:13 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Thu, 3 Oct 2024 15:05:02 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > On Thu, Oct 03, 2024 at 03:26:03PM +0300, Isaac Boukris wrote:
> > > In practice, the frequency is often not a nice round number, while
> > > the estimation results are rather accurate, just a couple of KHz
> > > away from the kernel's tsc_khz value, so it should suffice.
> > >
> > > Rounding to 10MHz can cause a significant drift from real time,
> > > up to a second per 10 minutes.
> > >
> > > See also bugzilla: 959
> > >
> > > Signed-off-by: Isaac Boukris <iboukris@gmail.com>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Series applied.
Thanks Issac.
--
David Marchand
next prev parent reply other threads:[~2024-10-08 7:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 14:00 [PATCH 1/2] timer/linux: lower rounding of tsc estimation to 10KHz Isaac Boukris
2024-09-21 14:00 ` [PATCH 2/2] timer/linux: override TSC freq if no tsc_known_freq Isaac Boukris
2024-09-24 17:04 ` Isaac Boukris
2024-09-30 15:04 ` Bruce Richardson
2024-09-30 22:08 ` [PATCH v2 0/2] Improve TSC frequency accuracy on Linux Isaac Boukris
2024-09-30 22:08 ` [PATCH v2 1/2] timer/linux: lower rounding of tsc estimation to 100KHz Isaac Boukris
2024-09-30 22:08 ` [PATCH v2 2/2] timer/linux/x86: override TSC freq if no tsc_known_freq Isaac Boukris
2024-10-01 0:10 ` Stephen Hemminger
2024-10-01 0:22 ` [PATCH v3 0/2] Improve TSC frequency accuracy on Linux Isaac Boukris
2024-10-01 0:22 ` [PATCH v3 1/2] timer/linux: lower rounding of tsc estimation to 100KHz Isaac Boukris
2024-10-01 15:18 ` Stephen Hemminger
2024-10-01 0:22 ` [PATCH v3 2/2] timer/linux/x86: override TSC freq if no tsc_known_freq Isaac Boukris
2024-10-01 15:19 ` Stephen Hemminger
2024-10-01 21:56 ` Isaac Boukris
2024-10-01 20:01 ` Bruce Richardson
2024-10-01 21:59 ` Isaac Boukris
2024-10-02 8:06 ` Bruce Richardson
2024-10-02 16:56 ` [PATCH v4 0/2] Improve TSC frequency accuracy Isaac Boukris
2024-10-02 16:56 ` [PATCH v4 1/2] timer: lower rounding of TSC estimation to 100KHz Isaac Boukris
2024-10-02 16:56 ` [PATCH v4 2/2] timer: allow platform to override cpu TSC frequency Isaac Boukris
2024-10-02 17:11 ` Bruce Richardson
2024-10-02 19:14 ` Isaac Boukris
2024-10-03 9:31 ` Bruce Richardson
2024-10-03 12:29 ` Isaac Boukris
2024-10-02 17:12 ` [PATCH v4 0/2] Improve TSC frequency accuracy Bruce Richardson
2024-10-03 12:26 ` [PATCH v5 " Isaac Boukris
2024-10-03 12:26 ` [PATCH v5 1/2] timer: lower rounding of TSC estimation to 100KHz Isaac Boukris
2024-10-03 14:05 ` Bruce Richardson
2024-10-03 15:13 ` Stephen Hemminger
2024-10-08 7:56 ` David Marchand [this message]
2024-10-03 12:26 ` [PATCH v5 2/2] timer: allow platform to override cpu TSC frequency Isaac Boukris
2024-10-03 14:06 ` Bruce Richardson
2024-10-03 15:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wKgN+NrKZEiuEfueVt-gdT52e=+nGt9ybXOQQQrr8Ztw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=iboukris@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).