From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41DF5A034E; Thu, 14 May 2020 13:19:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07B951D8D0; Thu, 14 May 2020 13:19:23 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id CB2FC1D8CE for ; Thu, 14 May 2020 13:19:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589455160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7q1d6PwLwZSYphM+ZPpw2ygry33XZod9jgxs/yL1084=; b=EqPDv2zPEInCLbAcnsAceGqHqb8UP363xclIqxYQO+UQqhIc/H6QBEx9g4OyfAwrYWA+M1 gyr4Neb07wTr2oN4PawwwX0EjARB4DBbMeHGJBa7mN8+yH1joF8+bkzR+Zf7Vj7e5aHpnq +kgz1qT9NzNUCIvdshVIiv3P4xgqsWA= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439-Lg2sTOVBPZOCqBU2fjOyog-1; Thu, 14 May 2020 07:19:19 -0400 X-MC-Unique: Lg2sTOVBPZOCqBU2fjOyog-1 Received: by mail-vk1-f198.google.com with SMTP id u4so1152003vkl.7 for ; Thu, 14 May 2020 04:19:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7q1d6PwLwZSYphM+ZPpw2ygry33XZod9jgxs/yL1084=; b=KmLwyaRC1/zg/DSDiwCcXeSweUYGKO1RgBevc7hX22+43ecYYpl3VEJDFSc/HLQjuN tx09LqZi4oNQfYSjXxxBsRBGtqp5LQRiHhPCjg3KUwXCRKnmc7CozSvF5EMomP2kJEwr ioc8qGGs2chkpEqmsVlQ+bKdrz4tZ+lXXiUChjc23JmWM0DWK+ej0JLLTJX52B/rDJ+b mXjBpCAIr+tSMODj4ft/TOc3TlMn53A18ia/UpcIVtzKpncGDa1Zm7Fr0T2FTlqGbCfT d1TWqHsUhJ7jijRoqnbTAVR3NuFSQcnPMOsaxEq4sHe5fJoxWUPDwYd+TNxyS1kvY0Oz sn8g== X-Gm-Message-State: AOAM532l01GVlYvaTd/BNyU0EAW68oyNs/8F3szO34hnqJ2YfWyu7m5i a+ZVRNPDarcxD3/h73Q6lMvW7QHuX/JVwFsYkSsgI+ZRwijP0JXtYnBo6pxuJ8lUnUy4Jqpgw4b xXBW2fDAsxCi2R3sh21k= X-Received: by 2002:a1f:9a41:: with SMTP id c62mr3050550vke.80.1589455158917; Thu, 14 May 2020 04:19:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5oH0xxrZOOCeQtWY3jQKRZ9DG1ciDvaYyyoXbSTMq9nhSMDcfqMjFZnCRkgvoqKvfyLTLPI9kKC0JprKQVkI= X-Received: by 2002:a1f:9a41:: with SMTP id c62mr3050532vke.80.1589455158540; Thu, 14 May 2020 04:19:18 -0700 (PDT) MIME-Version: 1.0 References: <20200512140100.26803-1-hemant.agrawal@nxp.com> <20200513132745.9006-1-hemant.agrawal@nxp.com> <20200513132745.9006-2-hemant.agrawal@nxp.com> <63aee4d4-db63-de05-2ff1-5f9ae748da80@ashroe.eu> <22cd532f-8b25-df37-29b0-daad10381def@ashroe.eu> <313184ad-539c-5f18-3a19-7939fbd3d730@ashroe.eu> In-Reply-To: <313184ad-539c-5f18-3a19-7939fbd3d730@ashroe.eu> From: David Marchand Date: Thu, 14 May 2020 13:19:07 +0200 Message-ID: To: Ray Kinsella Cc: "Hemant Agrawal (OSS)" , "dev@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 14, 2020 at 1:10 PM Ray Kinsella wrote: > > > > On 14/05/2020 12:06, Hemant Agrawal (OSS) wrote: > > > >> On 14/05/2020 10:53, Hemant Agrawal (OSS) wrote: > >>> [Hemant] Thanks it worked for me. It is not showing any error for the > >> changes in this patchset. > >> > >> I tested it also - and it didn't show an error either, which confused me. As you > >> are dropping a whole bunch of symbols from DPDK v20, it _should_ baulk at > >> this. > >> > >> Need to dig a bit deeper on this. > > > > [Hemant] I have also made change in libabigail.abignore. That should be the reason for no complains? > > yes ... I discovered that since. > are we 100% certain that no end user application would ever have used these symbol? > > [suppress_variable] > name = rte_crypto_aead_algorithm_strings > +; Ignore moving DPAAx stable functions to INTERNAL tag > +[suppress_file] > + file_name_regexp = ^librte_common_dpaax\. > +[suppress_file] > + file_name_regexp = ^librte_mempool_dpaa\. > +[suppress_file] > + file_name_regexp = ^librte_bus_fslmc\. > +[suppress_file] > + file_name_regexp = ^librte_bus_dpaa\. > +[suppress_file] > + file_name_regexp = ^librte_pmd_dpaa\. Ignoring the whole dpaa net driver is wrong as the symbol rte_pmd_dpaa_set_tx_loopback is marked stable. This is used by applications, like testpmd: app/test-pmd/cmdline.c: ret = rte_pmd_dpaa_set_tx_loopback(res->port_id, is_on); You need a more refined filter for this. Public APIs are prefixed with rte_ so maybe whitelisting ^dpaa_ variables/functions? -- David Marchand