From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15EF9A0350; Mon, 11 May 2020 17:21:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14B001C19B; Mon, 11 May 2020 17:21:18 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 037091C126 for ; Mon, 11 May 2020 17:21:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589210474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C4/7i+UP09Xz4kyxAJWhATTB6u3SNkzzaQ5zjsTkemo=; b=eN8cUwnN2XHXpxHzRIwbX7v8HFywJcoN+U0RAQiJlln5C4Ifp+b4wzcnE5j7YN9DkfGNen d1ys5d0nfsShuXJ2vLpis4bf+ditd45QeKU1VQsp+Wp37U8N+NPNAxZCKo+PfzCKHhMTFf 0o8DKpuSO8J+MCU3xJwbPYukWOYhKN0= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-zZuyjxcON1y2nS4o3nWKzQ-1; Mon, 11 May 2020 11:21:13 -0400 X-MC-Unique: zZuyjxcON1y2nS4o3nWKzQ-1 Received: by mail-vs1-f72.google.com with SMTP id q9so1515177vsg.21 for ; Mon, 11 May 2020 08:21:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C4/7i+UP09Xz4kyxAJWhATTB6u3SNkzzaQ5zjsTkemo=; b=OfuC6j2Fvcpo86oc+JFvSJZSUR0u02FuHZXrOmxKFzWW2O8zhtOMZSv4/ldpg2F+AM sgSz6cD3EQx1NMZSN/sKQ2V6iDbaYwV+e8zHeAAhHg4Vtz3e4Q3Lz5d7lC5p6YENeBFr oW3eq5uxVCtJDi+efSJp7Gv3O0PTMt1e63E9t5fzKC5aMhJGhMuCMCnO3yw8tzLQar0Y /ZeRV+KWAGdzimB1GzLZBr64wEQgx+iK0+QAiwSxYULUEoJZg0qTO8nGHkFVvrfdIue5 RhJ6LRMtIt1z8Gj3bIChSPF38hnwmml/IzZs1U1TDigm3YH/ptfdzkPmxZ341983qS7J 99OQ== X-Gm-Message-State: AGi0PuZFr05BRbiy+koP190w9ihV5IMXefOYqub7hGz+Zbwvquusag1K q068MsmmqaLiBClWzH0UnyI9I6Uc+JHMwBSCIi0kdipa8d2FTWLF6qG7CKPfYYnyzdWzEJxn21t Sb6/8Tg5fIzHVQ1WsN2k= X-Received: by 2002:ab0:5ad1:: with SMTP id x17mr11998931uae.126.1589210472170; Mon, 11 May 2020 08:21:12 -0700 (PDT) X-Google-Smtp-Source: APiQypJs3Pld+vRQKmDvO1q0fG+LcHDEKbxa7/lhHoL4BkjrxCH5VOfCr835DW4KmmHQdJRj1Mj4Ih87Z9rkTpNK/uA= X-Received: by 2002:ab0:5ad1:: with SMTP id x17mr11998890uae.126.1589210471687; Mon, 11 May 2020 08:21:11 -0700 (PDT) MIME-Version: 1.0 References: <20200511133212.21444-1-david.marchand@redhat.com> In-Reply-To: <20200511133212.21444-1-david.marchand@redhat.com> From: David Marchand Date: Mon, 11 May 2020 17:21:00 +0200 Message-ID: To: dev Cc: Kevin Laatz , Ciara Power , Bruce Richardson , Keith Wiles X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 11, 2020 at 3:32 PM David Marchand wrote: > > telemetry can not depend on EAL anymore but it still wants to get arch > headers. > We directly point at the right source directories by using the same logic > than EAL. However the special case of armv7 has been missed. > > Fix this by defaulting ARCH_DIR to RTE_ARCH. > > Caught on OBS: > [ 162s] SYMLINK-FILE include/rte_telemetry.h > [ 162s] CC telemetry.o > [ 162s] CC telemetry_data.o > [ 162s] CC telemetry_legacy.o > [ 162s] .../lib/librte_telemetry/telemetry.c:15:10: fatal error: > rte_spinlock.h: No such file or directory > [ 162s] #include > [ 162s] ^~~~~~~~~~~~~~~~ > [ 162s] compilation terminated. > > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > > Signed-off-by: David Marchand Acked-by: Bruce Richardson Applied. -- David Marchand