From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56E45A0548; Mon, 20 Sep 2021 13:11:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF0A640DF7; Mon, 20 Sep 2021 13:11:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id C7D9B40DF5 for <dev@dpdk.org>; Mon, 20 Sep 2021 13:11:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632136299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O3b2z3tnc3x+uu8xmhFxAPLHZBTWlO3Epumgm9qeIQk=; b=b7X4XYXZohYyUNx0U15UZ1Jx1+pXdPHh67st9OxyYIX1fvTJCHLGfpifXi8EBo1xsfIMoe aTbMglCIFdc/HFinxOJW8b8OD1k9XxAsRrlQ7rQzlgzzXk1WYXYaIxTYTgI3uxU/WLeK3P ZVSWvUma0WrZmUGDE4lBBXWIHd2Qfgs= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-xP3ETyRmNsmcGiaqo1RmFg-1; Mon, 20 Sep 2021 07:11:36 -0400 X-MC-Unique: xP3ETyRmNsmcGiaqo1RmFg-1 Received: by mail-lf1-f70.google.com with SMTP id x143-20020a19c795000000b003fa152e3484so10272411lff.23 for <dev@dpdk.org>; Mon, 20 Sep 2021 04:11:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O3b2z3tnc3x+uu8xmhFxAPLHZBTWlO3Epumgm9qeIQk=; b=F17dgyZO/VM8MQcLfaLDDDXfiygTKGP0c3hsmMH15p0BMX3ZEj1gJw9KEEI0O1JrZb ZBFxAIbDA1AQ2LDDMk7KQemax16Qpt+TIqbkyCkBqKBcB7MH3DZhCAxBQliBTNAnhJN1 tbcDSCzFc0Kcl0xZyCQ4DP7fTEvC4ij7HHJz9Z7jW5T40z3LtTWpsAS+jkRRaCzuwzXW I/mgqTUfimzvYseqqMCSb3xAkgFMtxhl9Wq4xqWXZYXJDnn9dZbJOetFL3dDEIzBzVl8 ElS2gwU80/ZhX9L8A8Il9A0bS8DonwmEYp01QTPtVcJ3TGoA9d6m7e76xpxnQOQZnGcy 7oJQ== X-Gm-Message-State: AOAM5330V0yrzIViX0fkgdj72/CEVZ9+3hkjdq+JyVcWfoeE+cWtGsQn k7GZ2I95FO8iz+x0j91v0c0wWwmp8YYzKBXbzCj6mgcKZYDapMaWpVO1R9XmSKjP9QwdFlJCW5y 6+D1nIj2Zu4CDCBXK4G8= X-Received: by 2002:a2e:9a98:: with SMTP id p24mr4198836lji.55.1632136294616; Mon, 20 Sep 2021 04:11:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJys2OlvvIEQfz8eBidnACLJgdUdttZMQYcR8ezwfwR44Kyu2IKh9uMpiXCyicvwcqGkHNnxgh3Fig4HLFVwYF4= X-Received: by 2002:a2e:9a98:: with SMTP id p24mr4198821lji.55.1632136294433; Mon, 20 Sep 2021 04:11:34 -0700 (PDT) MIME-Version: 1.0 References: <20210910231639.789066-1-dmitry.kozliuk@gmail.com> <20210910231639.789066-2-dmitry.kozliuk@gmail.com> In-Reply-To: <20210910231639.789066-2-dmitry.kozliuk@gmail.com> From: David Marchand <david.marchand@redhat.com> Date: Mon, 20 Sep 2021 13:11:23 +0200 Message-ID: <CAJFAV8wMW4xEq=QhQD4C2qwPayKA4uQLFenrPFWmErgPH_MCQA@mail.gmail.com> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Ray Kinsella <mdr@ashroe.eu>, Olivier Matz <olivier.matz@6wind.com> Cc: dev <dev@dpdk.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] cmdline: reduce ABI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Sat, Sep 11, 2021 at 1:17 AM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote: > > Remove the definition of `struct cmdline` from public header. > Deprecation notice: > https://mails.dpdk.org/archives/dev/2020-September/183310.html > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> This patch lgtm. Acked-by: David Marchand <david.marchand@redhat.com> > --- > I would also hide struct rdline to be able to alter buffer size, > but we don't have a deprecation notice for it. Fyi, I found one project looking into a rdline pointer to get the back reference to cmdline stored in opaque. https://github.com/Gandi/packet-journey/blob/master/app/cmdline.c#L1398 This cmdline pointer is then dereferenced to get s_out. Given that we announced cmdline becoming opaque, they would have to handle the first API change in any case. I don't think another API change would really make a big difference to them. Plus, this project seems stuck to 18.08 support. -- David Marchand