From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1E21A0512; Wed, 15 Jan 2020 09:50:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7E451C0BF; Wed, 15 Jan 2020 09:50:58 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id E44CA1C014 for ; Wed, 15 Jan 2020 09:50:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579078257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=654AFxeCkhUcbXYcdwzODTY6phwvR1QX38A44WCddRA=; b=CJS8qQm+g8J6oFQge/xJSEPM8NsqPAjWWbbITWRQ1O04soo8r15t5/akk/wmfBPWGx8Vdj ab4iVHfnHL5W9jDsprD63aemU/zPKZW69Nqrs860gdmuFrcSvqJqHJiPN3F5tiOUwYkwQU TJ1qbbkq16EHkOA6j3n6h58DA/wXLBo= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-178-GRW_abBrNLO48lKjOjvuWw-1; Wed, 15 Jan 2020 03:50:52 -0500 Received: by mail-vk1-f199.google.com with SMTP id y28so6866838vkl.23 for ; Wed, 15 Jan 2020 00:50:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WVi1FfIU4uUInMO9C0A87ZKcCGqIFsHjmmuSBepEeSQ=; b=bgjbYQh+ol6LwdNaX0J1PFo5xVzKeYu6dMkkOg81rXqGcl9lbD/DGJHozqiqMMer+3 L5Ip6P593+rpfXMw1dFgEzkFb+eDZcCxMVdmW8mMQwnMJ6/oMWEEoWgLnUMXg3EchLli 4ClInqsOx4dVMsJZVzWN3f7tiiNSodj6fdSeQ9MXDjcXJlV64FiF9CenqYfucKiFdQ6q fzFKS69vnpOBpeq+joa40Jq2tjQtmUDuf6CEWohwejH6FZg53w+te7lKXXlWyKmGW2Xh wKoSjbBSSloLdKOooczXmApwC9SLcU/jEe4fKq5jllTbx9rtea9Nfy1ccxtZ0E/Waub/ ZsTQ== X-Gm-Message-State: APjAAAVyIBZocNRaxPuWAsPmTItClmEnRa8vL5VtU2dzRXqzRs9Utp5P 2Ij8xc07ZfyCeu8z1sG3pr3b+xv6XlCxFii4IENpWwz9p7jJKP2N+IQ6pKGpM4DXvRxi7IrVFQk TN4wropatnaN9l0zRzaE= X-Received: by 2002:a67:b303:: with SMTP id a3mr3736066vsm.141.1579078252229; Wed, 15 Jan 2020 00:50:52 -0800 (PST) X-Google-Smtp-Source: APXvYqxWJ8srU0diz5zNOe4xZRpfeC3VMMqVmuUwCIfODLdeeVA1lKymQV+TouMeeeKQR/1sTGVgG3NFii2ylHpdc0w= X-Received: by 2002:a67:b303:: with SMTP id a3mr3736058vsm.141.1579078251863; Wed, 15 Jan 2020 00:50:51 -0800 (PST) MIME-Version: 1.0 References: <20200109115631.500056-1-bruce.richardson@intel.com> <20200110215205.513185-1-bruce.richardson@intel.com> <20200114161923.GB1660@bricha3-MOBL.ger.corp.intel.com> <20200114173554.GC1660@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200114173554.GC1660@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Wed, 15 Jan 2020 09:50:40 +0100 Message-ID: To: Bruce Richardson Cc: Luca Boccassi , "Mcnamara, John" , dev , Aaron Conole , Thomas Monjalon X-MC-Unique: GRW_abBrNLO48lKjOjvuWw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 14, 2020 at 6:36 PM Bruce Richardson wrote: > > On Tue, Jan 14, 2020 at 04:35:09PM +0000, Luca Boccassi wrote: > > On Tue, 2020-01-14 at 16:19 +0000, Bruce Richardson wrote: > > > On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > > > > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > > > > < > > > > bruce.richardson@intel.com > > > > > wrote: > > > > > These patches make some improvements to the meson build, > > > > > particularly > > > > > for documentation. They also remove many, but not all warnings > > > > > issued > > > > > by meson e.g. warnings about newer features unsupported in > > > > > baseline. > > > > > > > > > > The biggest change is to improve the handling of the guide html > > > > > docs. > > > > > The change here is more significant, and the doc build now uses a > > > > > wrapper script around sphinx. This wrapper script allows us to > > > > > output > > > > > correct dependency information for the sphinx build in a .d file. > > > > > This > > > > > .d file is processed by ninja (not meson) on build, so that any > > > > > changes > > > > > to doc files trigger a rebuild to the guides using sphinx. > > > > > > > > > > For now, the two patches which remove the meson version warnings > > > > > are > > > > > CC'ed to stable for backport, theoretically this who set could be > > > > > backported if so desired, as all changes could be considered > > > > > fixes to > > > > > some degree or other, and nothing introduces a whole new feature. > > > > > > > > > > Note: for completeness and simplicity, previously submitted patch > > > > > http://patches.dpdk.org/patch/64189/ > > > > > is included in this set, and will > > > > > be marked superceded in patchwork. > > > > > > > > > > V4: fix build with older sphinx > > > > > > > > > > V3: Shorten the python code in patch 5, and ensure style > > > > > compliance as > > > > > flagged by Aaron. > > > > > > > > > > V2: resend to correct email addresses > > > > > > > > Tried this series in Travis. It went fine through my own checks > > > > too. > > > > > > > > But OBS is not happy with Debian 10, Debian Next and Ubuntu >=3D > > > > 18.04. > > > > The packaging fails when ninja can't find the 'doc' target. > > > > > > > > > > Can you send on a link to the failure logs? > > > > > > I suspect this may be due to returning early from the doc folder if > > > the > > > document building is disabled (but need to see logs to confirm). > > > However, > > > I'm not sure it makes sense to have a doc target defined if doc > > > building is > > > disabled in build config. > > > > Sorry, should have thought about this when reviewing: the usefulness of > > having the target work without the option set is that the docs will > > only be built when called explicitly, without having to change the > > configuration. > > > > Given the doc build is very slow and it's arch-independent, in > > Debian/Ubuntu we only do it once, in the arch-independent target (arch: > > all). > > > Right. I think the offending patch #2, can just be dropped from the set. Ok, I dropped this patch. Packages for debian distributions in OBS build fine now. I am ok with a followup patch for fc30, I disabled the doc check in my env for now. Series & ~patch2 applied. Thanks. -- David Marchand