From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45EB9A0C45; Wed, 20 Oct 2021 08:32:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C458440150; Wed, 20 Oct 2021 08:32:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C8A1E40142 for ; Wed, 20 Oct 2021 08:32:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634711569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ax07eQH7mJMbHJpvD3O1psHlDWhgEhbp55fLTd+z6I4=; b=iWcD+bbgKF4BHWLAVy9Bk6yG5O29EZ3hKd3X1oL+82Iyjv1AfsCgVhCCIc+c/DKmzIGHql sPdiP+awyycJTyR3SJTwrX4LdmLAuuvmhZAfuySYV5pRm9CITnzzYaITWjLL06b5PZzF3w n2tnL1X8Vi5mS2BX4ISbr96jkCEsKSg= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-506-kaObBm2sNLa2qKwRznkfiw-1; Wed, 20 Oct 2021 02:32:47 -0400 X-MC-Unique: kaObBm2sNLa2qKwRznkfiw-1 Received: by mail-lj1-f198.google.com with SMTP id z9-20020a2e3509000000b00210f31ea0e3so1406283ljz.16 for ; Tue, 19 Oct 2021 23:32:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ax07eQH7mJMbHJpvD3O1psHlDWhgEhbp55fLTd+z6I4=; b=VO7eKnkOZOrF8DgtrbdHBX2Bmy4LzgbAmgNH+WMxSB7LrAprKs/JE+fhW/gx/ZI95S vsPmgeKP/nicHpfNfJMyfVQGEPeOBsqKIs7LClD2Hb2wmM+JEAOSYJCG8bcabhY8Z/E0 /UDNUtKqwwFkiERmxGwr1jrsYvT+NdzeM/0J3MlqLLdo2guOVMDKyE8WxQA8ztHHmNmA 6OiooUb2ap78010XRPqI3CdEsH5izEG9feZ957AXZHDKD4n4BeUwWwD5WK0S0KYG3Qcb Thmm7lpT7SC4fMa4njaHIA1S5TPBbf6vO8j4GgdzD3bFww14v/26RuuJAk9wpAZMmhdw eGIw== X-Gm-Message-State: AOAM53165NuxBIislKt/v5W1+FvWuVlaMQB/UqnnvEXPIu7R2/uc511c AAiIn1AjydZ9Fhj1XSEcOy/GOMPIEJgriDyYkberWfy18v5T2+XNucMsRrPUL5RxDdodC2+TfEm bPDloWCBHcFZ05YbSwFA= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr10330168lfu.575.1634711566377; Tue, 19 Oct 2021 23:32:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFVZbpX/G9vIzgt0otCVGQUWY7zCrx7babtWfGvTttzoL5KxqDscHTzkArUkruf82oZpyBl0ZUcEwpjirRqxk= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr10330154lfu.575.1634711566207; Tue, 19 Oct 2021 23:32:46 -0700 (PDT) MIME-Version: 1.0 References: <20211019122800.1537505-1-bruce.richardson@intel.com> In-Reply-To: <20211019122800.1537505-1-bruce.richardson@intel.com> From: David Marchand Date: Wed, 20 Oct 2021 08:32:35 +0200 Message-ID: To: Bruce Richardson Cc: dev , Chengwen Feng , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 2:28 PM Bruce Richardson wrote: > > The dmadev library was not added to the list of libraries built on > Windows, meaning it was skipped in those builds and also that none of > the drivers were being considered for build. Adding dmadev to the list > fixes this, and also enables the skeleton dmadev driver to be built - > all-be-it with a small fix necessary. > > Signed-off-by: Bruce Richardson > --- > > This patch has been compile tested using mingw on Linux. Sending it > publicly so that I can get CI test reports to check native windows > builds. > --- There is a problem with exported symbols. Some inlines have been marked for versioning (see rte_dma_burst_capacity for example) and must be removed from version.map. Can you have a look? ==== 20 line log output for Windows Server 2019 (dpdk_meson_compile): ==== "clang" -Wl,/MACHINE:X64 -Wl,/OUT:lib/rte_dmadev-22.dll lib/librte_dmadev.a.p/dmadev_rte_dmadev.c.obj "-Wl,/nologo" "-Wl,/release" "-Wl,/nologo" "-Wl,/OPT:REF" "-Wl,/DLL" "-Wl,/IMPLIB:lib\rte_dmadev.lib" "lib\rte_eal.lib" "lib\rte_kvargs.lib" "-Wl,/def:C:\Users\builder\jenkins\workspace\Windows-Compile-DPDK-Meson\dpdk\build\lib\rte_dmadev_exports.def" "-ldbghelp" "-lsetupapi" "-lws2_32" "-lmincore" "-lkernel32" "-luser32" "-lgdi32" "-lwinspool" "-lshell32" "-lole32" "-loleaut32" "-luuid" "-lcomdlg32" "-ladvapi32" rte_dmadev_exports.def : error LNK2001: unresolved external symbol rte_dma_burst_capacity rte_dmadev_exports.def : error LNK2001: unresolved external symbol rte_dma_completed rte_dmadev_exports.def : error LNK2001: unresolved external symbol rte_dma_completed_status rte_dmadev_exports.def : error LNK2001: unresolved external symbol rte_dma_copy rte_dmadev_exports.def : error LNK2001: unresolved external symbol rte_dma_copy_sg rte_dmadev_exports.def : error LNK2001: unresolved external symbol rte_dma_fill rte_dmadev_exports.def : error LNK2001: unresolved external symbol rte_dma_submit lib\rte_dmadev.lib : fatal error LNK1120: 7 unresolved externals clang: error: linker command failed with exit code 1120 (use -v to see invocation) [485/536] Linking target lib/rte_timer-22.dll Creating library lib\rte_timer.lib and object lib\rte_timer.exp [486/536] Linking target lib/rte_cfgfile-22.dll Creating library lib\rte_cfgfile.lib and object lib\rte_cfgfile.exp [487/536] Linking target lib/rte_pci-22.dll Creating library lib\rte_pci.lib and object lib\rte_pci.exp [488/536] Generating symbol file lib/rte_meter-22.dll.p/rte_meter-22.dll.symbols [489/536] Generating symbol file lib/rte_ring-22.dll.p/rte_ring-22.dll.symbols ninja: build stopped: subcommand failed. [1] Error running command. ==== End log output ==== -- David Marchand