From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5A47A04B5; Thu, 29 Oct 2020 09:52:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D182C82A; Thu, 29 Oct 2020 09:52:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 08228C81A for ; Thu, 29 Oct 2020 09:52:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603961521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6UvpqPcSb72sI79VfRy7zFW1IbXFLNYIeuG6Km4P23U=; b=VqqQfxmYEeCPoYacjcn6iNZ6QNqdM0eX26MpusU86AH59ujW3Q+ntBnhqQLSx+nIlpNtuX n71X71skEdoJcsK2To+Zj9vvpn0vWT7QJYToszqOukcUSU/UN/dvfkLs2zN30cB0FDry5A ReJgieMZ27nXf5m2N7jVDGgFVHykDaU= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-g9cR1Y8DMMSGtzl-dnBEXQ-1; Thu, 29 Oct 2020 04:51:58 -0400 X-MC-Unique: g9cR1Y8DMMSGtzl-dnBEXQ-1 Received: by mail-vs1-f72.google.com with SMTP id k22so409583vsg.5 for ; Thu, 29 Oct 2020 01:51:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6UvpqPcSb72sI79VfRy7zFW1IbXFLNYIeuG6Km4P23U=; b=lKxTEFQDKwKlS8Hj4adjHMLeRgcwTTFrSw3HxC32Xklf7+IOaEEB2yc3a1HImqBItr 9gWPmfRYZzHRbi0O5+UKwWivGtAhucONkUR+j+d7nWI1qsobBBEYndzr7xTdfU3sNw4u Uhzed4SqmvlZeSI1Y2MCG37ptHiG3nmt/aYP3vJuir+q3jzip7xfjI3SVnnxSIhmqbne te8JNKiwjHvEhSGG2LdLPxWAHmlH06V8BPwu6bt2G0HSuwIsLuBZGW28KXXzrFSSTj/h KS+As/3U7pifNPw8ykDJ6UcwVdT6zgti0uisEUQ2zqTrUWrpb3zGwq3VitCsFJlgH5Fk lRtQ== X-Gm-Message-State: AOAM532ZAnHIaOoUFIbmbRy1BOh4I0Hp80qQGvRrviG3RCvL1fCYK08B i0zVBfgIWsWXQ+Ccbny/PK1RE31pCYCYoV29ssUinmM5JbYVM8XqU709k2wVfulLhH9bt9DjErw ystfdq27DCsikbXDHpqY= X-Received: by 2002:a67:2fca:: with SMTP id v193mr2238374vsv.18.1603961518053; Thu, 29 Oct 2020 01:51:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuFCp1ZjD2INB2c2TGXRGzfPoMAkg0s+xntBUnEnSd9Hsw/kRnreDxKw6Ar/QyohePjNB5mhxR+8XGPPU7mx8= X-Received: by 2002:a67:2fca:: with SMTP id v193mr2238365vsv.18.1603961517792; Thu, 29 Oct 2020 01:51:57 -0700 (PDT) MIME-Version: 1.0 References: <20201023080058.13335-1-david.marchand@redhat.com> <20201028210249.9021-1-david.marchand@redhat.com> <20201028210249.9021-3-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 29 Oct 2020 09:51:46 +0100 Message-ID: To: Sunil Kumar Kori Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH v2 2/4] trace: remove size limit on CTF event description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 29, 2020 at 9:41 AM Sunil Kumar Kori wrote: > >@@ -505,15 +504,11 @@ __rte_trace_point_register(rte_trace_point_t > >*handle, const char *name, > > goto free; > > } > > > >- /* Copy the field data for future use */ > >- if (rte_strscpy(tp->ctf_field, field, TRACE_CTF_FIELD_SIZE) < 0) { > >- trace_err("CTF field size is too long"); > >- rte_errno = E2BIG; > >- goto free; > >- } > >- > >- /* Clear field memory for the next event */ > >- memset(field, 0, TRACE_CTF_FIELD_SIZE); > >+ /* Copy the accumulated fields description and clear it for the next > >+ * trace point. > >+ */ > >+ tp->ctf_field = RTE_PER_LCORE(ctf_field); > >+ RTE_PER_LCORE(ctf_field) = NULL; > > Although patch looks okay but I have one that how "tp->ctf_field" is populated because during > registration time RTE_PER_LCORE(ctf_field) will be NULL. So "tp->ctf_field" will always be NULL. Sorry, I don't understand your comment. RTE_PER_LCORE(ctf_field) is filled at __rte_trace_point_emit_field. -- David Marchand